You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/08/26 05:12:00 UTC

[jira] [Commented] (PARQUET-2177) Fix parquet-cli not to fail showing descriptions

    [ https://issues.apache.org/jira/browse/PARQUET-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585155#comment-17585155 ] 

ASF GitHub Bot commented on PARQUET-2177:
-----------------------------------------

sekikn opened a new pull request, #991:
URL: https://github.com/apache/parquet-mr/pull/991

   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-2177
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   No additional test, instead:
   
   * Ran `mvn clean install` locally and got no build and test failure.
   * Ran the `help prune` and `help masking` commands and ensured their descriptions were displayed as expected. Also ran `help meta` and there was no regression problem.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   




> Fix parquet-cli not to fail showing descriptions
> ------------------------------------------------
>
>                 Key: PARQUET-2177
>                 URL: https://issues.apache.org/jira/browse/PARQUET-2177
>             Project: Parquet
>          Issue Type: Bug
>            Reporter: Kengo Seki
>            Assignee: Kengo Seki
>            Priority: Minor
>
> Currently, trying to show the descriptions of the 'prune' and 'masking' subcommands leads to NPE as follows.
> {code}
> $ java -cp 'target/parquet-cli-1.13.0-SNAPSHOT.jar:target/dependency/*' org.apache.parquet.cli.Main help prune
> Exception in thread "main" java.lang.NullPointerException
> 	at com.beust.jcommander.JCommander$MainParameter.access$900(JCommander.java:64)
> 	at com.beust.jcommander.JCommander.getMainParameterDescription(JCommander.java:965)
> 	at org.apache.parquet.cli.Help.run(Help.java:65)
> 	at org.apache.parquet.cli.Main.run(Main.java:146)
> 	at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
> 	at org.apache.parquet.cli.Main.main(Main.java:189)
> {code}
> {code}
> $ java -cp 'target/parquet-cli-1.13.0-SNAPSHOT.jar:target/dependency/*' org.apache.parquet.cli.Main help masking
> Exception in thread "main" java.lang.NullPointerException
> 	at com.beust.jcommander.JCommander$MainParameter.access$900(JCommander.java:64)
> 	at com.beust.jcommander.JCommander.getMainParameterDescription(JCommander.java:965)
> 	at org.apache.parquet.cli.Help.run(Help.java:65)
> 	at org.apache.parquet.cli.Main.run(Main.java:146)
> 	at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
> 	at org.apache.parquet.cli.Main.main(Main.java:189)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)