You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Purshotam Shah <pu...@yahoo-inc.com> on 2014/02/19 03:05:23 UTC
Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord
end-time before start time
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1703
https://issues.apache.org/jira/browse/OOZIE-1703
Repository: oozie-git
Description
-------
This is one of the important use-case in case of versioning.
User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
We should also lookahead at created actions that become invalid because of the new end time.
These actions should be deleted from DB.
Diffs
-----
core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java cd2c844
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 4957330
core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java b9bbf16
docs/src/site/twiki/DG_CommandLineTool.twiki 0748ff8
Diff: https://reviews.apache.org/r/18257/diff/
Testing
-------
Thanks,
Purshotam Shah
Re: Review Request 18257: [OOZIE-1703] User should be able to set
bundle/coord end-time before start time
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/#review34943
-----------------------------------------------------------
Now i'm also thinking if we should set bundle/coord status for this case to SUSPENDED instead of just PREP.
- Mona Chitnis
On Feb. 19, 2014, 2:05 a.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18257/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 2:05 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1703
> https://issues.apache.org/jira/browse/OOZIE-1703
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> This is one of the important use-case in case of versioning.
>
> User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
>
>
> We should also lookahead at created actions that become invalid because of the new end time.
> These actions should be deleted from DB.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java cd2c844
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 4957330
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java b9bbf16
> docs/src/site/twiki/DG_CommandLineTool.twiki 0748ff8
>
> Diff: https://reviews.apache.org/r/18257/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 18257: [OOZIE-1703] User should be able to set
bundle/coord end-time before start time
Posted by Mona Chitnis <mo...@yahoo.in>.
> On Feb. 19, 2014, 11:34 p.m., Mona Chitnis wrote:
> > core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java, line 102
> > <https://reviews.apache.org/r/18257/diff/2/?file=497340#file497340line102>
> >
> > We should atleast check for DateUtils.parseDate(endTime) here for any exceptions thrown by an invalid date. Check that this is done in a central place for starttime too. If not, add there too
can this get addressed?
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/#review34940
-----------------------------------------------------------
On Feb. 21, 2014, 10:26 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18257/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2014, 10:26 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1703
> https://issues.apache.org/jira/browse/OOZIE-1703
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> This is one of the important use-case in case of versioning.
>
> User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
>
>
> We should also lookahead at created actions that become invalid because of the new end time.
> These actions should be deleted from DB.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java cd2c844
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 4957330
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java b9bbf16
> docs/src/site/twiki/DG_CommandLineTool.twiki 0748ff8
>
> Diff: https://reviews.apache.org/r/18257/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 18257: [OOZIE-1703] User should be able to set
bundle/coord end-time before start time
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/#review34940
-----------------------------------------------------------
BundleStartXCommand's verifyPrecondition() needs to be changed as well. It only sees status = PREP and begins adding bundle actions again and submitting new coordinators. It should now also check about endtime being set. Add unit test covering this case
core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment65330>
We should atleast check for DateUtils.parseDate(endTime) here for any exceptions thrown by an invalid date. Check that this is done in a central place for starttime too. If not, add there too
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment65331>
New 'what' date? specify pause/end to avoid ambiguity in this message.
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment65332>
whitespace
- Mona Chitnis
On Feb. 19, 2014, 2:05 a.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18257/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 2:05 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1703
> https://issues.apache.org/jira/browse/OOZIE-1703
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> This is one of the important use-case in case of versioning.
>
> User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
>
>
> We should also lookahead at created actions that become invalid because of the new end time.
> These actions should be deleted from DB.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java cd2c844
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 4957330
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java b9bbf16
> docs/src/site/twiki/DG_CommandLineTool.twiki 0748ff8
>
> Diff: https://reviews.apache.org/r/18257/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 18257: [OOZIE-1703] User should be able to set
bundle/coord end-time before start time
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/#review37269
-----------------------------------------------------------
The unit test does not test for bundle status being updated to SUSPENDED. Also it is not testing the case where start time is after end time
- Mona Chitnis
On Feb. 21, 2014, 10:26 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18257/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2014, 10:26 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1703
> https://issues.apache.org/jira/browse/OOZIE-1703
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> This is one of the important use-case in case of versioning.
>
> User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
>
>
> We should also lookahead at created actions that become invalid because of the new end time.
> These actions should be deleted from DB.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java cd2c844
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 4957330
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java b9bbf16
> docs/src/site/twiki/DG_CommandLineTool.twiki 0748ff8
>
> Diff: https://reviews.apache.org/r/18257/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 18257: [OOZIE-1703] User should be able to set
bundle/coord end-time before start time
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/#review38352
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment70435>
Bundle status will be changes to succeeded.
There is a below code which will issue change command for all child coords
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment71245>
It was a blunder. Thanks for catching that.
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment70436>
status will be changed to succeed
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment70437>
Added action check for lookahead
- Purshotam Shah
On March 31, 2014, 5:31 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18257/
> -----------------------------------------------------------
>
> (Updated March 31, 2014, 5:31 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1703
> https://issues.apache.org/jira/browse/OOZIE-1703
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> This is one of the important use-case in case of versioning.
>
> User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
>
>
> We should also lookahead at created actions that become invalid because of the new end time.
> These actions should be deleted from DB.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java cd2c844
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 5ecd5d5
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleChangeXCommand.java 6560db6
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java fdc0a55
> docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2
>
> Diff: https://reviews.apache.org/r/18257/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 18257: [OOZIE-1703] User should be able to set
bundle/coord end-time before start time
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/#review39346
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment71706>
Please revert the changes in BundleJobChangeXCommand. It does not make sense to allow setting pausetime or endtime before start time. If the bundle is not started, it can be killed. Setting endtime to before start time of bundle is convoluted. We only want it for coordinators as same end time will be applied to all coordinators.
BundleJobChangeXCommand allows changing end time but it is not part of the commandline or webservice documentation. Please update documentation for that.
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment71716>
You need to check for lastActionTime which is not PREP, WAITING or READY. Else the processLookAheadActions code will never be executed.
Need to add that check for checkPauseTime as well. Else processLookAheadActions will have a big bug where it goes and deletes even RUNNING actions without killing the hadoop jobs.
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment71715>
This has a big bug where it goes and deletes even RUNNING actions without killing the hadoop jobs. Please do not delete running actions. Either we need to queue kill commands for them or throw an error in checkEndTime and checkPauseTime.
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/18257/#comment71704>
Conditions and usage:
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/18257/#comment71705>
if they are in WAITING state.
For actions already in RUNNING state we need to make a decision and either
- Kill all actions that are RUNNING
- Or throw an error if they are RUNNING actions after the endtime/pause time.
- Rohini Palaniswamy
On March 31, 2014, 5:31 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18257/
> -----------------------------------------------------------
>
> (Updated March 31, 2014, 5:31 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1703
> https://issues.apache.org/jira/browse/OOZIE-1703
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> This is one of the important use-case in case of versioning.
>
> User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
>
>
> We should also lookahead at created actions that become invalid because of the new end time.
> These actions should be deleted from DB.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java cd2c844
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 5ecd5d5
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleChangeXCommand.java 6560db6
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java fdc0a55
> docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2
>
> Diff: https://reviews.apache.org/r/18257/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 18257: [OOZIE-1703] User should be able to set
bundle/coord end-time before start time
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
> On April 10, 2014, 5:41 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java, line 261
> > <https://reviews.apache.org/r/18257/diff/7/?file=554199#file554199line261>
> >
> > Changing both endtime and pausetime do not work with cron based frequencies as we deal with lastActionNumber. Can you create a sub task jira under the cron jira to support working with cron frequencies?
Changed the logic.
lastActionNumber of nth action = n+1 th nominal time.
- Purshotam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/#review40011
-----------------------------------------------------------
On April 9, 2014, 11:57 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18257/
> -----------------------------------------------------------
>
> (Updated April 9, 2014, 11:57 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1703
> https://issues.apache.org/jira/browse/OOZIE-1703
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> This is one of the important use-case in case of versioning.
>
> User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
>
>
> We should also lookahead at created actions that become invalid because of the new end time.
> These actions should be deleted from DB.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 5ecd5d5
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java d1c5752
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java fdc0a55
> core/src/test/java/org/apache/oozie/test/XDataTestCase.java 423944a
> docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2
>
> Diff: https://reviews.apache.org/r/18257/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 18257: [OOZIE-1703] User should be able to set
bundle/coord end-time before start time
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/#review40011
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment72794>
Changing both endtime and pausetime do not work with cron based frequencies as we deal with lastActionNumber. Can you create a sub task jira under the cron jira to support working with cron frequencies?
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment72837>
coordJob.resetPending();
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment72796>
Should be in else {} block. resetMaterialization should also be in the else block.
core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment72802>
What is the difference with testCoordChangeEndTimeDeleteAction. Just put a comment.
core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment72801>
testCoordChangeEndTimeBeforeStart
core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment72800>
testChangeTimeDeleteRunning
- Rohini Palaniswamy
On April 9, 2014, 11:57 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18257/
> -----------------------------------------------------------
>
> (Updated April 9, 2014, 11:57 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1703
> https://issues.apache.org/jira/browse/OOZIE-1703
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> This is one of the important use-case in case of versioning.
>
> User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
>
>
> We should also lookahead at created actions that become invalid because of the new end time.
> These actions should be deleted from DB.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 5ecd5d5
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java d1c5752
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java fdc0a55
> core/src/test/java/org/apache/oozie/test/XDataTestCase.java 423944a
> docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2
>
> Diff: https://reviews.apache.org/r/18257/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 18257: [OOZIE-1703] User should be able to set
bundle/coord end-time before start time
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
> On April 10, 2014, 6:18 p.m., Bowen Zhang wrote:
> > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java, line 549
> > <https://reviews.apache.org/r/18257/diff/7/?file=554199#file554199line549>
> >
> > Cannot assume frequency is an integer. If the frequency is cron syntax, the code will break. Need to consider both cases for coord frequency.
Discussed same with Rohini,
Her comment.
"Changing both endtime and pausetime do not work with cron based frequencies as we deal with lastActionNumber. Can you create a sub task jira under the cron jira to support working with cron frequencies?"
There were many places we assume frequency as integer, so it was a bigger task. we thought of going ahead and fix it later by creating JIRA( as it need to be fixed for many scenario).
Not applicable now, I have changed the logic.
- Purshotam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/#review40051
-----------------------------------------------------------
On April 9, 2014, 11:57 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18257/
> -----------------------------------------------------------
>
> (Updated April 9, 2014, 11:57 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1703
> https://issues.apache.org/jira/browse/OOZIE-1703
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> This is one of the important use-case in case of versioning.
>
> User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
>
>
> We should also lookahead at created actions that become invalid because of the new end time.
> These actions should be deleted from DB.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 5ecd5d5
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java d1c5752
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java fdc0a55
> core/src/test/java/org/apache/oozie/test/XDataTestCase.java 423944a
> docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2
>
> Diff: https://reviews.apache.org/r/18257/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 18257: [OOZIE-1703] User should be able to set
bundle/coord end-time before start time
Posted by Bowen Zhang <bo...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/#review40051
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment72860>
"befor start time" missing "e" for "before"
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment72861>
Cannot assume frequency is an integer. If the frequency is cron syntax, the code will break. Need to consider both cases for coord frequency.
- Bowen Zhang
On April 9, 2014, 11:57 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18257/
> -----------------------------------------------------------
>
> (Updated April 9, 2014, 11:57 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1703
> https://issues.apache.org/jira/browse/OOZIE-1703
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> This is one of the important use-case in case of versioning.
>
> User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
>
>
> We should also lookahead at created actions that become invalid because of the new end time.
> These actions should be deleted from DB.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 5ecd5d5
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java d1c5752
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java fdc0a55
> core/src/test/java/org/apache/oozie/test/XDataTestCase.java 423944a
> docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2
>
> Diff: https://reviews.apache.org/r/18257/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 18257: [OOZIE-1703] User should be able to set
bundle/coord end-time before start time
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/#review40089
-----------------------------------------------------------
Ship it!
Looks good. Please remove the unused method in the final patch uploaded to jira.
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment72920>
Please remove this method as it is not used anymore.
- Rohini Palaniswamy
On April 10, 2014, 7:42 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18257/
> -----------------------------------------------------------
>
> (Updated April 10, 2014, 7:42 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1703
> https://issues.apache.org/jira/browse/OOZIE-1703
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> This is one of the important use-case in case of versioning.
>
> User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
>
>
> We should also lookahead at created actions that become invalid because of the new end time.
> These actions should be deleted from DB.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 5ecd5d5
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java d1c5752
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java fdc0a55
> core/src/test/java/org/apache/oozie/test/XDataTestCase.java 423944a
> docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2
>
> Diff: https://reviews.apache.org/r/18257/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 18257: [OOZIE-1703] User should be able to set
bundle/coord end-time before start time
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/#review40408
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On April 15, 2014, 12:16 a.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18257/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 12:16 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1703
> https://issues.apache.org/jira/browse/OOZIE-1703
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> This is one of the important use-case in case of versioning.
>
> User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
>
>
> We should also lookahead at created actions that become invalid because of the new end time.
> These actions should be deleted from DB.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 5ecd5d5
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java d1c5752
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java fdc0a55
> core/src/test/java/org/apache/oozie/test/XDataTestCase.java 423944a
> docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2
>
> Diff: https://reviews.apache.org/r/18257/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 18257: [OOZIE-1703] User should be able to set
bundle/coord end-time before start time
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/
-----------------------------------------------------------
(Updated April 15, 2014, 12:16 a.m.)
Review request for oozie.
Changes
-------
Minor doc change + multiple change command where end date<start date should not change job status to running.
Bugs: OOZIE-1703
https://issues.apache.org/jira/browse/OOZIE-1703
Repository: oozie-git
Description
-------
This is one of the important use-case in case of versioning.
User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
We should also lookahead at created actions that become invalid because of the new end time.
These actions should be deleted from DB.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 5ecd5d5
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java d1c5752
core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java fdc0a55
core/src/test/java/org/apache/oozie/test/XDataTestCase.java 423944a
docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2
Diff: https://reviews.apache.org/r/18257/diff/
Testing
-------
Thanks,
Purshotam Shah
Re: Review Request 18257: [OOZIE-1703] User should be able to set
bundle/coord end-time before start time
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/
-----------------------------------------------------------
(Updated April 10, 2014, 7:42 p.m.)
Review request for oozie.
Changes
-------
Addressing review comment.
Bugs: OOZIE-1703
https://issues.apache.org/jira/browse/OOZIE-1703
Repository: oozie-git
Description
-------
This is one of the important use-case in case of versioning.
User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
We should also lookahead at created actions that become invalid because of the new end time.
These actions should be deleted from DB.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 5ecd5d5
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java d1c5752
core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java fdc0a55
core/src/test/java/org/apache/oozie/test/XDataTestCase.java 423944a
docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2
Diff: https://reviews.apache.org/r/18257/diff/
Testing
-------
Thanks,
Purshotam Shah
Re: Review Request 18257: [OOZIE-1703] User should be able to set
bundle/coord end-time before start time
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/
-----------------------------------------------------------
(Updated April 9, 2014, 11:57 p.m.)
Review request for oozie.
Changes
-------
Addressing review comment.
Bugs: OOZIE-1703
https://issues.apache.org/jira/browse/OOZIE-1703
Repository: oozie-git
Description
-------
This is one of the important use-case in case of versioning.
User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
We should also lookahead at created actions that become invalid because of the new end time.
These actions should be deleted from DB.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 5ecd5d5
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java d1c5752
core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java fdc0a55
core/src/test/java/org/apache/oozie/test/XDataTestCase.java 423944a
docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2
Diff: https://reviews.apache.org/r/18257/diff/
Testing
-------
Thanks,
Purshotam Shah
Re: Review Request 18257: [OOZIE-1703] User should be able to set
bundle/coord end-time before start time
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
> On April 8, 2014, 10:52 p.m., Rohini Palaniswamy wrote:
> > core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java, line 240
> > <https://reviews.apache.org/r/18257/diff/6/?file=552724#file552724line240>
> >
> > Why change this?
Because job start time is 2009-02-01T01:08Z, i have to pause it before start time to throw exception.
> On April 8, 2014, 10:52 p.m., Rohini Palaniswamy wrote:
> > core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java, line 220
> > <https://reviews.apache.org/r/18257/diff/6/?file=552724#file552724line220>
> >
> > Why change this?
Because job start time is 2009-02-01T01:08Z, i have to pause it before start time to throw exception.
> On April 8, 2014, 10:52 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java, lines 288-290
> > <https://reviews.apache.org/r/18257/diff/6/?file=552723#file552723line288>
> >
> > Why is this required? Should be able to set the nominal time as it is on the last action time
lastactiontime and next materialization time = lastnominal time + frequency.
> On April 8, 2014, 10:52 p.m., Rohini Palaniswamy wrote:
> > core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java, lines 441-445
> > <https://reviews.apache.org/r/18257/diff/6/?file=552724#file552724line441>
> >
> > Please get action and assert not null. Don't have to assert fail in case of exception. Only if you have to assert on the exception type or message catch exceptions. junit will automatically fail the test if there is exception.
It's just to check that action 2 is present and didn't get deleted. Function will throw exception if action is not found.
- Purshotam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/#review39830
-----------------------------------------------------------
On April 8, 2014, 5:28 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18257/
> -----------------------------------------------------------
>
> (Updated April 8, 2014, 5:28 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1703
> https://issues.apache.org/jira/browse/OOZIE-1703
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> This is one of the important use-case in case of versioning.
>
> User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
>
>
> We should also lookahead at created actions that become invalid because of the new end time.
> These actions should be deleted from DB.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 5ecd5d5
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java fdc0a55
> core/src/test/java/org/apache/oozie/test/XDataTestCase.java 423944a
> docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2
>
> Diff: https://reviews.apache.org/r/18257/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 18257: [OOZIE-1703] User should be able to set
bundle/coord end-time before start time
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/#review39830
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment72495>
Needs to be reverted. You are now allowing a pausetime in past.
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment72496>
Why is this required? Should be able to set the nominal time as it is on the last action time
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment72497>
afterDate
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment72508>
It is not ok to remove this. Was added to address OOZIE-1632
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment72509>
Changing
core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment72510>
Why change this?
core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment72511>
Why change this?
core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment72513>
Please get action and assert not null. Don't have to assert fail in case of exception. Only if you have to assert on the exception type or message catch exceptions. junit will automatically fail the test if there is exception.
core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment72515>
Can we combine this testcase with testCoordActionDelete as most of the code is duplicated. i.e assert for endtime and pausetime in the same test.
- Rohini Palaniswamy
On April 8, 2014, 5:28 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18257/
> -----------------------------------------------------------
>
> (Updated April 8, 2014, 5:28 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1703
> https://issues.apache.org/jira/browse/OOZIE-1703
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> This is one of the important use-case in case of versioning.
>
> User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
>
>
> We should also lookahead at created actions that become invalid because of the new end time.
> These actions should be deleted from DB.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 5ecd5d5
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java fdc0a55
> core/src/test/java/org/apache/oozie/test/XDataTestCase.java 423944a
> docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2
>
> Diff: https://reviews.apache.org/r/18257/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 18257: [OOZIE-1703] User should be able to set
bundle/coord end-time before start time
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/
-----------------------------------------------------------
(Updated April 8, 2014, 5:28 p.m.)
Review request for oozie.
Changes
-------
addressing review comments.
Bugs: OOZIE-1703
https://issues.apache.org/jira/browse/OOZIE-1703
Repository: oozie-git
Description
-------
This is one of the important use-case in case of versioning.
User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
We should also lookahead at created actions that become invalid because of the new end time.
These actions should be deleted from DB.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 5ecd5d5
core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java fdc0a55
core/src/test/java/org/apache/oozie/test/XDataTestCase.java 423944a
docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2
Diff: https://reviews.apache.org/r/18257/diff/
Testing
-------
Thanks,
Purshotam Shah
Re: Review Request 18257: [OOZIE-1703] User should be able to set
bundle/coord end-time before start time
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/
-----------------------------------------------------------
(Updated April 4, 2014, 10:25 p.m.)
Review request for oozie.
Changes
-------
Addressing review comment.
Bugs: OOZIE-1703
https://issues.apache.org/jira/browse/OOZIE-1703
Repository: oozie-git
Description
-------
This is one of the important use-case in case of versioning.
User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
We should also lookahead at created actions that become invalid because of the new end time.
These actions should be deleted from DB.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 5ecd5d5
core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java fdc0a55
docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2
Diff: https://reviews.apache.org/r/18257/diff/
Testing
-------
Thanks,
Purshotam Shah
Re: Review Request 18257: [OOZIE-1703] User should be able to set
bundle/coord end-time before start time
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/
-----------------------------------------------------------
(Updated March 31, 2014, 5:31 p.m.)
Review request for oozie.
Changes
-------
addressing review comment.
Bugs: OOZIE-1703
https://issues.apache.org/jira/browse/OOZIE-1703
Repository: oozie-git
Description
-------
This is one of the important use-case in case of versioning.
User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
We should also lookahead at created actions that become invalid because of the new end time.
These actions should be deleted from DB.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java cd2c844
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 5ecd5d5
core/src/test/java/org/apache/oozie/command/bundle/TestBundleChangeXCommand.java 6560db6
core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java fdc0a55
docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2
Diff: https://reviews.apache.org/r/18257/diff/
Testing
-------
Thanks,
Purshotam Shah
Re: Review Request 18257: [OOZIE-1703] User should be able to set
bundle/coord end-time before start time
Posted by Rohini Palaniswamy <ro...@gmail.com>.
> On March 17, 2014, 9:47 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java, line 358
> > <https://reviews.apache.org/r/18257/diff/3/?file=500331#file500331line358>
> >
> > Why do we need this?
Looks like you have added this to handle the case where you want to delete actions which are after the new end time but if they are in WAITING state. But there is no check for waiting state. If there are actions materialized after new end time and they are in running state, error needs to be thrown. It needs to be fixed for pause as well.
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/#review37475
-----------------------------------------------------------
On Feb. 21, 2014, 10:26 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18257/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2014, 10:26 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1703
> https://issues.apache.org/jira/browse/OOZIE-1703
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> This is one of the important use-case in case of versioning.
>
> User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
>
>
> We should also lookahead at created actions that become invalid because of the new end time.
> These actions should be deleted from DB.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java cd2c844
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 4957330
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java b9bbf16
> docs/src/site/twiki/DG_CommandLineTool.twiki 0748ff8
>
> Diff: https://reviews.apache.org/r/18257/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 18257: [OOZIE-1703] User should be able to set
bundle/coord end-time before start time
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
> On March 17, 2014, 9:47 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java, line 102
> > <https://reviews.apache.org/r/18257/diff/3/?file=500330#file500330line102>
> >
> > The check is valid. Please revert this. If the bundle has not even started, user can always kill the bundle or suspend the bundle.
The purpose was to let user set end-date before start date.
from JIRA.
User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
> On March 17, 2014, 9:47 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java, line 236
> > <https://reviews.apache.org/r/18257/diff/3/?file=500331#file500331line236>
> >
> > Not required. lastActionNumber would be null and would not even come into this block
I added it for test cases, the condition is valid and it doesn't harm.
> On March 17, 2014, 9:47 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java, line 350
> > <https://reviews.apache.org/r/18257/diff/3/?file=500331#file500331line350>
> >
> > Why should we suspend? If the end time was changed again, the coord job will not automatically resume.
Status is changed to SUCCEEDED, user can again set a new end date, which will make coord to go in running state.
> On March 17, 2014, 9:47 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java, lines 171-175
> > <https://reviews.apache.org/r/18257/diff/3/?file=500330#file500330line171>
> >
> > This is not a valid use case. This block of code is not required. Please revert.
> >
> > Changing status of a bundle to suspend needs to be done through BundleSuspendXCommand as any coordinators started will have to be suspended.
Agree, we will move it to succeeded state.
- Purshotam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/#review37475
-----------------------------------------------------------
On March 31, 2014, 5:31 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18257/
> -----------------------------------------------------------
>
> (Updated March 31, 2014, 5:31 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1703
> https://issues.apache.org/jira/browse/OOZIE-1703
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> This is one of the important use-case in case of versioning.
>
> User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
>
>
> We should also lookahead at created actions that become invalid because of the new end time.
> These actions should be deleted from DB.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java cd2c844
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 5ecd5d5
> core/src/test/java/org/apache/oozie/command/bundle/TestBundleChangeXCommand.java 6560db6
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java fdc0a55
> docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2
>
> Diff: https://reviews.apache.org/r/18257/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 18257: [OOZIE-1703] User should be able to set
bundle/coord end-time before start time
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/#review37475
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment69004>
The check is valid. Please revert this. If the bundle has not even started, user can always kill the bundle or suspend the bundle.
core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment69005>
This is not a valid use case. This block of code is not required. Please revert.
Changing status of a bundle to suspend needs to be done through BundleSuspendXCommand as any coordinators started will have to be suspended.
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment69007>
Please put back up the condition checks. It removes the checks for even valid cases. What you need to do is to set end time before start time (or set it to be the same as start time which might be better) if no action has been materialized at all.
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment69008>
Not required. lastActionNumber would be null and would not even come into this block
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment69014>
Why should we suspend? If the end time was changed again, the coord job will not automatically resume.
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment69012>
Why do we need this?
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/18257/#comment69015>
Please put this back. But add a statement, that if end time is before job start time and if the job has not materialized any actions end time will be automatically corrected and set to the same as start time.
- Rohini Palaniswamy
On Feb. 21, 2014, 10:26 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18257/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2014, 10:26 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1703
> https://issues.apache.org/jira/browse/OOZIE-1703
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> This is one of the important use-case in case of versioning.
>
> User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
>
>
> We should also lookahead at created actions that become invalid because of the new end time.
> These actions should be deleted from DB.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java cd2c844
> core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 4957330
> core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java b9bbf16
> docs/src/site/twiki/DG_CommandLineTool.twiki 0748ff8
>
> Diff: https://reviews.apache.org/r/18257/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 18257: [OOZIE-1703] User should be able to set
bundle/coord end-time before start time
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/
-----------------------------------------------------------
(Updated Feb. 21, 2014, 10:26 p.m.)
Review request for oozie.
Bugs: OOZIE-1703
https://issues.apache.org/jira/browse/OOZIE-1703
Repository: oozie-git
Description
-------
This is one of the important use-case in case of versioning.
User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
We should also lookahead at created actions that become invalid because of the new end time.
These actions should be deleted from DB.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java cd2c844
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 4957330
core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java b9bbf16
docs/src/site/twiki/DG_CommandLineTool.twiki 0748ff8
Diff: https://reviews.apache.org/r/18257/diff/
Testing
-------
Thanks,
Purshotam Shah