You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by cenyuhai <gi...@git.apache.org> on 2016/11/03 18:04:29 UTC
[GitHub] incubator-carbondata pull request #293: [Carbondata-374] Support smallint ty...
GitHub user cenyuhai opened a pull request:
https://github.com/apache/incubator-carbondata/pull/293
[Carbondata-374] Support smallint type
What changes were proposed in this pull request?
support smallint type
How to test\uff1f
Test with TestCreateTable.scala
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cenyuhai/incubator-carbondata CARBONDATA-374
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/293.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #293
----
commit 90089ddbe4b17f2b74b9c1e4ca0a8c49c4754b6a
Author: cenyuhai <26...@qq.com>
Date: 2016-11-03T13:52:47Z
Change thrift files' name to a unified form
commit dcada1cccb474d694bd207a460c3426340c3187c
Author: cenyuhai <26...@qq.com>
Date: 2016-11-03T13:55:23Z
Merge remote-tracking branch 'remotes/cenyuhai/master'
commit 60ae86a3d51ae7b1988f43952e389d3d9cb9d39c
Author: cenyuhai <26...@qq.com>
Date: 2016-11-03T18:11:32Z
support smallint type
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #293: [CARBONDATA-374] Support smallint ty...
Posted by lion-x <gi...@git.apache.org>.
Github user lion-x commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/293#discussion_r86485669
--- Diff: integration/spark/src/test/scala/org/apache/spark/sql/TestCreateTable.scala ---
@@ -0,0 +1,30 @@
+/*
--- End diff --
pls move the contents into incubator-carbondata\integration\spark\src\test\scala\org\apache\carbondata\spark\testsuite\createtable\TestCreateTableSyntax.scala
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #293: [CARBONDATA-374] Support smallint ty...
Posted by cenyuhai <gi...@git.apache.org>.
Github user cenyuhai closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/293
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #293: [CARBONDATA-374] Support smallint ty...
Posted by lion-x <gi...@git.apache.org>.
Github user lion-x commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/293#discussion_r86702631
--- Diff: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestLoadDataWithHiveSyntax.scala ---
@@ -76,6 +77,35 @@ class TestLoadDataWithHiveSyntax extends QueryTest with BeforeAndAfterAll {
}
+ test("create table with smallint type and query smallint table")({
--- End diff --
Why you create a hive table instead of carbon table?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #293: [CARBONDATA-374] Support smallint ty...
Posted by cenyuhai <gi...@git.apache.org>.
Github user cenyuhai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/293#discussion_r86494087
--- Diff: integration/spark/src/test/scala/org/apache/spark/sql/TestCreateTable.scala ---
@@ -0,0 +1,30 @@
+/*
--- End diff --
ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #293: [CARBONDATA-374] Support smallint ty...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/293#discussion_r86498453
--- Diff: integration/spark/src/test/scala/org/apache/spark/sql/TestCreateTable.scala ---
@@ -0,0 +1,30 @@
+/*
--- End diff --
And also please include data load and sql query to retrieve data
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---