You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2013/05/14 06:28:05 UTC

Review Request: Changed Duration to use int64_t to store the value in nanoseconds for better precision. (libstout)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11139/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.


Description
-------

See summary. [Part 5 of Duration-Time Refactoring Chain]

- Duration::max() is are created to replace the usage of Seconds(DBL_MAX) to specify the upper bound; Duration::zero() is added to replace Seconds(0), Duration(0), etc.
- Duration still exposes double-typed APIs but will be changed to integral APIs in a later commit.


Diffs
-----

  third_party/libprocess/third_party/stout/include/stout/duration.hpp c943ab196871cf4c55f2a2dce5ef85ffe3a22577 
  third_party/libprocess/third_party/stout/tests/duration_tests.cpp 421615aa510f540ccfc0413d3252bbdedd70f7da 

Diff: https://reviews.apache.org/r/11139/diff/


Testing
-------

make check


Thanks,

Jiang Yan Xu


Re: Review Request: Changed Duration to use int64_t to store the value in nanoseconds for better precision. (libstout)

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11139/
-----------------------------------------------------------

(Updated May 16, 2013, 7:55 a.m.)


Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.


Description
-------

See summary. [Part 5 of Duration-Time Refactoring Chain]

- Duration::max() is are created to replace the usage of Seconds(DBL_MAX) to specify the upper bound; Duration::zero() is added to replace Seconds(0), Duration(0), etc.
- Duration still exposes double-typed APIs but will be changed to integral APIs in a later commit.


Diffs (updated)
-----

  third_party/libprocess/third_party/stout/include/stout/duration.hpp c943ab196871cf4c55f2a2dce5ef85ffe3a22577 
  third_party/libprocess/third_party/stout/tests/duration_tests.cpp 421615aa510f540ccfc0413d3252bbdedd70f7da 

Diff: https://reviews.apache.org/r/11139/diff/


Testing
-------

make check


Thanks,

Jiang Yan Xu