You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/12 21:49:54 UTC

[GitHub] [beam] iemejia opened a new pull request #11113: [BEAM-9285] Add Postcommit ValidatesRunner CI Job for Flink on Java 11

iemejia opened a new pull request #11113: [BEAM-9285] Add Postcommit ValidatesRunner CI Job for Flink on Java 11
URL: https://github.com/apache/beam/pull/11113
 
 
   The failing tests are due to some issues with bytebuddy code generation tracked on
   https://issues.apache.org/jira/browse/BEAM-9370 
   
   R: @mwalenia 
   CC: @mxm @sunjincheng121 (for awareness) 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] iemejia commented on issue #11113: [BEAM-9285] Add Postcommit ValidatesRunner CI Job for Flink on Java 11

Posted by GitBox <gi...@apache.org>.
iemejia commented on issue #11113: [BEAM-9285] Add Postcommit ValidatesRunner CI Job for Flink on Java 11
URL: https://github.com/apache/beam/pull/11113#issuecomment-598433474
 
 
   Run Seed Job

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] iemejia commented on issue #11113: [BEAM-9285] Add Postcommit ValidatesRunner CI Job for Flink on Java 11

Posted by GitBox <gi...@apache.org>.
iemejia commented on issue #11113: [BEAM-9285] Add Postcommit ValidatesRunner CI Job for Flink on Java 11
URL: https://github.com/apache/beam/pull/11113#issuecomment-598698865
 
 
   Sure no problem, but from a quick look at the PR this looks to be only for precommits or will it work easily for postcommits too? @mwalenia ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] iemejia edited a comment on issue #11113: [BEAM-9285] Add Postcommit ValidatesRunner CI Job for Flink on Java 11

Posted by GitBox <gi...@apache.org>.
iemejia edited a comment on issue #11113: [BEAM-9285] Add Postcommit ValidatesRunner CI Job for Flink on Java 11
URL: https://github.com/apache/beam/pull/11113#issuecomment-598698865
 
 
   Sure no problem, but from a quick look at  #11076 looks to be only for precommits or will it work easily for postcommits too? @mwalenia ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] iemejia commented on issue #11113: [BEAM-9285] Add Postcommit ValidatesRunner CI Job for Flink on Java 11

Posted by GitBox <gi...@apache.org>.
iemejia commented on issue #11113: [BEAM-9285] Add Postcommit ValidatesRunner CI Job for Flink on Java 11
URL: https://github.com/apache/beam/pull/11113#issuecomment-598453655
 
 
   Run Flink ValidatesRunner Java 11

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] mwalenia commented on issue #11113: [BEAM-9285] Add Postcommit ValidatesRunner CI Job for Flink on Java 11

Posted by GitBox <gi...@apache.org>.
mwalenia commented on issue #11113: [BEAM-9285] Add Postcommit ValidatesRunner CI Job for Flink on Java 11
URL: https://github.com/apache/beam/pull/11113#issuecomment-598586677
 
 
   Take a look at https://github.com/apache/beam/pull/11076
   Pawel found a better, more maintainable way of making sure tests are compiled and ran with proper versions of Java. Can we wait until his PR is merged and migrate your PR to that solution as well?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] iemejia commented on issue #11113: [BEAM-9285] Add Postcommit ValidatesRunner CI Job for Flink on Java 11

Posted by GitBox <gi...@apache.org>.
iemejia commented on issue #11113: [BEAM-9285] Add Postcommit ValidatesRunner CI Job for Flink on Java 11
URL: https://github.com/apache/beam/pull/11113#issuecomment-615866391
 
 
   Any news on this @pawelpasterz ? Otherwise I think we should just merge this one and get it refactored afterwards once the new approach is ready, WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] pawelpasterz commented on issue #11113: [BEAM-9285] Add Postcommit ValidatesRunner CI Job for Flink on Java 11

Posted by GitBox <gi...@apache.org>.
pawelpasterz commented on issue #11113: [BEAM-9285] Add Postcommit ValidatesRunner CI Job for Flink on Java 11
URL: https://github.com/apache/beam/pull/11113#issuecomment-599371662
 
 
   @iemejia Let me answer, once this small part of gradle script is merged it should be easy to add more jobs/tests. It might happen it would require small refactor.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services