You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by lu...@apache.org on 2015/11/03 12:06:49 UTC
[4/6] [math] Avoid a false positive findbugs warning.
Avoid a false positive findbugs warning.
Findbugs is confused by constant 1.570796251296997 which is a
intentionally slightly offset from PI/2 as per Cody Waite arguments
reduction.
Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/b72d4467
Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/b72d4467
Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/b72d4467
Branch: refs/heads/MATH_3_X
Commit: b72d44673c8b47ae771c2fa901a31bc2d21614d1
Parents: fae8d86
Author: Luc Maisonobe <lu...@apache.org>
Authored: Tue Nov 3 11:20:30 2015 +0100
Committer: Luc Maisonobe <lu...@apache.org>
Committed: Tue Nov 3 11:20:47 2015 +0100
----------------------------------------------------------------------
findbugs-exclude-filter.xml | 8 ++++++++
1 file changed, 8 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-math/blob/b72d4467/findbugs-exclude-filter.xml
----------------------------------------------------------------------
diff --git a/findbugs-exclude-filter.xml b/findbugs-exclude-filter.xml
index 0216613..5a960ca 100644
--- a/findbugs-exclude-filter.xml
+++ b/findbugs-exclude-filter.xml
@@ -170,6 +170,14 @@
<Bug pattern="CNT_ROUGH_CONSTANT_VALUE" />
</Match>
+ <!-- Spurious: Findbugs confused by constant 1.570796251296997 which is a
+ intentionally slightly offset from PI/2 as per Cody Waite arguments reduction -->
+ <Match>
+ <Class name="org.apache.commons.math3.util.FastMath$CodyWaite" />
+ <Method name="<init>" params="double" returns="void" />
+ <Bug pattern="CNT_ROUGH_CONSTANT_VALUE" />
+ </Match>
+
<!-- the following expositions of internal representation are intentional and documented -->
<Match>
<Class name="org.apache.commons.math3.stat.regression.RegressionResults"/>