You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/02/17 14:01:51 UTC
[GitHub] [netbeans] sdedic opened a new pull request #2767: Broken project auto-resolution repeats actions
sdedic opened a new pull request #2767:
URL: https://github.com/apache/netbeans/pull/2767
During LSP testing with gradle, I've found out that if problem resolution fails, the action may be repeated again. Along the way, I've also noticed that the LSP `DialogDisplayer` implementation does not stip `&` that mark mnemonic characters in String options (choices) - LSP protocol does not support such pattern (yet).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2767: Broken project auto-resolution repeats actions
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2767:
URL: https://github.com/apache/netbeans/pull/2767#discussion_r578641078
##########
File path: java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/ui/NotifyDescriptorAdapter.java
##########
@@ -222,6 +222,11 @@ private void mapDescriptorOptions() {
text = mapDescriptorOption(o);
}
if (text != null) {
+ // Discard ampersands, LSP spec does not support such pattern.
+ int mn = Mnemonics.findMnemonicAmpersand(text);
Review comment:
There is [cutAmpersand](https://bits.netbeans.org/12.0/javadoc/org-openide-awt/org/openide/awt/Actions.html#cutAmpersand-java.lang.String-) method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #2767: Broken project auto-resolution repeats actions
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #2767:
URL: https://github.com/apache/netbeans/pull/2767#issuecomment-783200685
Squashed the review commit(s)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic merged pull request #2767: Broken project auto-resolution repeats actions
Posted by GitBox <gi...@apache.org>.
sdedic merged pull request #2767:
URL: https://github.com/apache/netbeans/pull/2767
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2767: Broken project auto-resolution repeats actions
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2767:
URL: https://github.com/apache/netbeans/pull/2767#discussion_r579206765
##########
File path: java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/ui/NotifyDescriptorAdapter.java
##########
@@ -222,6 +222,11 @@ private void mapDescriptorOptions() {
text = mapDescriptorOption(o);
}
if (text != null) {
+ // Discard ampersands, LSP spec does not support such pattern.
+ int mn = Mnemonics.findMnemonicAmpersand(text);
Review comment:
`cutAmpersand` is better (handles japanese locale). Thanks ! Fixed in 17ddace
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists