[jira] [Commented] (FELIX-4602) TemporalServiceDependency does not properly propagate RuntimeExceptions

["Pierre De Rop (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089007#comment-14089007 ] 

Pierre De Rop commented on FELIX-4602:
--------------------------------------

Thanks Sean for the proposed patch.

As explained in FELIX-4598, we have made a big revamp of dependency manager, which is now using a new (almost) lock-free thread model. 

This new DM 4.0.0 version is unfortunately not yet committed in felix-trunk, but in the felix sandbox: [1] , and the code has changed a lot from DM 3.2.0; it's a big refactoring, so I would to avoid fixing anything in DM 3.2.0 because we first have to bring this new DM 4.0.0 version from the sandbox into the felix-trunk, then at this point I will will apply your patch (thanks again !).

(I'm currently off and will get back from vacations around 20 august).
/pierre

[1] http://svn.apache.org/viewvc/felix/sandbox/pderop/dependencymanager-prototype/





> TemporalServiceDependency does not properly propagate RuntimeExceptions
> -----------------------------------------------------------------------
>
>                 Key: FELIX-4602
>                 URL: https://issues.apache.org/jira/browse/FELIX-4602
>             Project: Felix
>          Issue Type: Bug
>          Components: Dependency Manager
>    Affects Versions: dependencymanager-3.2.0
>            Reporter: Sean Rohead
>            Assignee: Pierre De Rop
>              Labels: easyfix
>             Fix For: dependencymanager-4.0.0
>
>         Attachments: TemporalServiceDependencyImpl.java.patch
>
>
> I have a service that throws subclasses of RuntimeException from some of it's methods. When wrapped in a TemporalServiceDependency, these calls throw UndeclaredThrowableException instead.
> The fix is quite simple:
> Wrap TemporalServiceDependencyImpl lines 182-188 in the following try/catch block:
> try {
>     ...
> }
> catch (InvocationTargetException e) {
>     throw e.getTargetException();
> }



--
This message was sent by Atlassian JIRA
(v6.2#6252)