You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/18 13:25:18 UTC

[GitHub] [flink] lincoln-lil commented on a diff in pull request #20243: [FLINK-28491][table-planner] Introduce APPROX_COUNT_DISTINCT aggregate function for batch sql

lincoln-lil commented on code in PR #20243:
URL: https://github.com/apache/flink/pull/20243#discussion_r923368739


##########
tools/maven/suppressions.xml:
##########
@@ -45,6 +45,9 @@ under the License.
 		<!-- Temporarily fix TM Metaspace memory leak caused by Apache Beam sdk harness. -->
 		<suppress files="org[\\/]apache[\\/]beam.*.java" checks="[a-zA-Z0-9]*"/>
 
+		<!-- Have to use guava directly -->

Review Comment:
   nit: the comment seems incorrect, and move it to line 39 maybe better



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org