You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2014/11/10 20:29:07 UTC
Re: Review Request 27351: Libprocess: Introduce
enable_shared_from_this configure check
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27351/#review60646
-----------------------------------------------------------
Ship it!
LGTM - have one question (inlined)
3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4
<https://reviews.apache.org/r/27351/#comment102015>
Comments end with period
3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4
<https://reviews.apache.org/r/27351/#comment102016>
This tests that is compiles but not whether it works as expected wrt ownership. Maybe that's ok?
- Niklas Nielsen
On Oct. 29, 2014, 3:23 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27351/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2014, 3:23 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
>
>
> Bugs: MESOS-2010
> https://issues.apache.org/jira/browse/MESOS-2010
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Introduce enable_shared_from_this to the configure check for Libprocess
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19
>
> Diff: https://reviews.apache.org/r/27351/diff/
>
>
> Testing
> -------
>
> make check on gcc-4.4
> make check on gcc-4.9
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 27351: Libprocess: Introduce
enable_shared_from_this configure check
Posted by Dominic Hamon <dh...@twopensource.com>.
> On Nov. 10, 2014, 11:29 a.m., Niklas Nielsen wrote:
> > 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4, line 84
> > <https://reviews.apache.org/r/27351/diff/2/?file=742017#file742017line84>
> >
> > This tests that is compiles but not whether it works as expected wrt ownership. Maybe that's ok?
that's all we're testing right now. More involved runtime tests may have to wait until we have cmake (:P)
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27351/#review60646
-----------------------------------------------------------
On Nov. 12, 2014, 11:18 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27351/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 11:18 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
>
>
> Bugs: MESOS-2010
> https://issues.apache.org/jira/browse/MESOS-2010
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Introduce enable_shared_from_this to the configure check for Libprocess
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19
>
> Diff: https://reviews.apache.org/r/27351/diff/
>
>
> Testing
> -------
>
> make check on gcc-4.4
> make check on gcc-4.9
>
>
> Thanks,
>
> Joris Van Remoortere
>
>