[jira] [Commented] (SLING-2441) AuthenticationInfo.put() throws if method is null

["Felix Meschberger (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290125#comment-13290125 ] 

Felix Meschberger commented on SLING-2441:
------------------------------------------

> But do you agree that if we make this change, the exported package version has to change? 

Yes, but on second thought, I think I am also opposing the change per se.

While it is probably (internally to the Sling Auth Core bundle ??) ok to create an AuthenticationInfo with null AUTH_TYPE, I would think that setting a null AUTH_TYPE with put is wrong (in fact, probably put should be disallowed completely for the AUTH_TYPE property).

So, I think we should really revert this complete change.
                
> AuthenticationInfo.put() throws if method is null
> -------------------------------------------------
>
>                 Key: SLING-2441
>                 URL: https://issues.apache.org/jira/browse/SLING-2441
>             Project: Sling
>          Issue Type: Bug
>          Components: Authentication
>    Affects Versions: Auth Core 1.0.6
>            Reporter: Jeff Young
>            Assignee: Justin Edelson
>              Labels: newbie, patch
>             Fix For: Auth Core 1.1.0
>
>         Attachments: auth_info_put.patch
>
>
> Historically the AUTH_TYPE of an AuthenitcationInfo had to be defined (ie: non-null), but we're now using it for anonymous access as well, with a null AUTH_TYPE.  The put() method, however, throws if passed a null AUTH_TYPE.  
> (This is triggered, for instance, by CQ's AuthenticationInfoPostProcessorBridge, which does a putAll().)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira