[GitHub] [lucene-solr] noblepaul commented on a change in pull request #665: Fixes SOLR-11841, SOLR-13331, SOLR-13347

[GitBox <gi...@apache.org>]

noblepaul commented on a change in pull request #665: Fixes SOLR-11841, SOLR-13331, SOLR-13347
URL: https://github.com/apache/lucene-solr/pull/665#discussion_r286756552
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/handler/loader/XMLLoader.java
 ##########
 @@ -178,13 +183,12 @@ public void load(SolrQueryRequest req, SolrQueryResponse rsp, ContentStream stre
           final byte[] body = IOUtils.toByteArray(is);
           // TODO: The charset may be wrong, as the real charset is later
           // determined by the XML parser, the content-type is only used as a hint!
-          log.trace("body", new String(body, (charset == null) ?
-            ContentStreamBase.DEFAULT_CHARSET : charset));
+          log.trace("body", new String(body, (charset == null) ? ContentStreamBase.DEFAULT_CHARSET : charset));
           IOUtils.closeQuietly(is);
           is = new ByteArrayInputStream(body);
         }
-        parser = (charset == null) ?
-          inputFactory.createXMLStreamReader(is) : inputFactory.createXMLStreamReader(is, charset);
+        parser = (charset == null) ? inputFactory.createXMLStreamReader(is)
 
 Review comment:
   It is very hard to know if this is a real change or a formatting change , looking at the diff. Is it possible to get rid of the irrelevant changes? I'm all for formatting changes as a separate PR

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org