[jira] [Updated] (ROCKETMQ-234) Bugfix in batch scenario

["Yu Kaiyuan (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ROCKETMQ-234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yu Kaiyuan updated ROCKETMQ-234:
--------------------------------
    Description: 
Bug in handle batch response. Broker will write response twice to client in batch scenario.
Details below:

{code:java}
// Some comments here
private RemotingCommand sendBatchMessage(...)
{
    // ignore irrelevant logic...
    // here in handlePutMessageResult function, reponse will be written back through ctx once
    handlePutMessageResult(putMessageResult, response, request, messageExtBatch, responseHeader, sendMessageContext, ctx, queueIdInt);
    // the response returned here will be written back again if response is not null 
    return response;
}
{code}


  was:
Bug in handle batch response. Broker will write response twice to client in batch scenario.
Details below:

{code:java}
// Some comments here
private RemotingCommand sendBatchMessage(...)
{
    // ignore irrelevant logic...
    // here in handlePutMessageResult function, reponse will write back through ctx once
    handlePutMessageResult(putMessageResult, response, request, messageExtBatch, responseHeader, sendMessageContext, ctx, queueIdInt);
    // the response returned here will be write back again if response is not null 
    return response;
}
{code}



> Bugfix in batch scenario
> ------------------------
>
>                 Key: ROCKETMQ-234
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-234
>             Project: Apache RocketMQ
>          Issue Type: Bug
>          Components: rocketmq-broker
>    Affects Versions: 4.1.0-incubating, 4.2.0-incubating
>            Reporter: Yu Kaiyuan
>            Assignee: yukon
>
> Bug in handle batch response. Broker will write response twice to client in batch scenario.
> Details below:
> {code:java}
> // Some comments here
> private RemotingCommand sendBatchMessage(...)
> {
>     // ignore irrelevant logic...
>     // here in handlePutMessageResult function, reponse will be written back through ctx once
>     handlePutMessageResult(putMessageResult, response, request, messageExtBatch, responseHeader, sendMessageContext, ctx, queueIdInt);
>     // the response returned here will be written back again if response is not null 
>     return response;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)