You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "danny0405 (via GitHub)" <gi...@apache.org> on 2023/08/10 03:22:05 UTC
[GitHub] [hudi] danny0405 commented on a diff in pull request #9408: [HUDI-6671] Support 'alter table add partition' sql
danny0405 commented on code in PR #9408:
URL: https://github.com/apache/hudi/pull/9408#discussion_r1289497305
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/HoodieSqlCommonUtils.scala:
##########
@@ -330,23 +330,36 @@ object HoodieSqlCommonUtils extends SparkAdapterSupport {
val allPartitionPaths = hoodieCatalogTable.getPartitionPaths
val enableHiveStylePartitioning = isHiveStyledPartitioning(allPartitionPaths, table)
val enableEncodeUrl = isUrlEncodeEnabled(allPartitionPaths, table)
- val partitionsToDrop = normalizedSpecs.map { spec =>
- hoodieCatalogTable.partitionFields.map { partitionColumn =>
- val encodedPartitionValue = if (enableEncodeUrl) {
- PartitionPathEncodeUtils.escapePathName(spec(partitionColumn))
- } else {
- spec(partitionColumn)
- }
- if (enableHiveStylePartitioning) {
- partitionColumn + "=" + encodedPartitionValue
- } else {
Review Comment:
Why removing the handling of hive style partitioning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org