You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by kk...@apache.org on 2019/02/26 16:47:57 UTC

[flink] branch release-1.6 updated: [FLINK-11185] Fix StreamSourceOperatorWatermarksTest instability.

This is an automated email from the ASF dual-hosted git repository.

kkloudas pushed a commit to branch release-1.6
in repository https://gitbox.apache.org/repos/asf/flink.git


The following commit(s) were added to refs/heads/release-1.6 by this push:
     new c233ead  [FLINK-11185] Fix StreamSourceOperatorWatermarksTest instability.
c233ead is described below

commit c233ead2896da15e8e3fb1a16fd42fc9f1987757
Author: Kostas Kloudas <kk...@gmail.com>
AuthorDate: Tue Feb 26 16:53:14 2019 +0100

    [FLINK-11185] Fix StreamSourceOperatorWatermarksTest instability.
    
    The cause of the instability seems to be that due to a not-so-rare timing,
    the thread that calls the `interrupt()` on the main thread, runs still
    after its original test finishes and calls `interrupt()` during execution
    of the next test. This causes the normal execution (or `sleep()` in this case)
    to be interrupted.
---
 .../streaming/runtime/operators/StreamSourceOperatorWatermarksTest.java | 2 --
 1 file changed, 2 deletions(-)

diff --git a/flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/StreamSourceOperatorWatermarksTest.java b/flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/StreamSourceOperatorWatermarksTest.java
index 4b5259e..00c3ac4 100644
--- a/flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/StreamSourceOperatorWatermarksTest.java
+++ b/flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/StreamSourceOperatorWatermarksTest.java
@@ -101,7 +101,6 @@ public class StreamSourceOperatorWatermarksTest {
 	public void testNoMaxWatermarkOnAsyncCancel() throws Exception {
 
 		final List<StreamElement> output = new ArrayList<>();
-		final Thread runner = Thread.currentThread();
 
 		// regular stream source operator
 		final StreamSource<String, InfiniteSource<String>> operator =
@@ -117,7 +116,6 @@ public class StreamSourceOperatorWatermarksTest {
 					Thread.sleep(200);
 				} catch (InterruptedException ignored) {}
 				operator.cancel();
-				runner.interrupt();
 			}
 		}.start();