You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "izveigor (via GitHub)" <gi...@apache.org> on 2023/02/24 12:30:28 UTC
[GitHub] [arrow-datafusion] izveigor opened a new pull request, #5388: Minor: intersect expressions optimization
izveigor opened a new pull request, #5388:
URL: https://github.com/apache/arrow-datafusion/pull/5388
Optimization of the function "intersect".
During the execution of the function "extract_possible_join_keys", if the operator of an expression equals OR, then the algorithm goes recursively in depth of the tree and joins keys in the array "accum". As bottom nodes are majority and they may not have right and left descendants, then the join does not happen. However, "intersect" in any cases iterates over all left join keys, which is costly.
This minor patch fixed the problem.
# Are these changes tested?
No new tests added
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] avantgardnerio merged pull request #5388: Minor: intersect expressions optimization
Posted by "avantgardnerio (via GitHub)" <gi...@apache.org>.
avantgardnerio merged PR #5388:
URL: https://github.com/apache/arrow-datafusion/pull/5388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5388: Minor: intersect expressions optimization
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5388:
URL: https://github.com/apache/arrow-datafusion/pull/5388#issuecomment-1444431954
Benchmark runs are scheduled for baseline = d64076b46dec633011541382aa90e5bdddca6184 and contender = 722490121cdae8551faf07aeec53dd58655cde1c. 722490121cdae8551faf07aeec53dd58655cde1c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5d49779ee1c9464c9fe57bb2c2b2d552...0fd7be0462a343eea1cb60a459823d9a/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/744577343392443d958aac5e50badc5b...0fc3d6ded38c4988bd7f5c3f0f36cea8/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/57dce132f2944ed39a3a0ba3bc89c988...728f35ef703d4adea1108512ef32da88/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/402b8fadb65f473c9439fc5e98569ec2...9cb73593b03844979443fa52faf4ee17/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org