You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uima.apache.org by bu...@apache.org on 2012/06/20 21:27:25 UTC

svn commit: r1352272 - in /uima/uimaj/trunk/uimaj-core/src/test: java/org/apache/uima/analysis_engine/impl/AnalysisEngine_implTest.java resources/TextAnalysisEngineImplTest/AggregateWithManyDelegates.xml

Author: burn
Date: Wed Jun 20 19:27:24 2012
New Revision: 1352272

URL: http://svn.apache.org/viewvc?rev=1352272&view=rev
Log:
[UIMA-2408] Remove 2 empty elements from the test and relax the comparison since the Jenkins build produces different XML.

Modified:
    uima/uimaj/trunk/uimaj-core/src/test/java/org/apache/uima/analysis_engine/impl/AnalysisEngine_implTest.java
    uima/uimaj/trunk/uimaj-core/src/test/resources/TextAnalysisEngineImplTest/AggregateWithManyDelegates.xml

Modified: uima/uimaj/trunk/uimaj-core/src/test/java/org/apache/uima/analysis_engine/impl/AnalysisEngine_implTest.java
URL: http://svn.apache.org/viewvc/uima/uimaj/trunk/uimaj-core/src/test/java/org/apache/uima/analysis_engine/impl/AnalysisEngine_implTest.java?rev=1352272&r1=1352271&r2=1352272&view=diff
==============================================================================
--- uima/uimaj/trunk/uimaj-core/src/test/java/org/apache/uima/analysis_engine/impl/AnalysisEngine_implTest.java (original)
+++ uima/uimaj/trunk/uimaj-core/src/test/java/org/apache/uima/analysis_engine/impl/AnalysisEngine_implTest.java Wed Jun 20 19:27:24 2012
@@ -1514,7 +1514,9 @@ public class AnalysisEngine_implTest ext
     desc.toXML(contentHandler, true);
     contentHandler.endDocument();
     os.close();
-    assertEquals(inFile.length(), cloneFile.length());
+    long diff = cloneFile.length() - inFile.length();
+    // One platform inserts a blank line after the first, so don't insist on perfection
+    assertTrue("File size changed by "+diff+" should be no more than 1", diff >= -1 && diff <= 1);
 
     // Initialize all delegates and check the initialization order (should be declaration order)
     TestAnnotator2.allContexts = "";

Modified: uima/uimaj/trunk/uimaj-core/src/test/resources/TextAnalysisEngineImplTest/AggregateWithManyDelegates.xml
URL: http://svn.apache.org/viewvc/uima/uimaj/trunk/uimaj-core/src/test/resources/TextAnalysisEngineImplTest/AggregateWithManyDelegates.xml?rev=1352272&r1=1352271&r2=1352272&view=diff
==============================================================================
--- uima/uimaj/trunk/uimaj-core/src/test/resources/TextAnalysisEngineImplTest/AggregateWithManyDelegates.xml (original)
+++ uima/uimaj/trunk/uimaj-core/src/test/resources/TextAnalysisEngineImplTest/AggregateWithManyDelegates.xml Wed Jun 20 19:27:24 2012
@@ -52,9 +52,7 @@
   <!-- serialize back to disk  -->
   <analysisEngineMetaData>
     <name>AggregateWithManyDelegates</name>
-    <description/>
     <version>1.0</version>
-    <vendor/>
     <configurationParameters searchStrategy="language_fallback">
       <configurationParameter>              <!-- First parameter -->
         <name>StringParam</name>