You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2013/10/09 13:28:24 UTC

Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14058/
-----------------------------------------------------------

(Updated Oct. 9, 2013, 11:28 a.m.)


Review request for cloudstack, Girish Shilamkar, venkata swamy babu  budumuru, and Sheng Yang.


Changes
-------

Added host tags to hosts through test cases. No need to manually tag the hosts.
Also, changed the "tags" in service offering to "hosttags", now it is interpreted as host tag and not storage tag.

Ran all test cases locally with a 3 host KVM advanced setup.

All new test cases running successfully (please see log in the "Testing Done" section.


Repository: cloudstack-git


Description
-------

Added 10 tests for VPC VM liftcycle on tagged hosts

New class added  : TestVMLifeCycleDiffHosts

    def test_01_deploy_instance_in_network(self):
    def test_02_stop_instance_in_network(self):
    def test_03_start_instance_in_network(self):
    def test_04_reboot_instance_in_network(self):
    def test_05_destroy_instance_in_network(self):
    def test_06_recover_instance_in_network(self):
    def test_07_migrate_instance_in_network(self):
    def test_08_user_data(self):
    def test_09_meta_data(self):
    def	test_10_expunge_instance_in_network(self):

This set of tests requires a multi host tagged setup (3 hosts - 2 hosts with tag 'host1' and  1 host with tag 'host2')


Diffs (updated)
-----

  test/integration/component/test_vpc_vm_life_cycle.py 9844c1f 

Diff: https://reviews.apache.org/r/14058/diff/


Testing (updated)
-------

Tested locally on KVM advanced setup.

Log:

test_01_deploy_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test deploy an instance in VPC networks ... ok
test_02_stop_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test stop an instance in VPC networks ... ok
test_03_start_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test start an instance in VPC networks ... ok
test_04_reboot_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test reboot an instance in VPC networks ... ok
test_05_destroy_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test destroy an instance in VPC networks ... ok
test_06_migrate_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test migrate an instance in VPC networks ... ok
test_07_user_data (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test user data in virtual machines ... ok
test_08_meta_data (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test meta data in virtual machines ... ok
test_09_expunge_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test expunge an instance in VPC networks ... ok


Thanks,

Ashutosh Kelkar


Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

Posted by Ashutosh Kelkar <as...@clogeny.com>.

> On Oct. 16, 2013, 1:53 p.m., suresh sadhu wrote:
> >  reviewed the code and added host tags  in the code as per the review comments but when we ran the TestVMLifeCycleDiffHosts tests,it failed with Host.Update method is undefined in our environment.can you please rerun and confirm once.
> > 
> >

Hi Suresh,

Looks like the new method got missed in the patch. I am updating the patch with it.


- Ashutosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14058/#review27064
-----------------------------------------------------------


On Oct. 9, 2013, 11:28 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14058/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2013, 11:28 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, venkata swamy babu  budumuru, and Sheng Yang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added 10 tests for VPC VM liftcycle on tagged hosts
> 
> New class added  : TestVMLifeCycleDiffHosts
> 
>     def test_01_deploy_instance_in_network(self):
>     def test_02_stop_instance_in_network(self):
>     def test_03_start_instance_in_network(self):
>     def test_04_reboot_instance_in_network(self):
>     def test_05_destroy_instance_in_network(self):
>     def test_06_recover_instance_in_network(self):
>     def test_07_migrate_instance_in_network(self):
>     def test_08_user_data(self):
>     def test_09_meta_data(self):
>     def	test_10_expunge_instance_in_network(self):
> 
> This set of tests requires a multi host tagged setup (3 hosts - 2 hosts with tag 'host1' and  1 host with tag 'host2')
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_vpc_vm_life_cycle.py 9844c1f 
> 
> Diff: https://reviews.apache.org/r/14058/diff/
> 
> 
> Testing
> -------
> 
> Tested locally on KVM advanced setup.
> 
> Log:
> 
> test_01_deploy_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test deploy an instance in VPC networks ... ok
> test_02_stop_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test stop an instance in VPC networks ... ok
> test_03_start_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test start an instance in VPC networks ... ok
> test_04_reboot_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test reboot an instance in VPC networks ... ok
> test_05_destroy_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test destroy an instance in VPC networks ... ok
> test_06_migrate_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test migrate an instance in VPC networks ... ok
> test_07_user_data (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test user data in virtual machines ... ok
> test_08_meta_data (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test meta data in virtual machines ... ok
> test_09_expunge_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test expunge an instance in VPC networks ... ok
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

Posted by suresh sadhu <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14058/#review27064
-----------------------------------------------------------


 reviewed the code and added host tags  in the code as per the review comments but when we ran the TestVMLifeCycleDiffHosts tests,it failed with Host.Update method is undefined in our environment.can you please rerun and confirm once.



- suresh sadhu


On Oct. 9, 2013, 11:28 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14058/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2013, 11:28 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, venkata swamy babu  budumuru, and Sheng Yang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added 10 tests for VPC VM liftcycle on tagged hosts
> 
> New class added  : TestVMLifeCycleDiffHosts
> 
>     def test_01_deploy_instance_in_network(self):
>     def test_02_stop_instance_in_network(self):
>     def test_03_start_instance_in_network(self):
>     def test_04_reboot_instance_in_network(self):
>     def test_05_destroy_instance_in_network(self):
>     def test_06_recover_instance_in_network(self):
>     def test_07_migrate_instance_in_network(self):
>     def test_08_user_data(self):
>     def test_09_meta_data(self):
>     def	test_10_expunge_instance_in_network(self):
> 
> This set of tests requires a multi host tagged setup (3 hosts - 2 hosts with tag 'host1' and  1 host with tag 'host2')
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_vpc_vm_life_cycle.py 9844c1f 
> 
> Diff: https://reviews.apache.org/r/14058/diff/
> 
> 
> Testing
> -------
> 
> Tested locally on KVM advanced setup.
> 
> Log:
> 
> test_01_deploy_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test deploy an instance in VPC networks ... ok
> test_02_stop_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test stop an instance in VPC networks ... ok
> test_03_start_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test start an instance in VPC networks ... ok
> test_04_reboot_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test reboot an instance in VPC networks ... ok
> test_05_destroy_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test destroy an instance in VPC networks ... ok
> test_06_migrate_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test migrate an instance in VPC networks ... ok
> test_07_user_data (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test user data in virtual machines ... ok
> test_08_meta_data (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test meta data in virtual machines ... ok
> test_09_expunge_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test expunge an instance in VPC networks ... ok
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14058/#review27758
-----------------------------------------------------------


patch failed to apply on 4.2 

 git apply vmvpc.patch 
error: patch failed: test/integration/component/test_vpc_vm_life_cycle.py:182
error: test/integration/component/test_vpc_vm_life_cycle.py: patch does not apply


- SrikanteswaraRao Talluri


On Oct. 16, 2013, 2:09 p.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14058/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2013, 2:09 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, venkata swamy babu  budumuru, and Sheng Yang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added 10 tests for VPC VM liftcycle on tagged hosts
> 
> New class added  : TestVMLifeCycleDiffHosts
> 
>     def test_01_deploy_instance_in_network(self):
>     def test_02_stop_instance_in_network(self):
>     def test_03_start_instance_in_network(self):
>     def test_04_reboot_instance_in_network(self):
>     def test_05_destroy_instance_in_network(self):
>     def test_06_recover_instance_in_network(self):
>     def test_07_migrate_instance_in_network(self):
>     def test_08_user_data(self):
>     def test_09_meta_data(self):
>     def	test_10_expunge_instance_in_network(self):
> 
> This set of tests requires a multi host tagged setup (3 hosts - 2 hosts with tag 'host1' and  1 host with tag 'host2')
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_vpc_vm_life_cycle.py 9844c1f 
>   tools/marvin/marvin/integration/lib/base.py 0d52224 
> 
> Diff: https://reviews.apache.org/r/14058/diff/
> 
> 
> Testing
> -------
> 
> Tested locally on KVM advanced setup.
> 
> Log:
> 
> test_01_deploy_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test deploy an instance in VPC networks ... ok
> test_02_stop_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test stop an instance in VPC networks ... ok
> test_03_start_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test start an instance in VPC networks ... ok
> test_04_reboot_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test reboot an instance in VPC networks ... ok
> test_05_destroy_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test destroy an instance in VPC networks ... ok
> test_06_migrate_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test migrate an instance in VPC networks ... ok
> test_07_user_data (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test user data in virtual machines ... ok
> test_08_meta_data (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test meta data in virtual machines ... ok
> test_09_expunge_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test expunge an instance in VPC networks ... ok
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14058/#review28811
-----------------------------------------------------------


Committed to 4.2, 4.3 and master.

- Girish Shilamkar


On Nov. 8, 2013, 1:48 p.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14058/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2013, 1:48 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, venkata swamy babu  budumuru, and Sheng Yang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added 10 tests for VPC VM liftcycle on tagged hosts
> 
> New class added  : TestVMLifeCycleDiffHosts
> 
>     def test_01_deploy_instance_in_network(self):
>     def test_02_stop_instance_in_network(self):
>     def test_03_start_instance_in_network(self):
>     def test_04_reboot_instance_in_network(self):
>     def test_05_destroy_instance_in_network(self):
>     def test_06_recover_instance_in_network(self):
>     def test_07_migrate_instance_in_network(self):
>     def test_08_user_data(self):
>     def test_09_meta_data(self):
>     def	test_10_expunge_instance_in_network(self):
> 
> This set of tests requires a multi host tagged setup (3 hosts - 2 hosts with tag 'host1' and  1 host with tag 'host2')
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_vpc_vm_life_cycle.py cc65eed 
>   tools/marvin/marvin/integration/lib/base.py 10c636c 
> 
> Diff: https://reviews.apache.org/r/14058/diff/
> 
> 
> Testing
> -------
> 
> Tested locally on KVM advanced setup.
> 
> Log:
> 
> test_01_deploy_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test deploy an instance in VPC networks ... ok
> test_02_stop_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test stop an instance in VPC networks ... ok
> test_03_start_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test start an instance in VPC networks ... ok
> test_04_reboot_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test reboot an instance in VPC networks ... ok
> test_05_destroy_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test destroy an instance in VPC networks ... ok
> test_06_migrate_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test migrate an instance in VPC networks ... ok
> test_07_user_data (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test user data in virtual machines ... ok
> test_08_meta_data (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test meta data in virtual machines ... ok
> test_09_expunge_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test expunge an instance in VPC networks ... ok
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14058/#review28782
-----------------------------------------------------------

Ship it!


Ship It!

- Girish Shilamkar


On Nov. 8, 2013, 1:48 p.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14058/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2013, 1:48 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, venkata swamy babu  budumuru, and Sheng Yang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added 10 tests for VPC VM liftcycle on tagged hosts
> 
> New class added  : TestVMLifeCycleDiffHosts
> 
>     def test_01_deploy_instance_in_network(self):
>     def test_02_stop_instance_in_network(self):
>     def test_03_start_instance_in_network(self):
>     def test_04_reboot_instance_in_network(self):
>     def test_05_destroy_instance_in_network(self):
>     def test_06_recover_instance_in_network(self):
>     def test_07_migrate_instance_in_network(self):
>     def test_08_user_data(self):
>     def test_09_meta_data(self):
>     def	test_10_expunge_instance_in_network(self):
> 
> This set of tests requires a multi host tagged setup (3 hosts - 2 hosts with tag 'host1' and  1 host with tag 'host2')
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_vpc_vm_life_cycle.py cc65eed 
>   tools/marvin/marvin/integration/lib/base.py 10c636c 
> 
> Diff: https://reviews.apache.org/r/14058/diff/
> 
> 
> Testing
> -------
> 
> Tested locally on KVM advanced setup.
> 
> Log:
> 
> test_01_deploy_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test deploy an instance in VPC networks ... ok
> test_02_stop_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test stop an instance in VPC networks ... ok
> test_03_start_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test start an instance in VPC networks ... ok
> test_04_reboot_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test reboot an instance in VPC networks ... ok
> test_05_destroy_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test destroy an instance in VPC networks ... ok
> test_06_migrate_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test migrate an instance in VPC networks ... ok
> test_07_user_data (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test user data in virtual machines ... ok
> test_08_meta_data (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test meta data in virtual machines ... ok
> test_09_expunge_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
> Test expunge an instance in VPC networks ... ok
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14058/
-----------------------------------------------------------

(Updated Nov. 8, 2013, 1:48 p.m.)


Review request for cloudstack, Girish Shilamkar, venkata swamy babu  budumuru, and Sheng Yang.


Changes
-------

Marged patch with latest changes so that it applies to 4.2


Repository: cloudstack-git


Description
-------

Added 10 tests for VPC VM liftcycle on tagged hosts

New class added  : TestVMLifeCycleDiffHosts

    def test_01_deploy_instance_in_network(self):
    def test_02_stop_instance_in_network(self):
    def test_03_start_instance_in_network(self):
    def test_04_reboot_instance_in_network(self):
    def test_05_destroy_instance_in_network(self):
    def test_06_recover_instance_in_network(self):
    def test_07_migrate_instance_in_network(self):
    def test_08_user_data(self):
    def test_09_meta_data(self):
    def	test_10_expunge_instance_in_network(self):

This set of tests requires a multi host tagged setup (3 hosts - 2 hosts with tag 'host1' and  1 host with tag 'host2')


Diffs (updated)
-----

  test/integration/component/test_vpc_vm_life_cycle.py cc65eed 
  tools/marvin/marvin/integration/lib/base.py 10c636c 

Diff: https://reviews.apache.org/r/14058/diff/


Testing
-------

Tested locally on KVM advanced setup.

Log:

test_01_deploy_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test deploy an instance in VPC networks ... ok
test_02_stop_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test stop an instance in VPC networks ... ok
test_03_start_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test start an instance in VPC networks ... ok
test_04_reboot_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test reboot an instance in VPC networks ... ok
test_05_destroy_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test destroy an instance in VPC networks ... ok
test_06_migrate_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test migrate an instance in VPC networks ... ok
test_07_user_data (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test user data in virtual machines ... ok
test_08_meta_data (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test meta data in virtual machines ... ok
test_09_expunge_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test expunge an instance in VPC networks ... ok


Thanks,

Ashutosh Kelkar


Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14058/
-----------------------------------------------------------

(Updated Oct. 16, 2013, 2:09 p.m.)


Review request for cloudstack, Girish Shilamkar, venkata swamy babu  budumuru, and Sheng Yang.


Changes
-------

Added missing method for updateHost in marvin.


Repository: cloudstack-git


Description
-------

Added 10 tests for VPC VM liftcycle on tagged hosts

New class added  : TestVMLifeCycleDiffHosts

    def test_01_deploy_instance_in_network(self):
    def test_02_stop_instance_in_network(self):
    def test_03_start_instance_in_network(self):
    def test_04_reboot_instance_in_network(self):
    def test_05_destroy_instance_in_network(self):
    def test_06_recover_instance_in_network(self):
    def test_07_migrate_instance_in_network(self):
    def test_08_user_data(self):
    def test_09_meta_data(self):
    def	test_10_expunge_instance_in_network(self):

This set of tests requires a multi host tagged setup (3 hosts - 2 hosts with tag 'host1' and  1 host with tag 'host2')


Diffs (updated)
-----

  test/integration/component/test_vpc_vm_life_cycle.py 9844c1f 
  tools/marvin/marvin/integration/lib/base.py 0d52224 

Diff: https://reviews.apache.org/r/14058/diff/


Testing
-------

Tested locally on KVM advanced setup.

Log:

test_01_deploy_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test deploy an instance in VPC networks ... ok
test_02_stop_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test stop an instance in VPC networks ... ok
test_03_start_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test start an instance in VPC networks ... ok
test_04_reboot_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test reboot an instance in VPC networks ... ok
test_05_destroy_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test destroy an instance in VPC networks ... ok
test_06_migrate_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test migrate an instance in VPC networks ... ok
test_07_user_data (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test user data in virtual machines ... ok
test_08_meta_data (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test meta data in virtual machines ... ok
test_09_expunge_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts)
Test expunge an instance in VPC networks ... ok


Thanks,

Ashutosh Kelkar