You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/02/11 08:32:03 UTC
[GitHub] [hudi] yihua opened a new pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
yihua opened a new pull request #4792:
URL: https://github.com/apache/hudi/pull/4792
## What is the purpose of the pull request
This PR removes hardcoded logic of disabling metadata table in tests and fixes test that are broken with metadata table.
## Verify this pull request
This pull request is already covered by existing tests.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4792:
URL: https://github.com/apache/hudi/pull/4792#issuecomment-1039719816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4792:
URL: https://github.com/apache/hudi/pull/4792#issuecomment-1039892648
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5907",
"triggerID" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"triggerType" : "PUSH"
}, {
"hash" : "d8967834c4778bbbdaad3aef70de4efa7c4a5d6d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6007",
"triggerID" : "d8967834c4778bbbdaad3aef70de4efa7c4a5d6d",
"triggerType" : "PUSH"
}, {
"hash" : "92d8377315d30921e2fecdf0472367ba15818a5c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6017",
"triggerID" : "92d8377315d30921e2fecdf0472367ba15818a5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 92d8377315d30921e2fecdf0472367ba15818a5c Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6017)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4792:
URL: https://github.com/apache/hudi/pull/4792#issuecomment-1039721471
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5907",
"triggerID" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"triggerType" : "PUSH"
}, {
"hash" : "d8967834c4778bbbdaad3aef70de4efa7c4a5d6d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6007",
"triggerID" : "d8967834c4778bbbdaad3aef70de4efa7c4a5d6d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b2bdd81dc3f7edea2934b1cd461ee50dff029b7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5907)
* d8967834c4778bbbdaad3aef70de4efa7c4a5d6d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6007)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4792:
URL: https://github.com/apache/hudi/pull/4792#issuecomment-1039719816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5907",
"triggerID" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"triggerType" : "PUSH"
}, {
"hash" : "d8967834c4778bbbdaad3aef70de4efa7c4a5d6d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d8967834c4778bbbdaad3aef70de4efa7c4a5d6d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b2bdd81dc3f7edea2934b1cd461ee50dff029b7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5907)
* d8967834c4778bbbdaad3aef70de4efa7c4a5d6d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4792:
URL: https://github.com/apache/hudi/pull/4792#issuecomment-1039764987
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5907",
"triggerID" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"triggerType" : "PUSH"
}, {
"hash" : "d8967834c4778bbbdaad3aef70de4efa7c4a5d6d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6007",
"triggerID" : "d8967834c4778bbbdaad3aef70de4efa7c4a5d6d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d8967834c4778bbbdaad3aef70de4efa7c4a5d6d Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6007)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4792:
URL: https://github.com/apache/hudi/pull/4792#issuecomment-1035979794
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b2bdd81dc3f7edea2934b1cd461ee50dff029b7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4792:
URL: https://github.com/apache/hudi/pull/4792#issuecomment-1035981836
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5907",
"triggerID" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b2bdd81dc3f7edea2934b1cd461ee50dff029b7 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5907)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a change in pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
Posted by GitBox <gi...@apache.org>.
yihua commented on a change in pull request #4792:
URL: https://github.com/apache/hudi/pull/4792#discussion_r807116666
##########
File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/TestHoodieTimelineArchiver.java
##########
@@ -472,6 +475,12 @@ public void testArchiveCommitSavepointNoHole() throws Exception {
HoodieTable table = HoodieSparkTable.create(cfg, context);
HoodieTimelineArchiver archiver = new HoodieTimelineArchiver(cfg, table);
+ if (enableMetadataTable) {
+ // Simulate a compaction commit in metadata table timeline
Review comment:
It's mainly for the clarity of reading the workflow of the tests. If it's verbose, I can remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4792:
URL: https://github.com/apache/hudi/pull/4792#issuecomment-1036035557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5907",
"triggerID" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b2bdd81dc3f7edea2934b1cd461ee50dff029b7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5907)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4792:
URL: https://github.com/apache/hudi/pull/4792#issuecomment-1039719816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5907",
"triggerID" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"triggerType" : "PUSH"
}, {
"hash" : "d8967834c4778bbbdaad3aef70de4efa7c4a5d6d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d8967834c4778bbbdaad3aef70de4efa7c4a5d6d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b2bdd81dc3f7edea2934b1cd461ee50dff029b7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5907)
* d8967834c4778bbbdaad3aef70de4efa7c4a5d6d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4792:
URL: https://github.com/apache/hudi/pull/4792#issuecomment-1039721471
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5907",
"triggerID" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"triggerType" : "PUSH"
}, {
"hash" : "d8967834c4778bbbdaad3aef70de4efa7c4a5d6d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6007",
"triggerID" : "d8967834c4778bbbdaad3aef70de4efa7c4a5d6d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b2bdd81dc3f7edea2934b1cd461ee50dff029b7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5907)
* d8967834c4778bbbdaad3aef70de4efa7c4a5d6d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6007)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4792:
URL: https://github.com/apache/hudi/pull/4792#issuecomment-1035979794
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b2bdd81dc3f7edea2934b1cd461ee50dff029b7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4792:
URL: https://github.com/apache/hudi/pull/4792#issuecomment-1039801948
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5907",
"triggerID" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"triggerType" : "PUSH"
}, {
"hash" : "d8967834c4778bbbdaad3aef70de4efa7c4a5d6d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6007",
"triggerID" : "d8967834c4778bbbdaad3aef70de4efa7c4a5d6d",
"triggerType" : "PUSH"
}, {
"hash" : "92d8377315d30921e2fecdf0472367ba15818a5c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6017",
"triggerID" : "92d8377315d30921e2fecdf0472367ba15818a5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d8967834c4778bbbdaad3aef70de4efa7c4a5d6d Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6007)
* 92d8377315d30921e2fecdf0472367ba15818a5c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6017)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4792:
URL: https://github.com/apache/hudi/pull/4792#issuecomment-1039800254
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5907",
"triggerID" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"triggerType" : "PUSH"
}, {
"hash" : "d8967834c4778bbbdaad3aef70de4efa7c4a5d6d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6007",
"triggerID" : "d8967834c4778bbbdaad3aef70de4efa7c4a5d6d",
"triggerType" : "PUSH"
}, {
"hash" : "92d8377315d30921e2fecdf0472367ba15818a5c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "92d8377315d30921e2fecdf0472367ba15818a5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d8967834c4778bbbdaad3aef70de4efa7c4a5d6d Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6007)
* 92d8377315d30921e2fecdf0472367ba15818a5c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4792:
URL: https://github.com/apache/hudi/pull/4792#issuecomment-1036035557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4792:
URL: https://github.com/apache/hudi/pull/4792#issuecomment-1039801948
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5907",
"triggerID" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"triggerType" : "PUSH"
}, {
"hash" : "d8967834c4778bbbdaad3aef70de4efa7c4a5d6d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6007",
"triggerID" : "d8967834c4778bbbdaad3aef70de4efa7c4a5d6d",
"triggerType" : "PUSH"
}, {
"hash" : "92d8377315d30921e2fecdf0472367ba15818a5c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6017",
"triggerID" : "92d8377315d30921e2fecdf0472367ba15818a5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d8967834c4778bbbdaad3aef70de4efa7c4a5d6d Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6007)
* 92d8377315d30921e2fecdf0472367ba15818a5c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6017)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #4792:
URL: https://github.com/apache/hudi/pull/4792#discussion_r807108709
##########
File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/TestHoodieTimelineArchiver.java
##########
@@ -472,6 +475,12 @@ public void testArchiveCommitSavepointNoHole() throws Exception {
HoodieTable table = HoodieSparkTable.create(cfg, context);
HoodieTimelineArchiver archiver = new HoodieTimelineArchiver(cfg, table);
+ if (enableMetadataTable) {
+ // Simulate a compaction commit in metadata table timeline
Review comment:
do we need to repeat the comment block everywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #4792:
URL: https://github.com/apache/hudi/pull/4792#discussion_r807108709
##########
File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/TestHoodieTimelineArchiver.java
##########
@@ -472,6 +475,12 @@ public void testArchiveCommitSavepointNoHole() throws Exception {
HoodieTable table = HoodieSparkTable.create(cfg, context);
HoodieTimelineArchiver archiver = new HoodieTimelineArchiver(cfg, table);
+ if (enableMetadataTable) {
+ // Simulate a compaction commit in metadata table timeline
Review comment:
do we need to repeat the comment block everywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a change in pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
Posted by GitBox <gi...@apache.org>.
yihua commented on a change in pull request #4792:
URL: https://github.com/apache/hudi/pull/4792#discussion_r807116666
##########
File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/TestHoodieTimelineArchiver.java
##########
@@ -472,6 +475,12 @@ public void testArchiveCommitSavepointNoHole() throws Exception {
HoodieTable table = HoodieSparkTable.create(cfg, context);
HoodieTimelineArchiver archiver = new HoodieTimelineArchiver(cfg, table);
+ if (enableMetadataTable) {
+ // Simulate a compaction commit in metadata table timeline
Review comment:
It's mainly for the clarity of reading the workflow of the tests. If it's verbose, I can remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4792:
URL: https://github.com/apache/hudi/pull/4792#issuecomment-1039800254
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5907",
"triggerID" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"triggerType" : "PUSH"
}, {
"hash" : "d8967834c4778bbbdaad3aef70de4efa7c4a5d6d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6007",
"triggerID" : "d8967834c4778bbbdaad3aef70de4efa7c4a5d6d",
"triggerType" : "PUSH"
}, {
"hash" : "92d8377315d30921e2fecdf0472367ba15818a5c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "92d8377315d30921e2fecdf0472367ba15818a5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d8967834c4778bbbdaad3aef70de4efa7c4a5d6d Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6007)
* 92d8377315d30921e2fecdf0472367ba15818a5c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4792:
URL: https://github.com/apache/hudi/pull/4792#issuecomment-1039764987
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5907",
"triggerID" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"triggerType" : "PUSH"
}, {
"hash" : "d8967834c4778bbbdaad3aef70de4efa7c4a5d6d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6007",
"triggerID" : "d8967834c4778bbbdaad3aef70de4efa7c4a5d6d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d8967834c4778bbbdaad3aef70de4efa7c4a5d6d Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6007)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4792:
URL: https://github.com/apache/hudi/pull/4792#issuecomment-1036035557
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5907",
"triggerID" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b2bdd81dc3f7edea2934b1cd461ee50dff029b7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5907)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4792:
URL: https://github.com/apache/hudi/pull/4792#issuecomment-1035981836
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5907",
"triggerID" : "1b2bdd81dc3f7edea2934b1cd461ee50dff029b7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b2bdd81dc3f7edea2934b1cd461ee50dff029b7 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5907)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #4792: [HUDI-3366] Remove hardcoded logic of disabling metadata table in tests
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #4792:
URL: https://github.com/apache/hudi/pull/4792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org