[GitHub] [airflow] uranusjr commented on a diff in pull request #25176: Implement XComArg.zip(*xcom_args)

[GitBox <gi...@apache.org>]

uranusjr commented on code in PR #25176:
URL: https://github.com/apache/airflow/pull/25176#discussion_r932034109


##########
airflow/serialization/serialized_objects.py:
##########
@@ -393,7 +392,7 @@ def _serialize(cls, var: Any) -> Any:  # Unfortunately there is no support for r
         elif isinstance(var, Param):
             return cls._encode(cls._serialize_param(var), type_=DAT.PARAM)
         elif isinstance(var, XComArg):
-            return cls._encode(cls._serialize_xcomarg(var), type_=DAT.XCOM_REF)
+            return cls._encode(serialize_xcom_arg(var), type_=DAT.XCOM_REF)

Review Comment:
   Kind of intended, since I don’t want to pollute the serialisation logic with different XComArg types. Maybe using another key would improve the result? Say
   
   ```
   {"_type": "xcom_ref", "_val": {"task_id": "...", "key": "..."}}
   
   {
       "_type": "xcom_ref",
       "_val": {
            "kind": "map",
            "arg": {"task_id": "...", "key": "..."},
            "callables": [...]
       }
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org