You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Kevin Sweeney <ke...@apache.org> on 2015/03/16 19:54:37 UTC
Review Request 32118: Move creation of auth_module into
ThriftAuthModule.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32118/
-----------------------------------------------------------
Review request for Aurora, Joshua Cohen and Bill Farner.
Bugs: AURORA-1201
https://issues.apache.org/jira/browse/AURORA-1201
Repository: aurora
Description
-------
Move creation of auth_module into ThriftAuthModule.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/app/Modules.java e86e35f5435e7e83956fd80c8d3ae39eb50c9170
src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java c6f8787c894533327114425ba17bca966f07b554
src/main/java/org/apache/aurora/scheduler/thrift/auth/ThriftAuthModule.java e390af12669ac9464e2e7f6e9e1288136ed5ed9b
src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java bb19fc72cafc1640f6331c5eaa3761da1a4af7c0
Diff: https://reviews.apache.org/r/32118/diff/
Testing
-------
./gradlew build
Thanks,
Kevin Sweeney
Re: Review Request 32118: Move creation of auth_module into
ThriftAuthModule.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32118/#review76629
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On March 16, 2015, 6:54 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32118/
> -----------------------------------------------------------
>
> (Updated March 16, 2015, 6:54 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-1201
> https://issues.apache.org/jira/browse/AURORA-1201
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Move creation of auth_module into ThriftAuthModule.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/app/Modules.java e86e35f5435e7e83956fd80c8d3ae39eb50c9170
> src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java c6f8787c894533327114425ba17bca966f07b554
> src/main/java/org/apache/aurora/scheduler/thrift/auth/ThriftAuthModule.java e390af12669ac9464e2e7f6e9e1288136ed5ed9b
> src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java bb19fc72cafc1640f6331c5eaa3761da1a4af7c0
>
> Diff: https://reviews.apache.org/r/32118/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 32118: Move creation of auth_module into
ThriftAuthModule.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32118/#review76628
-----------------------------------------------------------
Ship it!
Master (e11ed5b) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 16, 2015, 6:54 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32118/
> -----------------------------------------------------------
>
> (Updated March 16, 2015, 6:54 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-1201
> https://issues.apache.org/jira/browse/AURORA-1201
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Move creation of auth_module into ThriftAuthModule.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/app/Modules.java e86e35f5435e7e83956fd80c8d3ae39eb50c9170
> src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java c6f8787c894533327114425ba17bca966f07b554
> src/main/java/org/apache/aurora/scheduler/thrift/auth/ThriftAuthModule.java e390af12669ac9464e2e7f6e9e1288136ed5ed9b
> src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java bb19fc72cafc1640f6331c5eaa3761da1a4af7c0
>
> Diff: https://reviews.apache.org/r/32118/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 32118: Move creation of auth_module into
ThriftAuthModule.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32118/#review76613
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On March 16, 2015, 6:54 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32118/
> -----------------------------------------------------------
>
> (Updated March 16, 2015, 6:54 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-1201
> https://issues.apache.org/jira/browse/AURORA-1201
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Move creation of auth_module into ThriftAuthModule.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/app/Modules.java e86e35f5435e7e83956fd80c8d3ae39eb50c9170
> src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java c6f8787c894533327114425ba17bca966f07b554
> src/main/java/org/apache/aurora/scheduler/thrift/auth/ThriftAuthModule.java e390af12669ac9464e2e7f6e9e1288136ed5ed9b
> src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java bb19fc72cafc1640f6331c5eaa3761da1a4af7c0
>
> Diff: https://reviews.apache.org/r/32118/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> Kevin Sweeney
>
>