You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/05/28 13:32:50 UTC

[GitHub] [hbase] belugabehr opened a new pull request #3328: HBASE-25936: Improve Logging Statement Formatting

belugabehr opened a new pull request #3328:
URL: https://github.com/apache/hbase/pull/3328


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #3328: HBASE-25936: Improve Logging Statement Formatting

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3328:
URL: https://github.com/apache/hbase/pull/3328#issuecomment-850483816


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 28s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 22s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 51s |  master passed  |
   | +1 :green_heart: |  compile  |   6m  5s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   8m 13s |  branch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   4m 53s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   1m 44s |  root in the patch failed.  |
   | -1 :x: |  compile  |   0m 29s |  hbase-server in the patch failed.  |
   | -0 :warning: |  javac  |   0m 29s |  hbase-server in the patch failed.  |
   | -1 :x: |  shadedjars  |   6m  8s |  patch has 18 errors when building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 18s |  hbase-server in the patch failed.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 48s |  hbase-common in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 35s |  hbase-hadoop-compat in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 12s |  hbase-client in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 43s |  hbase-zookeeper in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 28s |  hbase-replication in the patch passed.  |
   | +1 :green_heart: |  unit  |   5m 48s |  hbase-balancer in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 46s |  hbase-http in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 57s |  hbase-procedure in the patch passed.  |
   | -1 :x: |  unit  |   0m 29s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  unit  |  11m 11s |  hbase-mapreduce in the patch passed.  |
   | +1 :green_heart: |  unit  |   4m 37s |  hbase-thrift in the patch passed.  |
   | +1 :green_heart: |  unit  |   9m 34s |  hbase-backup in the patch passed.  |
   | +1 :green_heart: |  unit  |   4m  5s |  hbase-rest in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 22s |  hbase-external-blockcache in the patch passed.  |
   |  |   |  89m 36s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/3328 |
   | JIRA Issue | HBASE-25936 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux a1fa7d52b047 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 560297d189 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt |
   | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt |
   | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt |
   | shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-hbase-server.txt |
   | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/testReport/ |
   | Max. process+thread count | 4765 (vs. ulimit of 30000) |
   | modules | C: hbase-common hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-backup hbase-rest hbase-external-blockcache U: . |
   | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/console |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #3328: HBASE-25936: Improve Logging Statement Formatting

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3328:
URL: https://github.com/apache/hbase/pull/3328#issuecomment-850619755


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 28s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 23s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m 28s |  master passed  |
   | +1 :green_heart: |  compile  |   6m 31s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   8m 10s |  branch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   5m 29s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m 11s |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 26s |  the patch passed  |
   | +1 :green_heart: |  javac  |   6m 26s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   8m  8s |  patch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   5m 26s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m  2s |  hbase-common in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 39s |  hbase-hadoop-compat in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 18s |  hbase-client in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 46s |  hbase-zookeeper in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 28s |  hbase-replication in the patch passed.  |
   | +1 :green_heart: |  unit  |   7m  7s |  hbase-balancer in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 47s |  hbase-http in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 42s |  hbase-procedure in the patch passed.  |
   | +1 :green_heart: |  unit  | 136m 31s |  hbase-server in the patch passed.  |
   | +1 :green_heart: |  unit  |  10m 16s |  hbase-mapreduce in the patch passed.  |
   | +1 :green_heart: |  unit  |   4m 47s |  hbase-thrift in the patch passed.  |
   | +1 :green_heart: |  unit  |   9m 35s |  hbase-backup in the patch passed.  |
   | +1 :green_heart: |  unit  |   3m 47s |  hbase-rest in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 38s |  hbase-external-blockcache in the patch passed.  |
   |  |   | 235m 24s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/3328 |
   | JIRA Issue | HBASE-25936 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux b05c4a1405b7 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 479ae88be3 |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   |  Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/2/testReport/ |
   | Max. process+thread count | 4862 (vs. ulimit of 30000) |
   | modules | C: hbase-common hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-backup hbase-rest hbase-external-blockcache U: . |
   | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/2/console |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #3328: HBASE-25936: Improve Logging Statement Formatting

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3328:
URL: https://github.com/apache/hbase/pull/3328#issuecomment-850634079


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 30s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 41s |  master passed  |
   | +1 :green_heart: |  compile  |   6m 34s |  master passed  |
   | +1 :green_heart: |  shadedjars  |  11m 12s |  branch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   5m 30s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m 44s |  the patch passed  |
   | +1 :green_heart: |  compile  |   6m 53s |  the patch passed  |
   | +1 :green_heart: |  javac  |   6m 53s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |  10m 42s |  patch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   5m 14s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m  0s |  hbase-common in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 40s |  hbase-hadoop-compat in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 23s |  hbase-client in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 48s |  hbase-zookeeper in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 28s |  hbase-replication in the patch passed.  |
   | +1 :green_heart: |  unit  |   6m 55s |  hbase-balancer in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 52s |  hbase-http in the patch passed.  |
   | +1 :green_heart: |  unit  |   2m  9s |  hbase-procedure in the patch passed.  |
   | +1 :green_heart: |  unit  | 155m 25s |  hbase-server in the patch passed.  |
   | +1 :green_heart: |  unit  |  11m 44s |  hbase-mapreduce in the patch passed.  |
   | +1 :green_heart: |  unit  |   4m 54s |  hbase-thrift in the patch passed.  |
   | +1 :green_heart: |  unit  |   9m 44s |  hbase-backup in the patch passed.  |
   | +1 :green_heart: |  unit  |   4m 14s |  hbase-rest in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 37s |  hbase-external-blockcache in the patch passed.  |
   |  |   | 262m 17s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/3328 |
   | JIRA Issue | HBASE-25936 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 31a56fa5d886 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 479ae88be3 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   |  Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/2/testReport/ |
   | Max. process+thread count | 4758 (vs. ulimit of 30000) |
   | modules | C: hbase-common hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-backup hbase-rest hbase-external-blockcache U: . |
   | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/2/console |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #3328: HBASE-25936: Improve Logging Statement Formatting

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3328:
URL: https://github.com/apache/hbase/pull/3328#issuecomment-850473233


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 28s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  2s |  No case conflicting files found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 22s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 52s |  master passed  |
   | +1 :green_heart: |  compile  |  11m 26s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   5m 22s |  master passed  |
   | +1 :green_heart: |  spotbugs  |  10m 43s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   1m 41s |  root in the patch failed.  |
   | -1 :x: |  compile  |   0m 29s |  hbase-server in the patch failed.  |
   | -0 :warning: |  javac  |   0m 47s |  hbase-common generated 1 new + 158 unchanged - 1 fixed = 159 total (was 159)  |
   | -0 :warning: |  javac  |   0m 29s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  checkstyle  |   0m 25s |  hbase-common: The patch generated 0 new + 77 unchanged - 6 fixed = 77 total (was 83)  |
   | +1 :green_heart: |  checkstyle  |   0m 12s |  The patch passed checkstyle in hbase-hadoop-compat  |
   | +1 :green_heart: |  checkstyle  |   0m 28s |  hbase-client: The patch generated 0 new + 54 unchanged - 1 fixed = 54 total (was 55)  |
   | +1 :green_heart: |  checkstyle  |   0m 12s |  The patch passed checkstyle in hbase-zookeeper  |
   | +1 :green_heart: |  checkstyle  |   0m 11s |  The patch passed checkstyle in hbase-replication  |
   | +1 :green_heart: |  checkstyle  |   0m 13s |  The patch passed checkstyle in hbase-balancer  |
   | +1 :green_heart: |  checkstyle  |   0m 12s |  The patch passed checkstyle in hbase-http  |
   | +1 :green_heart: |  checkstyle  |   0m 14s |  The patch passed checkstyle in hbase-procedure  |
   | -0 :warning: |  checkstyle  |   0m 27s |  The patch fails to run checkstyle in hbase-server  |
   | +1 :green_heart: |  checkstyle  |   0m 19s |  The patch passed checkstyle in hbase-mapreduce  |
   | +1 :green_heart: |  checkstyle  |   0m 40s |  The patch passed checkstyle in hbase-thrift  |
   | -0 :warning: |  checkstyle  |   0m 13s |  hbase-backup: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)  |
   | +1 :green_heart: |  checkstyle  |   0m 16s |  The patch passed checkstyle in hbase-rest  |
   | +1 :green_heart: |  checkstyle  |   0m 10s |  The patch passed checkstyle in hbase-external-blockcache  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | -1 :x: |  hadoopcheck  |   1m 54s |  The patch causes 18 errors with Hadoop v3.1.2.  |
   | -1 :x: |  hadoopcheck  |   3m 53s |  The patch causes 18 errors with Hadoop v3.2.1.  |
   | -1 :x: |  hadoopcheck  |   5m 50s |  The patch causes 18 errors with Hadoop v3.3.0.  |
   | -1 :x: |  spotbugs  |   0m 29s |  hbase-server in the patch failed.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   2m 24s |  The patch does not generate ASF License warnings.  |
   |  |   |  73m 27s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/3328 |
   | JIRA Issue | HBASE-25936 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux e66e4b68fe31 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 560297d189 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
   | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt |
   | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt |
   | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt |
   | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-general-check/output/buildtool-patch-checkstyle-hbase-server.txt |
   | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-backup.txt |
   | hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-general-check/output/patch-javac-3.1.2.txt |
   | hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-general-check/output/patch-javac-3.2.1.txt |
   | hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-general-check/output/patch-javac-3.3.0.txt |
   | spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt |
   | Max. process+thread count | 96 (vs. ulimit of 30000) |
   | modules | C: hbase-common hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-backup hbase-rest hbase-external-blockcache U: . |
   | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/console |
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #3328: HBASE-25936: Improve Logging Statement Formatting

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3328:
URL: https://github.com/apache/hbase/pull/3328#issuecomment-850549149


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 30s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  2s |  No case conflicting files found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 34s |  master passed  |
   | +1 :green_heart: |  compile  |  11m 17s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   5m 19s |  master passed  |
   | +1 :green_heart: |  spotbugs  |  10m 40s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 37s |  the patch passed  |
   | +1 :green_heart: |  compile  |  11m 21s |  the patch passed  |
   | -0 :warning: |  javac  |   0m 49s |  hbase-common generated 1 new + 158 unchanged - 1 fixed = 159 total (was 159)  |
   | +1 :green_heart: |  checkstyle  |   0m 26s |  hbase-common: The patch generated 0 new + 77 unchanged - 6 fixed = 77 total (was 83)  |
   | +1 :green_heart: |  checkstyle  |   0m 14s |  The patch passed checkstyle in hbase-hadoop-compat  |
   | +1 :green_heart: |  checkstyle  |   0m 28s |  hbase-client: The patch generated 0 new + 54 unchanged - 1 fixed = 54 total (was 55)  |
   | +1 :green_heart: |  checkstyle  |   0m 13s |  The patch passed checkstyle in hbase-zookeeper  |
   | +1 :green_heart: |  checkstyle  |   0m 13s |  The patch passed checkstyle in hbase-replication  |
   | +1 :green_heart: |  checkstyle  |   0m 15s |  The patch passed checkstyle in hbase-balancer  |
   | +1 :green_heart: |  checkstyle  |   0m 14s |  The patch passed checkstyle in hbase-http  |
   | +1 :green_heart: |  checkstyle  |   0m 15s |  The patch passed checkstyle in hbase-procedure  |
   | -0 :warning: |  checkstyle  |   1m 17s |  hbase-server: The patch generated 6 new + 612 unchanged - 12 fixed = 618 total (was 624)  |
   | +1 :green_heart: |  checkstyle  |   0m 22s |  The patch passed checkstyle in hbase-mapreduce  |
   | +1 :green_heart: |  checkstyle  |   0m 41s |  The patch passed checkstyle in hbase-thrift  |
   | -0 :warning: |  checkstyle  |   0m 15s |  hbase-backup: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)  |
   | +1 :green_heart: |  checkstyle  |   0m 17s |  The patch passed checkstyle in hbase-rest  |
   | +1 :green_heart: |  checkstyle  |   0m 12s |  The patch passed checkstyle in hbase-external-blockcache  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  hadoopcheck  |  18m  4s |  Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.  |
   | +1 :green_heart: |  spotbugs  |  13m 23s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   2m 50s |  The patch does not generate ASF License warnings.  |
   |  |   |  98m 36s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/2/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/3328 |
   | JIRA Issue | HBASE-25936 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 8ab411ba10e3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 479ae88be3 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-common.txt |
   | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt |
   | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-backup.txt |
   | Max. process+thread count | 96 (vs. ulimit of 30000) |
   | modules | C: hbase-common hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-backup hbase-rest hbase-external-blockcache U: . |
   | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/2/console |
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache9 commented on pull request #3328: HBASE-25936: Improve Logging Statement Formatting

Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #3328:
URL: https://github.com/apache/hbase/pull/3328#issuecomment-855524868


   Please update the patch to address the conflicts?
   
   And is this done by a tool or you have done it manually?
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #3328: HBASE-25936: Improve Logging Statement Formatting

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3328:
URL: https://github.com/apache/hbase/pull/3328#issuecomment-850484705


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 28s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 22s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m 19s |  master passed  |
   | +1 :green_heart: |  compile  |   6m 27s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   8m 11s |  branch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   5m 30s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   1m 59s |  root in the patch failed.  |
   | -1 :x: |  compile  |   0m 28s |  hbase-server in the patch failed.  |
   | -0 :warning: |  javac  |   0m 28s |  hbase-server in the patch failed.  |
   | -1 :x: |  shadedjars  |   5m 57s |  patch has 18 errors when building our shaded downstream artifacts.  |
   | -0 :warning: |  javadoc  |   0m 19s |  hbase-server in the patch failed.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m  2s |  hbase-common in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 39s |  hbase-hadoop-compat in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 19s |  hbase-client in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 44s |  hbase-zookeeper in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 28s |  hbase-replication in the patch passed.  |
   | +1 :green_heart: |  unit  |   7m 39s |  hbase-balancer in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 46s |  hbase-http in the patch passed.  |
   | +1 :green_heart: |  unit  |   1m 45s |  hbase-procedure in the patch passed.  |
   | -1 :x: |  unit  |   0m 29s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  unit  |   9m 46s |  hbase-mapreduce in the patch passed.  |
   | +1 :green_heart: |  unit  |   4m 23s |  hbase-thrift in the patch passed.  |
   | +1 :green_heart: |  unit  |   9m  3s |  hbase-backup in the patch passed.  |
   | +1 :green_heart: |  unit  |   3m 13s |  hbase-rest in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 24s |  hbase-external-blockcache in the patch passed.  |
   |  |   |  91m  6s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/3328 |
   | JIRA Issue | HBASE-25936 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux c4c75d931df0 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 560297d189 |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   | mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt |
   | compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt |
   | javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt |
   | shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt |
   | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt |
   | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/testReport/ |
   | Max. process+thread count | 4849 (vs. ulimit of 30000) |
   | modules | C: hbase-common hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-procedure hbase-server hbase-mapreduce hbase-thrift hbase-backup hbase-rest hbase-external-blockcache U: . |
   | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3328/1/console |
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org