You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by Emilian Bold <em...@apache.org> on 2018/06/13 13:20:03 UTC
Review Request 67570: Adds Apache feather and hyperlink in Start Page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67570/
-----------------------------------------------------------
Review request for netbeans.
Repository: netbeans
Description
-------
Adds Apache feather and hyperlink in Start Page, image created manually from the Apache feather SVG
Diffs
-----
welcome/licenseinfo.xml 23e18b1c6
welcome/src/org/netbeans/modules/welcome/content/Constants.java bf93dbb51
welcome/src/org/netbeans/modules/welcome/content/Logo.java c77132bd8
welcome/src/org/netbeans/modules/welcome/resources/Bundle.properties 782ffab9e
welcome/src/org/netbeans/modules/welcome/resources/apache_feather.png PRE-CREATION
welcome/src/org/netbeans/modules/welcome/resources/apache_feather_dark.png PRE-CREATION
welcome/src/org/netbeans/modules/welcome/resources/oracle_logo.png d6168216ee63493e06833e7ad4ae364e40e51387
welcome/src/org/netbeans/modules/welcome/resources/oracle_logo_dark.png d6168216ee63493e06833e7ad4ae364e40e51387
welcome/src/org/netbeans/modules/welcome/ui/BottomBar.java e74df096f
Diff: https://reviews.apache.org/r/67570/diff/1/
Testing
-------
Thanks,
Emilian Bold
Re: Review Request 67570: Adds Apache feather and hyperlink in Start
Page
Posted by Matthias Bläsing <mb...@doppel-helix.eu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67570/#review204792
-----------------------------------------------------------
Ship it!
Looks good.
- Matthias Bläsing
On Juni 13, 2018, 1:20 nachm., Emilian Bold wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67570/
> -----------------------------------------------------------
>
> (Updated Juni 13, 2018, 1:20 nachm.)
>
>
> Review request for netbeans.
>
>
> Repository: netbeans
>
>
> Description
> -------
>
> Adds Apache feather and hyperlink in Start Page, image created manually from the Apache feather SVG
>
>
> Diffs
> -----
>
> welcome/licenseinfo.xml 23e18b1c6
> welcome/src/org/netbeans/modules/welcome/content/Constants.java bf93dbb51
> welcome/src/org/netbeans/modules/welcome/content/Logo.java c77132bd8
> welcome/src/org/netbeans/modules/welcome/resources/Bundle.properties 782ffab9e
> welcome/src/org/netbeans/modules/welcome/resources/apache_feather.png PRE-CREATION
> welcome/src/org/netbeans/modules/welcome/resources/apache_feather_dark.png PRE-CREATION
> welcome/src/org/netbeans/modules/welcome/resources/oracle_logo.png d6168216ee63493e06833e7ad4ae364e40e51387
> welcome/src/org/netbeans/modules/welcome/resources/oracle_logo_dark.png d6168216ee63493e06833e7ad4ae364e40e51387
> welcome/src/org/netbeans/modules/welcome/ui/BottomBar.java e74df096f
>
>
> Diff: https://reviews.apache.org/r/67570/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Emilian Bold
>
>
Re: Review Request 67570: Adds Apache feather and hyperlink in Start
Page
Posted by Sven Reimers <sr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67570/#review204695
-----------------------------------------------------------
Ship it!
Looks good for me. Could got in release90 branch as well.
- Sven Reimers
On Juni 13, 2018, 1:20 nachm., Emilian Bold wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67570/
> -----------------------------------------------------------
>
> (Updated Juni 13, 2018, 1:20 nachm.)
>
>
> Review request for netbeans.
>
>
> Repository: netbeans
>
>
> Description
> -------
>
> Adds Apache feather and hyperlink in Start Page, image created manually from the Apache feather SVG
>
>
> Diffs
> -----
>
> welcome/licenseinfo.xml 23e18b1c6
> welcome/src/org/netbeans/modules/welcome/content/Constants.java bf93dbb51
> welcome/src/org/netbeans/modules/welcome/content/Logo.java c77132bd8
> welcome/src/org/netbeans/modules/welcome/resources/Bundle.properties 782ffab9e
> welcome/src/org/netbeans/modules/welcome/resources/apache_feather.png PRE-CREATION
> welcome/src/org/netbeans/modules/welcome/resources/apache_feather_dark.png PRE-CREATION
> welcome/src/org/netbeans/modules/welcome/resources/oracle_logo.png d6168216ee63493e06833e7ad4ae364e40e51387
> welcome/src/org/netbeans/modules/welcome/resources/oracle_logo_dark.png d6168216ee63493e06833e7ad4ae364e40e51387
> welcome/src/org/netbeans/modules/welcome/ui/BottomBar.java e74df096f
>
>
> Diff: https://reviews.apache.org/r/67570/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Emilian Bold
>
>
Fw: Review Request 67570: Adds Apache feather and hyperlink in Start Page
Posted by Emilian Bold <em...@protonmail.ch>.
If you're not subscribed to notifications@ you might have missed this brand new code review I've started on [reviews.apache.org](https://reviews.apache.org/r/67570/)
I invite anyone to give this a try.
--emi
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On 13 June 2018 4:20 PM, Emilian Bold <em...@apache.org> wrote:
> This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67570/
>
> Review request for netbeans.
> By Emilian Bold.
> Repository: netbeans
>
> Description
>
> Adds Apache feather and hyperlink in Start Page, image created manually from the Apache feather SVG
>
> Diffs
>
> - welcome/licenseinfo.xml (23e18b1c6)
>
> - welcome/src/org/netbeans/modules/welcome/content/Constants.java (bf93dbb51)
>
> - welcome/src/org/netbeans/modules/welcome/content/Logo.java (c77132bd8)
>
> - welcome/src/org/netbeans/modules/welcome/resources/Bundle.properties (782ffab9e)
>
> - welcome/src/org/netbeans/modules/welcome/resources/apache_feather.png (PRE-CREATION)
>
> - welcome/src/org/netbeans/modules/welcome/resources/apache_feather_dark.png (PRE-CREATION)
>
> - welcome/src/org/netbeans/modules/welcome/resources/oracle_logo.png (d6168216ee63493e06833e7ad4ae364e40e51387)
>
> - welcome/src/org/netbeans/modules/welcome/resources/oracle_logo_dark.png (d6168216ee63493e06833e7ad4ae364e40e51387)
>
> - welcome/src/org/netbeans/modules/welcome/ui/BottomBar.java (e74df096f)
>
> [View Diff](https://reviews.apache.org/r/67570/diff/1/)