You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Gokulnathsrinivasanmcw (via GitHub)" <gi...@apache.org> on 2025/07/01 11:18:59 UTC

[PR] Add LLVM Legalization for tir.erf [tvm]

Gokulnathsrinivasanmcw opened a new pull request, #18104:
URL: https://github.com/apache/tvm/pull/18104

   ## Description 
   This PR Includes LLVM Legalization for tir.erf via Tanh Approximation


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add LLVM Legalization for tir.erf [tvm]

Posted by "Gokulnathsrinivasanmcw (via GitHub)" <gi...@apache.org>.
Gokulnathsrinivasanmcw closed pull request #18104: Add LLVM Legalization for tir.erf
URL: https://github.com/apache/tvm/pull/18104


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add LLVM Legalization for tir.erf [tvm]

Posted by "Gokulnathsrinivasanmcw (via GitHub)" <gi...@apache.org>.
Gokulnathsrinivasanmcw commented on PR #18104:
URL: https://github.com/apache/tvm/pull/18104#issuecomment-3023796842

   > Hi @Gokulnathsrinivasanmcw ,
   > 
   > Thanks for the addition, _erf_ is welcome !
   > 
   > There is another concurent proposal [open here](https://github.com/apache/tvm/pull/17992) (have tests, didnt pass lint). Jut please add a test case for erf and make sure all required CI tasks are in green.
   
   Sure, @cbalint13 — I’ll check that out. Thanks for letting me know!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add LLVM Legalization for tir.erf [tvm]

Posted by "cbalint13 (via GitHub)" <gi...@apache.org>.
cbalint13 commented on PR #18104:
URL: https://github.com/apache/tvm/pull/18104#issuecomment-3033513498

   Thank you @Gokulnathsrinivasanmcw !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add LLVM Legalization for tir.erf [tvm]

Posted by "cbalint13 (via GitHub)" <gi...@apache.org>.
cbalint13 commented on PR #18104:
URL: https://github.com/apache/tvm/pull/18104#issuecomment-3023583327

   Hi @Gokulnathsrinivasanmcw ,
   
   Thanks for the addition, *erf* is welcome !
   
   There is another concurent proposal [open here](https://github.com/apache/tvm/pull/17992) (have tests, didnt pass lint).
   Jut please add a test case for erf and make sure all required CI tasks are in green.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add LLVM Legalization for tir.erf [tvm]

Posted by "Gokulnathsrinivasanmcw (via GitHub)" <gi...@apache.org>.
Gokulnathsrinivasanmcw commented on PR #18104:
URL: https://github.com/apache/tvm/pull/18104#issuecomment-3031323062

   > Hi @Gokulnathsrinivasanmcw ,
   > 
   > Thanks for the addition, _erf_ is welcome !
   > 
   > There is another concurent proposal [open here](https://github.com/apache/tvm/pull/17992) (have tests, didnt pass lint). Jut please add a test case for erf and make sure all required CI tasks are in green.
   
   Hi @cbalint13 added test case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add LLVM Legalization for tir.erf [tvm]

Posted by "cbalint13 (via GitHub)" <gi...@apache.org>.
cbalint13 merged PR #18104:
URL: https://github.com/apache/tvm/pull/18104


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org