You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/07/23 16:22:29 UTC
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #1250: HDDS-4018. Datanode log spammed by NPE
adoroszlai opened a new pull request #1250:
URL: https://github.com/apache/hadoop-ozone/pull/1250
## What changes were proposed in this pull request?
Avoid calling `task.await()` without first calling `task.execute()`. The former uses variable initialized in the latter.
https://issues.apache.org/jira/browse/HDDS-4018
## How was this patch tested?
Logs from acceptance test are normal size:
https://github.com/adoroszlai/hadoop-ozone/runs/902827380
Without the patch they grow to 800-1000MB:
https://github.com/apache/hadoop-ozone/suites/950149055/artifacts/11861873
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] runzhiwang commented on pull request #1250: HDDS-4018. Datanode log spammed by NPE
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #1250:
URL: https://github.com/apache/hadoop-ozone/pull/1250#issuecomment-663360990
@adoroszlai Thanks. I will file a new issue for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai merged pull request #1250: HDDS-4018. Datanode log spammed by NPE
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #1250:
URL: https://github.com/apache/hadoop-ozone/pull/1250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] runzhiwang commented on pull request #1250: HDDS-4018. Datanode log spammed by NPE
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #1250:
URL: https://github.com/apache/hadoop-ozone/pull/1250#issuecomment-663285841
LGTM +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1250: HDDS-4018. Datanode log spammed by NPE
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1250:
URL: https://github.com/apache/hadoop-ozone/pull/1250#issuecomment-663360651
Thanks @runzhiwang and @xiaoyuyao for the review.
> The reason of so many logs when NPE happen is when NPE happen, the thread did not sleep and start another while loop immediately. I think we should also avoid this.
@runzhiwang can you please file a new issue for that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] runzhiwang commented on pull request #1250: HDDS-4018. Datanode log spammed by NPE
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #1250:
URL: https://github.com/apache/hadoop-ozone/pull/1250#issuecomment-663328826
@adoroszlai Hi, There is one more comment.
The reason of so many logs when NPE happen is when NPE happen, the thread did not sleep and start another while loop immediately. I think we should also avoid this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org