You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/07/02 20:17:30 UTC

[GitHub] [beam] reuvenlax commented on a change in pull request #15056: [BEAM-10887] Timer clear

reuvenlax commented on a change in pull request #15056:
URL: https://github.com/apache/beam/pull/15056#discussion_r663229663



##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##########
@@ -4851,6 +4851,342 @@ public void onTimer2(
         return PDone.in(input.getPipeline());
       }
     }
+

Review comment:
       I'm not sure how to guarantee that two timers are in the same bundle. Runners can bundle how they please, so simply advancing time to 3 provides no contract that timers A and B will in the same bundle.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org