You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/10 06:45:20 UTC
[GitHub] [iceberg] flashJd opened a new pull request, #4737: delete unnecessary switch case judgement
flashJd opened a new pull request, #4737:
URL: https://github.com/apache/iceberg/pull/4737
private static RowData convert(Types.StructType struct, Record record) invoke private static Object convert(Type type, Object object), the latter has already use a switch case to handle STRUCT,LIST,MAP，so I just remove the unnecessary judgement in the caller method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] flashJd commented on a diff in pull request #4737: delete unnecessary switch case judgement
Posted by GitBox <gi...@apache.org>.
flashJd commented on code in PR #4737:
URL: https://github.com/apache/iceberg/pull/4737#discussion_r874295976
##########
flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/RowDataConverter.java:
##########
@@ -62,22 +62,8 @@ private static RowData convert(Types.StructType struct, Record record) {
List<Types.NestedField> fields = struct.fields();
for (int i = 0; i < fields.size(); i += 1) {
Types.NestedField field = fields.get(i);
-
Review Comment:
I have reverted the unnecessary whitespace change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] flashJd commented on a diff in pull request #4737: delete unnecessary switch case judgement
Posted by GitBox <gi...@apache.org>.
flashJd commented on code in PR #4737:
URL: https://github.com/apache/iceberg/pull/4737#discussion_r889779206
##########
flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/RowDataConverter.java:
##########
@@ -62,22 +62,8 @@ private static RowData convert(Types.StructType struct, Record record) {
List<Types.NestedField> fields = struct.fields();
for (int i = 0; i < fields.size(); i += 1) {
Types.NestedField field = fields.get(i);
-
Review Comment:
@rdblue anything do I need to modify?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4737: delete unnecessary switch case judgement
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #4737:
URL: https://github.com/apache/iceberg/pull/4737#issuecomment-1170353183
Thanks, @flashJd!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #4737: delete unnecessary switch case judgement
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #4737:
URL: https://github.com/apache/iceberg/pull/4737#discussion_r872565425
##########
flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/RowDataConverter.java:
##########
@@ -62,22 +62,8 @@ private static RowData convert(Types.StructType struct, Record record) {
List<Types.NestedField> fields = struct.fields();
for (int i = 0; i < fields.size(); i += 1) {
Types.NestedField field = fields.get(i);
-
Review Comment:
Please revert this unnecessary whitespace change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #4737: delete unnecessary switch case judgement
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #4737:
URL: https://github.com/apache/iceberg/pull/4737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org