You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/20 16:28:19 UTC
[GitHub] [incubator-nuttx] XuNeo opened a new pull request #5294: driver/mmcsd: add option to limit block count in multiple-block trans…
XuNeo opened a new pull request #5294:
URL: https://github.com/apache/incubator-nuttx/pull/5294
## Summary
For some emmc controller, there is limit on blocks can be transferred in multi-block transfer mode, thus change the configuration from CONFIG_MMCSD_MULTIBLOCK_DISABLE to CONFIG_MMCSD_MULTIBLOCK_LIMIT, to specify exact number of blocks.
- set to 0 equals to CONFIG_MMCSD_MULTIBLOCK_DISABLE=n
- set to 1 equals to CONFIG_MMCSD_MULTIBLOCK_DISABLE=y.
- any other value means the block count can be transferred in multi-block mode.
## Impact
None
## Testing
Tested internally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] XuNeo commented on pull request #5294: driver/mmcsd: add option to limit block count in multiple-block trans…
Posted by GitBox <gi...@apache.org>.
XuNeo commented on pull request #5294:
URL: https://github.com/apache/incubator-nuttx/pull/5294#issuecomment-1018648811
Yes, this change is actually a break change for downstream users since CONFIG_MMCSD_MULTIBLOCK_DISABLE no longer exists. They will have to figure out why their EMMC stops working and reconfigure CONFIG_MMCSD_MULTIBLOCK_LIMIT to 1.
Keep both two configurations will make it compatible, but it kinds of redundant.
I suggest a clean code with clear break-changes doc so when issues happen, users can quickly follow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5294: driver/mmcsd: add option to limit block count in multiple-block trans…
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5294:
URL: https://github.com/apache/incubator-nuttx/pull/5294#discussion_r789474186
##########
File path: drivers/mmcsd/mmcsd_sdio.c
##########
@@ -87,6 +87,12 @@
#define IS_EMPTY(priv) (priv->type == MMCSD_CARDTYPE_UNKNOWN)
+#if CONFIG_MMCSD_MULTIBLOCK_LIMIT == 0
+# define MMCSD_MULTIBLOCK_LIMIT UINT_MAX
Review comment:
Since it is used with variables of `ssize_t` maybe better to define this to
```suggestion
# define MMCSD_MULTIBLOCK_LIMIT SSIZE_MAX
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #5294: driver/mmcsd: add option to limit block count in multiple-block trans…
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #5294:
URL: https://github.com/apache/incubator-nuttx/pull/5294#issuecomment-1018690345
> I suggest a clean code with clear break-changes doc so when issues happen, users can quickly follow up.
I agree and would not leave both. We just need to document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5294: driver/mmcsd: add option to limit block count in multiple-block trans…
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5294:
URL: https://github.com/apache/incubator-nuttx/pull/5294#discussion_r789828179
##########
File path: boards/arm/kinetis/freedom-k64f/README.txt
##########
@@ -448,8 +448,8 @@ SD Card Support
Device Drivers -> MMC/SD Driver Support
CONFIG_MMCSD=y : Enable MMC/SD support
CONFIG_MMSCD_NSLOTS=1 : One slot per driver instance
- CONFIG_MMCSD_MULTIBLOCK_DISABLE=y : (REVISIT)
- CONFIG_MMCSD_HAVE_CARDDETECT=y : Supports card-detect PIOs
+ CONFIG_MMCSD_MULTIBLOCK_LIMIT=1 : (REVISIT)
Review comment:
Yes. I mean is this a "revisit" PR and comment can be updated, or it is still relevant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] XuNeo commented on a change in pull request #5294: driver/mmcsd: add option to limit block count in multiple-block trans…
Posted by GitBox <gi...@apache.org>.
XuNeo commented on a change in pull request #5294:
URL: https://github.com/apache/incubator-nuttx/pull/5294#discussion_r789732022
##########
File path: drivers/mmcsd/mmcsd_sdio.c
##########
@@ -87,6 +87,12 @@
#define IS_EMPTY(priv) (priv->type == MMCSD_CARDTYPE_UNKNOWN)
+#if CONFIG_MMCSD_MULTIBLOCK_LIMIT == 0
+# define MMCSD_MULTIBLOCK_LIMIT UINT_MAX
Review comment:
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5294: driver/mmcsd: add option to limit block count in multiple-block trans…
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5294:
URL: https://github.com/apache/incubator-nuttx/pull/5294#issuecomment-1018701329
Add documentation tag for tracking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] XuNeo commented on a change in pull request #5294: driver/mmcsd: add option to limit block count in multiple-block trans…
Posted by GitBox <gi...@apache.org>.
XuNeo commented on a change in pull request #5294:
URL: https://github.com/apache/incubator-nuttx/pull/5294#discussion_r789857213
##########
File path: boards/arm/kinetis/freedom-k64f/README.txt
##########
@@ -448,8 +448,8 @@ SD Card Support
Device Drivers -> MMC/SD Driver Support
CONFIG_MMCSD=y : Enable MMC/SD support
CONFIG_MMSCD_NSLOTS=1 : One slot per driver instance
- CONFIG_MMCSD_MULTIBLOCK_DISABLE=y : (REVISIT)
- CONFIG_MMCSD_HAVE_CARDDETECT=y : Supports card-detect PIOs
+ CONFIG_MMCSD_MULTIBLOCK_LIMIT=1 : (REVISIT)
Review comment:
This is not a "revisit" PR, comment is changed only because of configuration name changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5294: driver/mmcsd: add option to limit block count in multiple-block trans…
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5294:
URL: https://github.com/apache/incubator-nuttx/pull/5294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5294: driver/mmcsd: add option to limit block count in multiple-block trans…
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5294:
URL: https://github.com/apache/incubator-nuttx/pull/5294#discussion_r789467890
##########
File path: boards/arm/kinetis/freedom-k64f/README.txt
##########
@@ -448,8 +448,8 @@ SD Card Support
Device Drivers -> MMC/SD Driver Support
CONFIG_MMCSD=y : Enable MMC/SD support
CONFIG_MMSCD_NSLOTS=1 : One slot per driver instance
- CONFIG_MMCSD_MULTIBLOCK_DISABLE=y : (REVISIT)
- CONFIG_MMCSD_HAVE_CARDDETECT=y : Supports card-detect PIOs
+ CONFIG_MMCSD_MULTIBLOCK_LIMIT=1 : (REVISIT)
Review comment:
Is this related to `(REVISIT)` comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 edited a comment on pull request #5294: driver/mmcsd: add option to limit block count in multiple-block trans…
Posted by GitBox <gi...@apache.org>.
davids5 edited a comment on pull request #5294:
URL: https://github.com/apache/incubator-nuttx/pull/5294#issuecomment-1018703920
@xiaoxiang781216 can we get a 'breaking change' label?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #5294: driver/mmcsd: add option to limit block count in multiple-block trans…
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #5294:
URL: https://github.com/apache/incubator-nuttx/pull/5294#issuecomment-1018703920
@xiaoxiang781216 can we gat a 'breaking change' label?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #5294: driver/mmcsd: add option to limit block count in multiple-block trans…
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #5294:
URL: https://github.com/apache/incubator-nuttx/pull/5294#discussion_r789692514
##########
File path: boards/arm/kinetis/freedom-k64f/README.txt
##########
@@ -448,8 +448,8 @@ SD Card Support
Device Drivers -> MMC/SD Driver Support
CONFIG_MMCSD=y : Enable MMC/SD support
CONFIG_MMSCD_NSLOTS=1 : One slot per driver instance
- CONFIG_MMCSD_MULTIBLOCK_DISABLE=y : (REVISIT)
- CONFIG_MMCSD_HAVE_CARDDETECT=y : Supports card-detect PIOs
+ CONFIG_MMCSD_MULTIBLOCK_LIMIT=1 : (REVISIT)
Review comment:
Yes we had issues on the kinetis with CONFIG_MMCSD_MULTIBLOCK_DISABLE=n
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5294: driver/mmcsd: add option to limit block count in multiple-block trans…
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5294:
URL: https://github.com/apache/incubator-nuttx/pull/5294#issuecomment-1018722794
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org