You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Mikhail Bautin (Created) (JIRA)" <ji...@apache.org> on 2012/03/13 22:34:39 UTC

[jira] [Created] (HBASE-5575) Configure Arcanist lint engine for HBase

Configure Arcanist lint engine for HBase
----------------------------------------

                 Key: HBASE-5575
                 URL: https://issues.apache.org/jira/browse/HBASE-5575
             Project: HBase
          Issue Type: Improvement
            Reporter: Mikhail Bautin
            Assignee: Mikhail Bautin


We need to enable Arcanist lint engine in HBase, so that a commit could be checked by running "arc lint".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5575) Configure Arcanist lint engine for HBase

Posted by "Nicolas Spiegelberg (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228761#comment-13228761 ] 

Nicolas Spiegelberg commented on HBASE-5575:
--------------------------------------------

+1.  This should make every patch writer's job easier and committers can run 'arc lint' before checkin instead of having to focus on style issues during peer review.
                
> Configure Arcanist lint engine for HBase
> ----------------------------------------
>
>                 Key: HBASE-5575
>                 URL: https://issues.apache.org/jira/browse/HBASE-5575
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>
> We need to enable Arcanist lint engine in HBase, so that a commit could be checked by running "arc lint".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5575) Configure Arcanist lint engine for HBase

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231697#comment-13231697 ] 

Hudson commented on HBASE-5575:
-------------------------------

Integrated in HBase-TRUNK #2686 (See [https://builds.apache.org/job/HBase-TRUNK/2686/])
    [jira] [HBASE-5575] Configure Arcanist lint engine for HBase

Summary: Adding Java lint engine to HBase's .arcconfig. The lint engine itself
is part of the arc-jira repository that lives at
https://github.com/facebook/arc-jira/. There are some changes to be made there
to prevent lint from reporting errors for unmodified lines.

Test Plan: arc lint

Reviewers: nspiegelberg, Kannan, Karthik, JIRA, Liyin

Reviewed By: Liyin

Differential Revision: https://reviews.facebook.net/D2289 (Revision 1301751)

     Result = SUCCESS
mbautin : 
Files : 
* /hbase/trunk/.arcconfig

                
> Configure Arcanist lint engine for HBase
> ----------------------------------------
>
>                 Key: HBASE-5575
>                 URL: https://issues.apache.org/jira/browse/HBASE-5575
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>         Attachments: Enabling-lint-2012-03-16_13_40_37.patch
>
>
> We need to enable Arcanist lint engine in HBase, so that a commit could be checked by running "arc lint".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5575) Configure Arcanist lint engine for HBase

Posted by "Mikhail Bautin (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mikhail Bautin updated HBASE-5575:
----------------------------------

    Attachment: Enabling-lint-2012-03-16_13_40_37.patch
    
> Configure Arcanist lint engine for HBase
> ----------------------------------------
>
>                 Key: HBASE-5575
>                 URL: https://issues.apache.org/jira/browse/HBASE-5575
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>         Attachments: Enabling-lint-2012-03-16_13_40_37.patch
>
>
> We need to enable Arcanist lint engine in HBase, so that a commit could be checked by running "arc lint".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5575) Configure Arcanist lint engine for HBase

Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231613#comment-13231613 ] 

Phabricator commented on HBASE-5575:
------------------------------------

mbautin has committed the revision "[jira] [HBASE-5575] Configure Arcanist lint engine for HBase".

REVISION DETAIL
  https://reviews.facebook.net/D2289

COMMIT
  https://reviews.facebook.net/rHBASE1301751

                
> Configure Arcanist lint engine for HBase
> ----------------------------------------
>
>                 Key: HBASE-5575
>                 URL: https://issues.apache.org/jira/browse/HBASE-5575
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>         Attachments: Enabling-lint-2012-03-16_13_40_37.patch
>
>
> We need to enable Arcanist lint engine in HBase, so that a commit could be checked by running "arc lint".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5575) Configure Arcanist lint engine for HBase

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231862#comment-13231862 ] 

Hudson commented on HBASE-5575:
-------------------------------

Integrated in HBase-TRUNK-security #140 (See [https://builds.apache.org/job/HBase-TRUNK-security/140/])
    [jira] [HBASE-5575] Configure Arcanist lint engine for HBase

Summary: Adding Java lint engine to HBase's .arcconfig. The lint engine itself
is part of the arc-jira repository that lives at
https://github.com/facebook/arc-jira/. There are some changes to be made there
to prevent lint from reporting errors for unmodified lines.

Test Plan: arc lint

Reviewers: nspiegelberg, Kannan, Karthik, JIRA, Liyin

Reviewed By: Liyin

Differential Revision: https://reviews.facebook.net/D2289 (Revision 1301751)

     Result = SUCCESS
mbautin : 
Files : 
* /hbase/trunk/.arcconfig

                
> Configure Arcanist lint engine for HBase
> ----------------------------------------
>
>                 Key: HBASE-5575
>                 URL: https://issues.apache.org/jira/browse/HBASE-5575
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>         Attachments: Enabling-lint-2012-03-16_13_40_37.patch
>
>
> We need to enable Arcanist lint engine in HBase, so that a commit could be checked by running "arc lint".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5575) Configure Arcanist lint engine for HBase

Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Hsieh updated HBASE-5575:
----------------------------------

      Component/s: build
    Fix Version/s: 0.89-fb
                   0.96.0
    
> Configure Arcanist lint engine for HBase
> ----------------------------------------
>
>                 Key: HBASE-5575
>                 URL: https://issues.apache.org/jira/browse/HBASE-5575
>             Project: HBase
>          Issue Type: Improvement
>          Components: build
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>             Fix For: 0.96.0, 0.89-fb
>
>         Attachments: Enabling-lint-2012-03-16_13_40_37.patch
>
>
> We need to enable Arcanist lint engine in HBase, so that a commit could be checked by running "arc lint".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5575) Configure Arcanist lint engine for HBase

Posted by "Mikhail Bautin (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231604#comment-13231604 ] 

Mikhail Bautin commented on HBASE-5575:
---------------------------------------

Reviewed at https://reviews.facebook.net/D2289.
                
> Configure Arcanist lint engine for HBase
> ----------------------------------------
>
>                 Key: HBASE-5575
>                 URL: https://issues.apache.org/jira/browse/HBASE-5575
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>         Attachments: Enabling-lint-2012-03-16_13_40_37.patch
>
>
> We need to enable Arcanist lint engine in HBase, so that a commit could be checked by running "arc lint".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (HBASE-5575) Configure Arcanist lint engine for HBase

Posted by "Mikhail Bautin (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mikhail Bautin resolved HBASE-5575.
-----------------------------------

    Resolution: Fixed

Committed to trunk.
                
> Configure Arcanist lint engine for HBase
> ----------------------------------------
>
>                 Key: HBASE-5575
>                 URL: https://issues.apache.org/jira/browse/HBASE-5575
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>         Attachments: Enabling-lint-2012-03-16_13_40_37.patch
>
>
> We need to enable Arcanist lint engine in HBase, so that a commit could be checked by running "arc lint".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira