[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #5212: [TE] endpoint - harleyjj/metricBreakdownPipeline - add flag for ignor…

[GitBox <gi...@apache.org>]

akshayrai commented on a change in pull request #5212: [TE] endpoint - harleyjj/metricBreakdownPipeline - add flag for ignor…
URL: https://github.com/apache/incubator-pinot/pull/5212#discussion_r405833146
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/rootcause/impl/MetricBreakdownPipeline.java
 ##########
 @@ -107,9 +112,11 @@
    * @param includeDimensions dimensions to break down on (all if empty)
    * @param excludeDimensions dimensions not to break down on
    * @param k number of top-ranking elements to emit
+   * @param ignoreScore flag to include all breakdowns, even if score is zero (only set if ignoring wanted)
    */
   public MetricBreakdownPipeline(String outputName, Set<String> inputNames, MetricConfigManager metricDAO,
-      DatasetConfigManager datasetDAO, QueryCache cache, ExecutorService executor, Set<String> includeDimensions, Set<String> excludeDimensions, int k) {
+      DatasetConfigManager datasetDAO, QueryCache cache, ExecutorService executor, Set<String> includeDimensions,
+      Set<String> excludeDimensions, int k, boolean ignoreScore) {
 
 Review comment:
   Who is calling this or rather how is this being triggered? I do not see any updates to the caller in this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org