You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/24 15:41:58 UTC
[GitHub] [skywalking-infra-e2e] mrproliu opened a new pull request #22: Upgrade docker-compose framework
mrproliu opened a new pull request #22:
URL: https://github.com/apache/skywalking-infra-e2e/pull/22
follow https://github.com/apache/skywalking-infra-e2e/pull/19
* Upgrade docker-compose framework to support native port check
* Adopt declare public port in the `docker-compose` file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on a change in pull request #22: [WIP] Upgrade docker-compose framework
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #22:
URL: https://github.com/apache/skywalking-infra-e2e/pull/22#discussion_r658071079
##########
File path: go.mod
##########
@@ -3,13 +3,14 @@ module github.com/apache/skywalking-infra-e2e
go 1.13
require (
- github.com/docker/docker v20.10.6+incompatible
+ github.com/docker/docker v20.10.7+incompatible
+ github.com/docker/go-connections v0.4.0
github.com/google/go-cmp v0.5.4
github.com/gorilla/mux v1.8.0 // indirect
github.com/morikuni/aec v1.0.0 // indirect
github.com/sirupsen/logrus v1.7.0
github.com/spf13/cobra v1.1.1
- github.com/testcontainers/testcontainers-go v0.11.0
+ github.com/testcontainers/testcontainers-go v0.11.1
gopkg.in/yaml.v2 v2.4.0
Review comment:
Whenever you update `go.mod`, please also check the LICENSE file, it is mostly needed update too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng merged pull request #22: Upgrade docker-compose framework
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #22:
URL: https://github.com/apache/skywalking-infra-e2e/pull/22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] mrproliu commented on a change in pull request #22: [WIP] Upgrade docker-compose framework
Posted by GitBox <gi...@apache.org>.
mrproliu commented on a change in pull request #22:
URL: https://github.com/apache/skywalking-infra-e2e/pull/22#discussion_r658077577
##########
File path: go.mod
##########
@@ -3,13 +3,14 @@ module github.com/apache/skywalking-infra-e2e
go 1.13
require (
- github.com/docker/docker v20.10.6+incompatible
+ github.com/docker/docker v20.10.7+incompatible
+ github.com/docker/go-connections v0.4.0
github.com/google/go-cmp v0.5.4
github.com/gorilla/mux v1.8.0 // indirect
github.com/morikuni/aec v1.0.0 // indirect
github.com/sirupsen/logrus v1.7.0
github.com/spf13/cobra v1.1.1
- github.com/testcontainers/testcontainers-go v0.11.0
+ github.com/testcontainers/testcontainers-go v0.11.1
gopkg.in/yaml.v2 v2.4.0
Review comment:
thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org