You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bloodhound.apache.org by Dammina Sahabandu <dm...@gmail.com> on 2016/09/02 17:37:11 UTC
Re: Current status of project
Hi Ryan,
It seems like the latest Trac development release is Trac 1.3.1, and BH is
still using Trac 1.0.1. Even though you have suggested the migration even
before the release of Trac 1.2 I guess we are still not too late. So I
would be happy to do the migration if you can provide me some guidance.
Thanks,
Dammina.
On Thu, Jan 21, 2016 at 6:43 AM, Ryan J Ollos <rj...@apache.org> wrote:
> On Wed, Jan 20, 2016 at 1:08 PM, Gary <ga...@physics.org> wrote:
>
> > Hi everyone,
> >
> > For Kunaal's request to be viable we need to start getting some momentum
> > back into development. In addition, although I expect to be able to take
> > on all the responsibility for mentoring a student, I believe that we
> > would require a second mentor who is also on the PMC. As that suggests
> > such a person is required to ensure that a GSoC student is looked after
> > if the main mentor becomes unexpectedly unavailable. Of course, if the
> > second mentor wanted to be equally involved, that would be even better.
> >
> > So, if anyone is interested in helping out as a mentor, or has time to
> > make some progress with development, please let us know.
> >
> > Cheers,
> > Gary
>
>
> I don't foresee myself finding any time for Bloodhound given the
> commitments I have to other open source projects.
>
> For the Bloodhound project, an important step is to move to Trac 1.0.9, and
> the soon-to-be-released Trac 1.2. If anyone can find time to work on those
> migrations, I can lend advice since I'm very familiar with the changes that
> have been made in Trac.
>
> - Ryan
>
--
Dammina Sahabandu
SSE, AdroitLogic (pvt) Ltd.
Committer, Apache Software Foundation
AMIE (SL)
Bsc Eng Hons (Moratuwa)
+94716422775
Re: Current status of project
Posted by Dammina Sahabandu <dm...@gmail.com>.
Hi Ryan,
Thank you very much for making time to do the review. I will go through the
review comments and get back to you with updated change set for the second
round of review.
Regards,
Dammina
On Sun, Dec 4, 2016 at 4:01 PM, Ryan J Ollos <rj...@apache.org> wrote:
> On Tue, Oct 4, 2016 at 9:14 PM Dammina Sahabandu <dm...@gmail.com>
> wrote:
>
>> Hi Ryan,
>>
>> May I send a pull request so that you can review it easily and comment.
>>
>> Thanks,
>> Dammina
>>
>
> Very nice work! I'm very sorry for the long delay, and I really appreciate
> you doing this work because this has been on my TODO list for a long time.
>
> I commented on the changeset with some suggestions. Please make a new
> branch trac-1.0.13-integration.1 with the changes and resubmit for a
> second round of review.
>
> I plan to release Trac 1.0.14 this weekend, so we'll probably want to
> rebase the changes on that. I've made #660 the only open ticket for Release
> 9. After we integrate these changes we can make a new release.
> https://issues.apache.org/bloodhound/ticket/660
>
> - Ryan
>
>
--
Dammina Sahabandu
SSE, AdroitLogic (pvt) Ltd.
Committer, Apache Software Foundation
AMIE (SL)
Bsc Eng Hons (Moratuwa)
+94716422775
Re: Current status of project
Posted by Ryan J Ollos <rj...@apache.org>.
On Sun, Dec 11, 2016 at 12:26 PM Dammina Sahabandu <da...@apache.org>
wrote:
> Hi Ryan,
>
> Here are the test failures that I get for multiproduct module. It seems
> like the test cases test_regression_bh_539,
> test_regression_bh_539_concurrent and test_milestone_threads are failing
> for both of us. I will go through the failure tests and try to fix the
> issues.
>
>
> Anyhow I got these test results before applying the Trac update changes.
> After applying the changes there are many test failures in
> bloodhound_multiproduct, bloodhound_relations and bloodhound_search
> modules.
>
It would probably be a good idea at this point to rebase your branch of the
current trunk. At least we need to be sure we don't introduce new test
failures when committing the Trac 1.0.13 integration changes.
- Ryan
Re: Current status of project
Posted by Dammina Sahabandu <da...@apache.org>.
Hi Ryan,
Here are the test failures that I get for multiproduct module. It seems
like the test cases test_regression_bh_539,
test_regression_bh_539_concurrent and test_milestone_threads are failing
for both of us. I will go through the failure tests and try to fix the
issues.
Anyhow I got these test results before applying the Trac update changes.
After applying the changes there are many test failures in
bloodhound_multiproduct, bloodhound_relations and bloodhound_search modules.
======================================================================
FAIL: test_regression_bh_539 (tests.env.ProductEnvConfigTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/dammina/code/apache-bh/svn-trunk/bloodhound/bloodhound_multiproduct/tests/env.py",
line 754, in test_regression_bh_539
"Expected component enabled")
AssertionError: Expected component enabled
======================================================================
FAIL: test_regression_bh_539_concurrent (tests.env.ProductEnvConfigTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/dammina/code/apache-bh/svn-trunk/bloodhound/bloodhound_multiproduct/tests/env.py",
line 815, in test_regression_bh_539_concurrent
"Expected component enabled")
AssertionError: Expected component enabled
======================================================================
FAIL: test_milestone_completed_ok
(tests.admin.console.ProductTracAdminTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/dammina/code/apache-bh/svn-trunk/bloodhound/trac/trac/admin/tests/console.py",
line 1078, in test_milestone_completed_ok
self.assertEqual(self.expected_results[test_name], output)
File
"/Users/dammina/code/apache-bh/svn-trunk/bloodhound/trac/trac/admin/tests/console.py",
line 145, in assertEqual
output, diff()))
AssertionError: u'\nName Due
Completed\n------------------------------------\nmilestone2
2004-01-11 00:00:00\nmilestone1\nmilestone3\nmilestone4\n\n' != u'\nName
Due Completed\n------------------------------------\nmilestone2
2004-01-11 01:30:00\nmilestone1\nmilestone3\nmilestone4\n\n'
--- expected
+++ actual
@@ -1,7 +1,7 @@
Name Due Completed
------------------------------------
-milestone2 2004-01-11 00:00:00
+milestone2 2004-01-11 01:30:00
milestone1
milestone3
milestone4
======================================================================
FAIL: test_milestone_threads (tests.ticket.model.ProductMilestoneTestCase)
Ensure that in threaded (e.g. mod_wsgi) situations, we get
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/dammina/code/apache-bh/svn-trunk/bloodhound/bloodhound_multiproduct/tests/ticket/model.py",
line 218, in test_milestone_threads
self.assertEqual(r['from_t'], r['from_db'])
AssertionError: Items in the second set but not the first:
u'milestone_from_Thread-3'
----------------------------------------------------------------------
Ran 1288 tests in 343.166s
FAILED (failures=4, errors=1, skipped=22)
Thanks,
Dammina
On Sun, Dec 11, 2016 at 3:34 PM, Ryan J Ollos <rj...@apache.org> wrote:
> On Sun, Dec 11, 2016 at 1:03 AM Dammina Sahabandu <da...@apache.org>
> wrote:
>
> Hi Ryan,
>
> I made a few minor comments, nothing big, I think we are almost there.
>
>
> I have gone through your comments and committed the required changes to the
> same branch. Please note that the changes are squashed to their respective
> commits.
>
>
> I tried running the unit tests on bloodhound trunk. There are some things
> that need fixing. I will try to spend some time on that in the coming week.
>
>
> That would be really great :)
>
> Thanks,
> Dammina
>
>
> Thanks, looks good!
>
> I made some changes and the tests are executable now. Prior to the changes
> there were some import errors.
>
> To run the tests, cd into the package directory, and run "python setup.py
> test". Example:
>
> $ cd bloodhound_relations
> $ python setup.py test
>
> I saw some failures in bloodhound_multiproduct. Would you mind taking a
> look into the failures? We could start by checking whether you get the same
> errors as I do. I'll append the failures I saw to the end of this email.
>
> - Ryan
>
> ======================================================================
> ERROR: test_batch_ticket_insert_after_upgrade
> (multiproduct.tests.upgrade.EnvironmentUpgradeTestCase)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/upgrade.py",
> line 405, in test_batch_ticket_insert_after_upgrade
> db("""INSERT INTO ticket (summary) SELECT summary FROM tmp""")
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/bloodhound_multiproduct/multiproduct/dbcursor.py",
> line 122, in execute
> return self.connection.execute(query, params=params)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/trac/trac/db/util.py",
> line 121, in execute
> cursor.execute(query, params)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/bloodhound_multiproduct/multiproduct/dbcursor.py",
> line 87, in execute
> return super(BloodhoundIterableCursor,
> self).execute(translate_sql(self.env, sql), args=args)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/trac/trac/db/util.py",
> line 66, in execute
> return self.cursor.execute(sql)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/trac/trac/db/sqlite_backend.py",
> line 78, in execute
> result = PyFormatCursor.execute(self, *args)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/trac/trac/db/sqlite_backend.py",
> line 56, in execute
> args or [])
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/trac/trac/db/sqlite_backend.py",
> line 48, in _rollback_on_error
> return function(self, *args, **kwargs)
> OperationalError: 2 values for 3 columns
>
> ======================================================================
> ERROR: test_missing_product
> (multiproduct.tests.web_ui.ProductModuleTestCase)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/web_ui.py",
> line 255, in test_missing_product
> self._dispatch(req, self.global_env)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/web_ui.py",
> line 95, in _dispatch
> return RequestDispatcher(env).dispatch(req)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/trac/trac/web/main.py",
> line 224, in dispatch
> self._post_process_request(req, *resp)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/trac/trac/web/main.py",
> line 338, in _post_process_request
> resp = f.post_process_request(req, *resp)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/bloodhound_multiproduct/multiproduct/
> tests/admin/product_admin.py",
> line 83, in post_process_request
> raise exc
> TestAdminHandledException
>
> ======================================================================
> ERROR: test_product_edit (multiproduct.tests.web_ui.ProductModuleTestCase)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/web_ui.py",
> line 290, in test_product_edit
> self._dispatch(req, self.global_env)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/web_ui.py",
> line 95, in _dispatch
> return RequestDispatcher(env).dispatch(req)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/trac/trac/web/main.py",
> line 224, in dispatch
> self._post_process_request(req, *resp)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/trac/trac/web/main.py",
> line 338, in _post_process_request
> resp = f.post_process_request(req, *resp)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/bloodhound_multiproduct/multiproduct/
> tests/admin/product_admin.py",
> line 83, in post_process_request
> raise exc
> TestAdminHandledException
>
> ======================================================================
> ERROR: test_product_list (multiproduct.tests.web_ui.ProductModuleTestCase)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/web_ui.py",
> line 175, in test_product_list
> self._dispatch(req, self.global_env)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/web_ui.py",
> line 95, in _dispatch
> return RequestDispatcher(env).dispatch(req)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/trac/trac/web/main.py",
> line 224, in dispatch
> self._post_process_request(req, *resp)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/trac/trac/web/main.py",
> line 338, in _post_process_request
> resp = f.post_process_request(req, *resp)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/bloodhound_multiproduct/multiproduct/
> tests/admin/product_admin.py",
> line 83, in post_process_request
> raise exc
> TestAdminHandledException
>
> ======================================================================
> ERROR: test_product_new (multiproduct.tests.web_ui.ProductModuleTestCase)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/web_ui.py",
> line 197, in test_product_new
> self._dispatch(req, self.global_env)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/web_ui.py",
> line 95, in _dispatch
> return RequestDispatcher(env).dispatch(req)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/trac/trac/web/main.py",
> line 224, in dispatch
> self._post_process_request(req, *resp)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/trac/trac/web/main.py",
> line 338, in _post_process_request
> resp = f.post_process_request(req, *resp)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/bloodhound_multiproduct/multiproduct/
> tests/admin/product_admin.py",
> line 83, in post_process_request
> raise exc
> TestAdminHandledException
>
> ======================================================================
> ERROR: test_product_view (multiproduct.tests.web_ui.ProductModuleTestCase)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/web_ui.py",
> line 227, in test_product_view
> self._dispatch(req, self.global_env)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/web_ui.py",
> line 95, in _dispatch
> return RequestDispatcher(env).dispatch(req)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/trac/trac/web/main.py",
> line 224, in dispatch
> self._post_process_request(req, *resp)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/trac/trac/web/main.py",
> line 338, in _post_process_request
> resp = f.post_process_request(req, *resp)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/bloodhound_multiproduct/multiproduct/
> tests/admin/product_admin.py",
> line 83, in post_process_request
> raise exc
> TestAdminHandledException
>
> ======================================================================
> FAIL: test_regression_bh_539
> (multiproduct.tests.env.ProductEnvConfigTestCase)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/env.py",
> line 742, in test_regression_bh_539
> "Expected component disabled")
> AssertionError: Expected component disabled
>
> ======================================================================
> FAIL: test_regression_bh_539_concurrent
> (multiproduct.tests.env.ProductEnvConfigTestCase)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/env.py",
> line 791, in test_regression_bh_539_concurrent
> "Expected component disabled")
> AssertionError: Expected component disabled
>
> ======================================================================
> FAIL: test_help_ok
> (multiproduct.tests.admin.console.ProductTracAdminTestCase)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/trac/trac/admin/tests/console.py",
> line 162, in test_help_ok
> self.assertEqual(expected_results, output)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/trac/trac/admin/tests/console.py",
> line 145, in assertEqual
> output, diff()))
> AssertionError: u'trac-admin - The Trac Administration Console
> 1.0.1\n\nUsage: trac-admin </path/to/projenv> [command [subcommand] [option
> ...]]\n\nInvoking trac-admin without command starts interactive
> mode.\n\nhelp Show documentation\ninitenv
> Create and initialize a new environment\nattachment add Attach a
> file to a resource\nattachment export Export an attachment from a
> resource to a file or stdout\nattachment list List attachments of a
> resource\nattachment remove Remove an attachment from a
> resource\nchangeset added Notify trac about changesets added to a
> repository\nchangeset modified Notify trac about changesets modified in a
> repository\ncomponent add Add a new component\ncomponent chown
> Change component ownership\ncomponent list Show available
> components\ncomponent remove Remove/uninstall a component\ncomponent
> rename Rename a component\nconfig get Get the value of the
> given option in "trac.ini"\nconfig remove Remove the specified
> option from "trac.ini"\nconfig set Set the value for the given
> option in "trac.ini"\ndeploy Extract static resources from
> Trac and all plugins\nhotcopy Make a hot backup copy of an
> environment\nmilestone add Add milestone\nmilestone completed Set
> milestone complete date\nmilestone due Set milestone due
> date\nmilestone list Show milestones\nmilestone remove Remove
> milestone\nmilestone rename Rename milestone\npermission add Add
> a new permission rule\npermission export Export permission rules to a
> file or stdout as CSV\npermission import Import permission rules from a
> file or stdin as CSV\npermission list List permission
> rules\npermission remove Remove a permission rule\npriority add
> Add a priority value option\npriority change Change a priority
> value\npriority list Show possible ticket priorities\npriority order
> Move a priority value up or down in the list\npriority remove
> Remove a priority value\nrepository add Add a source
> repository\nrepository alias Create an alias for a
> repository\nrepository list List source repositories\nrepository
> remove Remove a source repository\nrepository resync Re-synchronize
> trac with repositories\nrepository set Set an attribute of a
> repository\nrepository sync Resume synchronization of
> repositories\nresolution add Add a resolution value
> option\nresolution change Change a resolution value\nresolution list
> Show possible ticket resolutions\nresolution order Move a resolution
> value up or down in the list\nresolution remove Remove a resolution
> value\nsession add Create a session for the given sid\nsession
> delete Delete the session of the specified sid\nsession list
> List the name and email for the given sids\nsession purge Purge all
> anonymous sessions older than the given age\nsession set Set the
> name or email attribute of the given sid\nseverity add Add a
> severity value option\nseverity change Change a severity
> value\nseverity list Show possible ticket severities\nseverity order
> Move a severity value up or down in the list\nseverity remove
> Remove a severity value\nticket remove Remove ticket\nticket_type
> add Add a ticket type\nticket_type change Change a ticket
> type\nticket_type list Show possible ticket types\nticket_type order
> Move a ticket type up or down in the list\nticket_type remove Remove a
> ticket type\nupgrade Upgrade database to current
> version\nversion add Add version\nversion list Show
> versions\nversion remove Remove version\nversion rename Rename
> version\nversion time Set version date\nwiki dump Export
> wiki pages to files named by title\nwiki export Export wiki page
> to file or stdout\nwiki import Import wiki page from file or
> stdin\nwiki list List wiki pages\nwiki load Import
> wiki pages from files\nwiki remove Remove wiki page\nwiki rename
> Rename wiki page\nwiki replace Replace the content of wiki
> pages from files (DANGEROUS!)\nwiki upgrade Upgrade default wiki
> pages to current version\n' != u'trac-admin - The Trac Administration
> Console 1.0.1\n\nUsage: trac-admin </path/to/projenv> [command [subcommand]
> [option ...]]\n\nInvoking trac-admin without command starts interactive
> mode.\n\nhelp Show documentation\ninitenv
> Create and initialize a new environment\nattachment add Attach a
> file to a resource\nattachment export Export an attachment from a
> resource to a file or stdout\nattachment list List attachments of a
> resource\nattachment remove Remove an attachment from a
> resource\nchangeset added Notify trac about changesets added to a
> repository\nchangeset modified Notify trac about changesets modified in a
> repository\ncomponent add Add a new component\ncomponent chown
> Change component ownership\ncomponent list Show available
> components\ncomponent remove Remove/uninstall a component\ncomponent
> rename Rename a component\nconfig get Get the value of the
> given option in "trac.ini"\nconfig remove Remove the specified
> option from "trac.ini"\nconfig set Set the value for the given
> option in "trac.ini"\ndeploy Extract static resources from
> Trac and all plugins\nfail Always fail\nhotcopy
> Make a hot backup copy of an environment\nmilestone add Add
> milestone\nmilestone completed Set milestone complete date\nmilestone due
> Set milestone due date\nmilestone list Show
> milestones\nmilestone remove Remove milestone\nmilestone rename
> Rename milestone\npermission add Add a new permission
> rule\npermission export Export permission rules to a file or stdout as
> CSV\npermission import Import permission rules from a file or stdin as
> CSV\npermission list List permission rules\npermission remove
> Remove a permission rule\npriority add Add a priority value
> option\npriority change Change a priority value\npriority list
> Show possible ticket priorities\npriority order Move a priority
> value up or down in the list\npriority remove Remove a priority
> value\nrepository add Add a source repository\nrepository alias
> Create an alias for a repository\nrepository list List source
> repositories\nrepository remove Remove a source repository\nrepository
> resync Re-synchronize trac with repositories\nrepository set Set
> an attribute of a repository\nrepository sync Resume synchronization
> of repositories\nresolution add Add a resolution value
> option\nresolution change Change a resolution value\nresolution list
> Show possible ticket resolutions\nresolution order Move a resolution
> value up or down in the list\nresolution remove Remove a resolution
> value\nsession add Create a session for the given sid\nsession
> delete Delete the session of the specified sid\nsession list
> List the name and email for the given sids\nsession purge Purge all
> anonymous sessions older than the given age\nsession set Set the
> name or email attribute of the given sid\nseverity add Add a
> severity value option\nseverity change Change a severity
> value\nseverity list Show possible ticket severities\nseverity order
> Move a severity value up or down in the list\nseverity remove
> Remove a severity value\nticket remove Remove ticket\nticket_type
> add Add a ticket type\nticket_type change Change a ticket
> type\nticket_type list Show possible ticket types\nticket_type order
> Move a ticket type up or down in the list\nticket_type remove Remove a
> ticket type\nupgrade Upgrade database to current
> version\nversion add Add version\nversion list Show
> versions\nversion remove Remove version\nversion rename Rename
> version\nversion time Set version date\nwiki dump Export
> wiki pages to files named by title\nwiki export Export wiki page
> to file or stdout\nwiki import Import wiki page from file or
> stdin\nwiki list List wiki pages\nwiki load Import
> wiki pages from files\nwiki remove Remove wiki page\nwiki rename
> Rename wiki page\nwiki replace Replace the content of wiki
> pages from files (DANGEROUS!)\nwiki upgrade Upgrade default wiki
> pages to current version\n'
> --- expected
> +++ actual
> @@ -21,6 +21,7 @@
> config remove Remove the specified option from "trac.ini"
> config set Set the value for the given option in "trac.ini"
> deploy Extract static resources from Trac and all plugins
> +fail Always fail
> hotcopy Make a hot backup copy of an environment
> milestone add Add milestone
> milestone completed Set milestone complete date
>
>
> ======================================================================
> FAIL: test_product_help_ok
> (multiproduct.tests.admin.console.ProductTracAdminTestCase)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/bloodhound_multiproduct/multiproduct/
> tests/admin/console.py",
> line 70, in test_product_help_ok
> self.assertEqual(0, rv)
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/trac/trac/admin/tests/console.py",
> line 129, in assertEqual
> return unittest.TestCase.assertEqual(self, expected_results, output)
> AssertionError: 0 != 2
>
> ======================================================================
> FAIL: test_milestone_threads
> (multiproduct.tests.ticket.model.ProductMilestoneTestCase)
> Ensure that in threaded (e.g. mod_wsgi) situations, we get
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/
> bloodhound-trunk/bloodhound_multiproduct/multiproduct/
> tests/ticket/model.py",
> line 218, in test_milestone_threads
> self.assertEqual(r['from_t'], r['from_db'])
> AssertionError: Items in the second set but not the first:
> u'milestone_from_Thread-3'
>
> ----------------------------------------------------------------------
> Ran 1288 tests in 642.382s
>
> FAILED (failures=5, errors=6, skipped=22)
>
>
> [EOM]
>
Re: Current status of project
Posted by Ryan J Ollos <rj...@apache.org>.
On Sun, Dec 11, 2016 at 1:03 AM Dammina Sahabandu <da...@apache.org>
wrote:
Hi Ryan,
I made a few minor comments, nothing big, I think we are almost there.
I have gone through your comments and committed the required changes to the
same branch. Please note that the changes are squashed to their respective
commits.
I tried running the unit tests on bloodhound trunk. There are some things
that need fixing. I will try to spend some time on that in the coming week.
That would be really great :)
Thanks,
Dammina
Thanks, looks good!
I made some changes and the tests are executable now. Prior to the changes
there were some import errors.
To run the tests, cd into the package directory, and run "python setup.py
test". Example:
$ cd bloodhound_relations
$ python setup.py test
I saw some failures in bloodhound_multiproduct. Would you mind taking a
look into the failures? We could start by checking whether you get the same
errors as I do. I'll append the failures I saw to the end of this email.
- Ryan
======================================================================
ERROR: test_batch_ticket_insert_after_upgrade
(multiproduct.tests.upgrade.EnvironmentUpgradeTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/upgrade.py",
line 405, in test_batch_ticket_insert_after_upgrade
db("""INSERT INTO ticket (summary) SELECT summary FROM tmp""")
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/bloodhound_multiproduct/multiproduct/dbcursor.py",
line 122, in execute
return self.connection.execute(query, params=params)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/trac/trac/db/util.py",
line 121, in execute
cursor.execute(query, params)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/bloodhound_multiproduct/multiproduct/dbcursor.py",
line 87, in execute
return super(BloodhoundIterableCursor,
self).execute(translate_sql(self.env, sql), args=args)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/trac/trac/db/util.py",
line 66, in execute
return self.cursor.execute(sql)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/trac/trac/db/sqlite_backend.py",
line 78, in execute
result = PyFormatCursor.execute(self, *args)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/trac/trac/db/sqlite_backend.py",
line 56, in execute
args or [])
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/trac/trac/db/sqlite_backend.py",
line 48, in _rollback_on_error
return function(self, *args, **kwargs)
OperationalError: 2 values for 3 columns
======================================================================
ERROR: test_missing_product
(multiproduct.tests.web_ui.ProductModuleTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/web_ui.py",
line 255, in test_missing_product
self._dispatch(req, self.global_env)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/web_ui.py",
line 95, in _dispatch
return RequestDispatcher(env).dispatch(req)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/trac/trac/web/main.py",
line 224, in dispatch
self._post_process_request(req, *resp)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/trac/trac/web/main.py",
line 338, in _post_process_request
resp = f.post_process_request(req, *resp)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/admin/product_admin.py",
line 83, in post_process_request
raise exc
TestAdminHandledException
======================================================================
ERROR: test_product_edit (multiproduct.tests.web_ui.ProductModuleTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/web_ui.py",
line 290, in test_product_edit
self._dispatch(req, self.global_env)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/web_ui.py",
line 95, in _dispatch
return RequestDispatcher(env).dispatch(req)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/trac/trac/web/main.py",
line 224, in dispatch
self._post_process_request(req, *resp)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/trac/trac/web/main.py",
line 338, in _post_process_request
resp = f.post_process_request(req, *resp)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/admin/product_admin.py",
line 83, in post_process_request
raise exc
TestAdminHandledException
======================================================================
ERROR: test_product_list (multiproduct.tests.web_ui.ProductModuleTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/web_ui.py",
line 175, in test_product_list
self._dispatch(req, self.global_env)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/web_ui.py",
line 95, in _dispatch
return RequestDispatcher(env).dispatch(req)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/trac/trac/web/main.py",
line 224, in dispatch
self._post_process_request(req, *resp)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/trac/trac/web/main.py",
line 338, in _post_process_request
resp = f.post_process_request(req, *resp)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/admin/product_admin.py",
line 83, in post_process_request
raise exc
TestAdminHandledException
======================================================================
ERROR: test_product_new (multiproduct.tests.web_ui.ProductModuleTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/web_ui.py",
line 197, in test_product_new
self._dispatch(req, self.global_env)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/web_ui.py",
line 95, in _dispatch
return RequestDispatcher(env).dispatch(req)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/trac/trac/web/main.py",
line 224, in dispatch
self._post_process_request(req, *resp)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/trac/trac/web/main.py",
line 338, in _post_process_request
resp = f.post_process_request(req, *resp)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/admin/product_admin.py",
line 83, in post_process_request
raise exc
TestAdminHandledException
======================================================================
ERROR: test_product_view (multiproduct.tests.web_ui.ProductModuleTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/web_ui.py",
line 227, in test_product_view
self._dispatch(req, self.global_env)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/web_ui.py",
line 95, in _dispatch
return RequestDispatcher(env).dispatch(req)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/trac/trac/web/main.py",
line 224, in dispatch
self._post_process_request(req, *resp)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/trac/trac/web/main.py",
line 338, in _post_process_request
resp = f.post_process_request(req, *resp)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/admin/product_admin.py",
line 83, in post_process_request
raise exc
TestAdminHandledException
======================================================================
FAIL: test_regression_bh_539
(multiproduct.tests.env.ProductEnvConfigTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/env.py",
line 742, in test_regression_bh_539
"Expected component disabled")
AssertionError: Expected component disabled
======================================================================
FAIL: test_regression_bh_539_concurrent
(multiproduct.tests.env.ProductEnvConfigTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/env.py",
line 791, in test_regression_bh_539_concurrent
"Expected component disabled")
AssertionError: Expected component disabled
======================================================================
FAIL: test_help_ok
(multiproduct.tests.admin.console.ProductTracAdminTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/trac/trac/admin/tests/console.py",
line 162, in test_help_ok
self.assertEqual(expected_results, output)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/trac/trac/admin/tests/console.py",
line 145, in assertEqual
output, diff()))
AssertionError: u'trac-admin - The Trac Administration Console
1.0.1\n\nUsage: trac-admin </path/to/projenv> [command [subcommand] [option
...]]\n\nInvoking trac-admin without command starts interactive
mode.\n\nhelp Show documentation\ninitenv
Create and initialize a new environment\nattachment add Attach a
file to a resource\nattachment export Export an attachment from a
resource to a file or stdout\nattachment list List attachments of a
resource\nattachment remove Remove an attachment from a
resource\nchangeset added Notify trac about changesets added to a
repository\nchangeset modified Notify trac about changesets modified in a
repository\ncomponent add Add a new component\ncomponent chown
Change component ownership\ncomponent list Show available
components\ncomponent remove Remove/uninstall a component\ncomponent
rename Rename a component\nconfig get Get the value of the
given option in "trac.ini"\nconfig remove Remove the specified
option from "trac.ini"\nconfig set Set the value for the given
option in "trac.ini"\ndeploy Extract static resources from
Trac and all plugins\nhotcopy Make a hot backup copy of an
environment\nmilestone add Add milestone\nmilestone completed Set
milestone complete date\nmilestone due Set milestone due
date\nmilestone list Show milestones\nmilestone remove Remove
milestone\nmilestone rename Rename milestone\npermission add Add
a new permission rule\npermission export Export permission rules to a
file or stdout as CSV\npermission import Import permission rules from a
file or stdin as CSV\npermission list List permission
rules\npermission remove Remove a permission rule\npriority add
Add a priority value option\npriority change Change a priority
value\npriority list Show possible ticket priorities\npriority order
Move a priority value up or down in the list\npriority remove
Remove a priority value\nrepository add Add a source
repository\nrepository alias Create an alias for a
repository\nrepository list List source repositories\nrepository
remove Remove a source repository\nrepository resync Re-synchronize
trac with repositories\nrepository set Set an attribute of a
repository\nrepository sync Resume synchronization of
repositories\nresolution add Add a resolution value
option\nresolution change Change a resolution value\nresolution list
Show possible ticket resolutions\nresolution order Move a resolution
value up or down in the list\nresolution remove Remove a resolution
value\nsession add Create a session for the given sid\nsession
delete Delete the session of the specified sid\nsession list
List the name and email for the given sids\nsession purge Purge all
anonymous sessions older than the given age\nsession set Set the
name or email attribute of the given sid\nseverity add Add a
severity value option\nseverity change Change a severity
value\nseverity list Show possible ticket severities\nseverity order
Move a severity value up or down in the list\nseverity remove
Remove a severity value\nticket remove Remove ticket\nticket_type
add Add a ticket type\nticket_type change Change a ticket
type\nticket_type list Show possible ticket types\nticket_type order
Move a ticket type up or down in the list\nticket_type remove Remove a
ticket type\nupgrade Upgrade database to current
version\nversion add Add version\nversion list Show
versions\nversion remove Remove version\nversion rename Rename
version\nversion time Set version date\nwiki dump Export
wiki pages to files named by title\nwiki export Export wiki page
to file or stdout\nwiki import Import wiki page from file or
stdin\nwiki list List wiki pages\nwiki load Import
wiki pages from files\nwiki remove Remove wiki page\nwiki rename
Rename wiki page\nwiki replace Replace the content of wiki
pages from files (DANGEROUS!)\nwiki upgrade Upgrade default wiki
pages to current version\n' != u'trac-admin - The Trac Administration
Console 1.0.1\n\nUsage: trac-admin </path/to/projenv> [command [subcommand]
[option ...]]\n\nInvoking trac-admin without command starts interactive
mode.\n\nhelp Show documentation\ninitenv
Create and initialize a new environment\nattachment add Attach a
file to a resource\nattachment export Export an attachment from a
resource to a file or stdout\nattachment list List attachments of a
resource\nattachment remove Remove an attachment from a
resource\nchangeset added Notify trac about changesets added to a
repository\nchangeset modified Notify trac about changesets modified in a
repository\ncomponent add Add a new component\ncomponent chown
Change component ownership\ncomponent list Show available
components\ncomponent remove Remove/uninstall a component\ncomponent
rename Rename a component\nconfig get Get the value of the
given option in "trac.ini"\nconfig remove Remove the specified
option from "trac.ini"\nconfig set Set the value for the given
option in "trac.ini"\ndeploy Extract static resources from
Trac and all plugins\nfail Always fail\nhotcopy
Make a hot backup copy of an environment\nmilestone add Add
milestone\nmilestone completed Set milestone complete date\nmilestone due
Set milestone due date\nmilestone list Show
milestones\nmilestone remove Remove milestone\nmilestone rename
Rename milestone\npermission add Add a new permission
rule\npermission export Export permission rules to a file or stdout as
CSV\npermission import Import permission rules from a file or stdin as
CSV\npermission list List permission rules\npermission remove
Remove a permission rule\npriority add Add a priority value
option\npriority change Change a priority value\npriority list
Show possible ticket priorities\npriority order Move a priority
value up or down in the list\npriority remove Remove a priority
value\nrepository add Add a source repository\nrepository alias
Create an alias for a repository\nrepository list List source
repositories\nrepository remove Remove a source repository\nrepository
resync Re-synchronize trac with repositories\nrepository set Set
an attribute of a repository\nrepository sync Resume synchronization
of repositories\nresolution add Add a resolution value
option\nresolution change Change a resolution value\nresolution list
Show possible ticket resolutions\nresolution order Move a resolution
value up or down in the list\nresolution remove Remove a resolution
value\nsession add Create a session for the given sid\nsession
delete Delete the session of the specified sid\nsession list
List the name and email for the given sids\nsession purge Purge all
anonymous sessions older than the given age\nsession set Set the
name or email attribute of the given sid\nseverity add Add a
severity value option\nseverity change Change a severity
value\nseverity list Show possible ticket severities\nseverity order
Move a severity value up or down in the list\nseverity remove
Remove a severity value\nticket remove Remove ticket\nticket_type
add Add a ticket type\nticket_type change Change a ticket
type\nticket_type list Show possible ticket types\nticket_type order
Move a ticket type up or down in the list\nticket_type remove Remove a
ticket type\nupgrade Upgrade database to current
version\nversion add Add version\nversion list Show
versions\nversion remove Remove version\nversion rename Rename
version\nversion time Set version date\nwiki dump Export
wiki pages to files named by title\nwiki export Export wiki page
to file or stdout\nwiki import Import wiki page from file or
stdin\nwiki list List wiki pages\nwiki load Import
wiki pages from files\nwiki remove Remove wiki page\nwiki rename
Rename wiki page\nwiki replace Replace the content of wiki
pages from files (DANGEROUS!)\nwiki upgrade Upgrade default wiki
pages to current version\n'
--- expected
+++ actual
@@ -21,6 +21,7 @@
config remove Remove the specified option from "trac.ini"
config set Set the value for the given option in "trac.ini"
deploy Extract static resources from Trac and all plugins
+fail Always fail
hotcopy Make a hot backup copy of an environment
milestone add Add milestone
milestone completed Set milestone complete date
======================================================================
FAIL: test_product_help_ok
(multiproduct.tests.admin.console.ProductTracAdminTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/admin/console.py",
line 70, in test_product_help_ok
self.assertEqual(0, rv)
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/trac/trac/admin/tests/console.py",
line 129, in assertEqual
return unittest.TestCase.assertEqual(self, expected_results, output)
AssertionError: 0 != 2
======================================================================
FAIL: test_milestone_threads
(multiproduct.tests.ticket.model.ProductMilestoneTestCase)
Ensure that in threaded (e.g. mod_wsgi) situations, we get
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/rjollos/Documents/Workspace/trac-dev/bloodhound/bloodhound-trunk/bloodhound_multiproduct/multiproduct/tests/ticket/model.py",
line 218, in test_milestone_threads
self.assertEqual(r['from_t'], r['from_db'])
AssertionError: Items in the second set but not the first:
u'milestone_from_Thread-3'
----------------------------------------------------------------------
Ran 1288 tests in 642.382s
FAILED (failures=5, errors=6, skipped=22)
[EOM]
Re: Current status of project
Posted by Dammina Sahabandu <da...@apache.org>.
Hi Ryan,
I made a few minor comments, nothing big, I think we are almost there.
>
I have gone through your comments and committed the required changes to the
same branch. Please note that the changes are squashed to their respective
commits.
> I tried running the unit tests on bloodhound trunk. There are some things
> that need fixing. I will try to spend some time on that in the coming week.
That would be really great :)
Thanks,
Dammina
Re: Current status of project
Posted by Ryan J Ollos <rj...@apache.org>.
Hi Dammina,
I made a few minor comments, nothing big, I think we are almost there.
I tried running the unit tests on bloodhound trunk. There are some things
that need fixing. I will try to spend some time on that in the coming week.
- Ryan
On Thu, Dec 8, 2016 at 10:20 PM Dammina Sahabandu <dm...@gmail.com>
wrote:
Hi Ryan,
I went through the review comments and did the required changes on a new
branch trac-1.0.13-integration.1 [1]. Please have a look at it and give me
a feedback whenever you are free.
I'll create the required tickets on Trac in-order to back port the relevant
changes soon.
[1] https://github.com/dammina/bloodhound/tree/trac-1.0.13-integration.1
Thanks,
Dammina
On Sun, Dec 4, 2016 at 4:01 PM, Ryan J Ollos <rj...@apache.org> wrote:
> On Tue, Oct 4, 2016 at 9:14 PM Dammina Sahabandu <dm...@gmail.com>
> wrote:
>
>> Hi Ryan,
>>
>> May I send a pull request so that you can review it easily and comment.
>>
>> Thanks,
>> Dammina
>>
>
> Very nice work! I'm very sorry for the long delay, and I really appreciate
> you doing this work because this has been on my TODO list for a long time.
>
> I commented on the changeset with some suggestions. Please make a new
> branch trac-1.0.13-integration.1 with the changes and resubmit for a
> second round of review.
>
> I plan to release Trac 1.0.14 this weekend, so we'll probably want to
> rebase the changes on that. I've made #660 the only open ticket for
Release
> 9. After we integrate these changes we can make a new release.
> https://issues.apache.org/bloodhound/ticket/660
>
> - Ryan
>
>
--
Dammina Sahabandu
SSE, AdroitLogic (pvt) Ltd.
Committer, Apache Software Foundation
AMIE (SL)
Bsc Eng Hons (Moratuwa)
+94716422775 <+94%2071%20642%202775>
Re: Current status of project
Posted by Dammina Sahabandu <dm...@gmail.com>.
Hi Ryan,
I went through the review comments and did the required changes on a new
branch trac-1.0.13-integration.1 [1]. Please have a look at it and give me
a feedback whenever you are free.
I'll create the required tickets on Trac in-order to back port the relevant
changes soon.
[1] https://github.com/dammina/bloodhound/tree/trac-1.0.13-integration.1
Thanks,
Dammina
On Sun, Dec 4, 2016 at 4:01 PM, Ryan J Ollos <rj...@apache.org> wrote:
> On Tue, Oct 4, 2016 at 9:14 PM Dammina Sahabandu <dm...@gmail.com>
> wrote:
>
>> Hi Ryan,
>>
>> May I send a pull request so that you can review it easily and comment.
>>
>> Thanks,
>> Dammina
>>
>
> Very nice work! I'm very sorry for the long delay, and I really appreciate
> you doing this work because this has been on my TODO list for a long time.
>
> I commented on the changeset with some suggestions. Please make a new
> branch trac-1.0.13-integration.1 with the changes and resubmit for a
> second round of review.
>
> I plan to release Trac 1.0.14 this weekend, so we'll probably want to
> rebase the changes on that. I've made #660 the only open ticket for Release
> 9. After we integrate these changes we can make a new release.
> https://issues.apache.org/bloodhound/ticket/660
>
> - Ryan
>
>
--
Dammina Sahabandu
SSE, AdroitLogic (pvt) Ltd.
Committer, Apache Software Foundation
AMIE (SL)
Bsc Eng Hons (Moratuwa)
+94716422775
Re: Current status of project
Posted by Dammina Sahabandu <dm...@gmail.com>.
> For Release 10 we can integrate the changes from Trac 1.2.
> https://issues.apache.org/bloodhound/ticket/779
>
+1
--
Dammina Sahabandu
SSE, AdroitLogic (pvt) Ltd.
Committer, Apache Software Foundation
AMIE (SL)
Bsc Eng Hons (Moratuwa)
+94716422775 <071%20642%202775>
Re: Current status of project
Posted by Ryan Ollos <ry...@gmail.com>.
On Sun, Dec 4, 2016 at 2:31 AM Ryan J Ollos <rj...@apache.org> wrote:
> On Tue, Oct 4, 2016 at 9:14 PM Dammina Sahabandu <dm...@gmail.com>
> wrote:
>
> Hi Ryan,
>
> May I send a pull request so that you can review it easily and comment.
>
> Thanks,
> Dammina
>
>
> Very nice work! I'm very sorry for the long delay, and I really appreciate
> you doing this work because this has been on my TODO list for a long time.
>
> I commented on the changeset with some suggestions. Please make a new
> branch trac-1.0.13-integration.1 with the changes and resubmit for a second
> round of review.
>
> I plan to release Trac 1.0.14 this weekend, so we'll probably want to
> rebase the changes on that. I've made #660 the only open ticket for Release
> 9. After we integrate these changes we can make a new release.
> https://issues.apache.org/bloodhound/ticket/660
>
> - Ryan
>
For Release 10 we can integrate the changes from Trac 1.2.
https://issues.apache.org/bloodhound/ticket/779
- Ryan
Re: Current status of project
Posted by Ryan J Ollos <rj...@apache.org>.
On Tue, Oct 4, 2016 at 9:14 PM Dammina Sahabandu <dm...@gmail.com>
wrote:
> Hi Ryan,
>
> May I send a pull request so that you can review it easily and comment.
>
> Thanks,
> Dammina
>
Very nice work! I'm very sorry for the long delay, and I really appreciate
you doing this work because this has been on my TODO list for a long time.
I commented on the changeset with some suggestions. Please make a new
branch trac-1.0.13-integration.1 with the changes and resubmit for a second
round of review.
I plan to release Trac 1.0.14 this weekend, so we'll probably want to
rebase the changes on that. I've made #660 the only open ticket for Release
9. After we integrate these changes we can make a new release.
https://issues.apache.org/bloodhound/ticket/660
- Ryan
Re: Current status of project
Posted by Dammina Sahabandu <dm...@gmail.com>.
Hi Ryan,
May I send a pull request so that you can review it easily and comment.
Thanks,
Dammina
On Tue, Sep 20, 2016 at 11:50 AM, Dammina Sahabandu <da...@apache.org>
wrote:
> Hi Ryan,
>
> Just wanted to know whether you found any free time to review this. I know
> you are very busy at the moment, so I just wanted to do a friendly reminder
> ;)
>
> Hi All,
>
> Please note that all of you are welcome and it would be really great if
> any of you find some free time to review this change set and give me a
> feedback.
>
> Thanks,
> Dammina
>
> On Tue, Sep 13, 2016 at 7:16 AM, Ryan J Ollos <rj...@apache.org> wrote:
>
>> On Mon, Sep 12, 2016 at 1:02 PM Dammina Sahabandu <da...@apache.org>
>> wrote:
>>
>> > Hi Ryan,
>> >
>> > I have updated the trac module and applied the bloodhound specific
>> patches
>> > on it. Then after doing some minor modifications to the code I was able
>> to
>> > get Bloodhound up and running without issues. However there are some
>> test
>> > cases that are keep failing. So at the moment I'm working on getting
>> them
>> > fixed. Anyhow it would be really great if you can review the change set
>> and
>> > give me a feedback if you get any free time.
>> >
>> > [1] https://github.com/dammina/bloodhound
>> >
>> > Thanks,
>> > Dammina
>> >
>>
>> I'll take a look by end of the coming weekend and give some feedback.
>>
>> Thanks,
>> - Ryan
>>
>
>
--
Dammina Sahabandu
SSE, AdroitLogic (pvt) Ltd.
Committer, Apache Software Foundation
AMIE (SL)
Bsc Eng Hons (Moratuwa)
+94716422775
Re: Current status of project
Posted by Dammina Sahabandu <dm...@gmail.com>.
Hi Ryan,
I really appreciate it. Thank you very much :)
regard,
Dammina
On Mon, Oct 10, 2016 at 11:16 PM, Ryan J Ollos <rj...@apache.org> wrote:
> On Mon, Sep 19, 2016 at 11:20 PM Dammina Sahabandu <da...@apache.org>
> wrote:
>
> > Hi Ryan,
> >
> >
> >
> > Just wanted to know whether you found any free time to review this. I
> know
> >
> > you are very busy at the moment, so I just wanted to do a friendly
> reminder
> >
> > ;)
> >
>
> I'll try to find time to review soon. Anyone else should feel welcome to
> jump in and review the changes as well.
>
> - Ryan
>
--
Dammina Sahabandu
SSE, AdroitLogic (pvt) Ltd.
Committer, Apache Software Foundation
AMIE (SL)
Bsc Eng Hons (Moratuwa)
+94716422775
Re: Current status of project
Posted by Ryan J Ollos <rj...@apache.org>.
On Mon, Sep 19, 2016 at 11:20 PM Dammina Sahabandu <da...@apache.org>
wrote:
> Hi Ryan,
>
>
>
> Just wanted to know whether you found any free time to review this. I know
>
> you are very busy at the moment, so I just wanted to do a friendly reminder
>
> ;)
>
I'll try to find time to review soon. Anyone else should feel welcome to
jump in and review the changes as well.
- Ryan
Re: Current status of project
Posted by Dammina Sahabandu <da...@apache.org>.
Hi Ryan,
Just wanted to know whether you found any free time to review this. I know
you are very busy at the moment, so I just wanted to do a friendly reminder
;)
Hi All,
Please note that all of you are welcome and it would be really great if any
of you find some free time to review this change set and give me a
feedback.
Thanks,
Dammina
On Tue, Sep 13, 2016 at 7:16 AM, Ryan J Ollos <rj...@apache.org> wrote:
> On Mon, Sep 12, 2016 at 1:02 PM Dammina Sahabandu <da...@apache.org>
> wrote:
>
> > Hi Ryan,
> >
> > I have updated the trac module and applied the bloodhound specific
> patches
> > on it. Then after doing some minor modifications to the code I was able
> to
> > get Bloodhound up and running without issues. However there are some test
> > cases that are keep failing. So at the moment I'm working on getting them
> > fixed. Anyhow it would be really great if you can review the change set
> and
> > give me a feedback if you get any free time.
> >
> > [1] https://github.com/dammina/bloodhound
> >
> > Thanks,
> > Dammina
> >
>
> I'll take a look by end of the coming weekend and give some feedback.
>
> Thanks,
> - Ryan
>
Re: Current status of project
Posted by Ryan J Ollos <rj...@apache.org>.
On Mon, Sep 12, 2016 at 1:02 PM Dammina Sahabandu <da...@apache.org>
wrote:
> Hi Ryan,
>
> I have updated the trac module and applied the bloodhound specific patches
> on it. Then after doing some minor modifications to the code I was able to
> get Bloodhound up and running without issues. However there are some test
> cases that are keep failing. So at the moment I'm working on getting them
> fixed. Anyhow it would be really great if you can review the change set and
> give me a feedback if you get any free time.
>
> [1] https://github.com/dammina/bloodhound
>
> Thanks,
> Dammina
>
I'll take a look by end of the coming weekend and give some feedback.
Thanks,
- Ryan
Re: Current status of project
Posted by Gary <ga...@physics.org>.
On 13/09/16 00:34, Ryan J Ollos wrote:
> On Mon, Sep 12, 2016 at 4:09 PM Gary <ga...@physics.org> wrote:
>
>> I am a bit confused over the github mirror for bloodhound as it appears
>> to lack some of the organisation provided by the ASF hosted svn repo.
>> Specifically I am wondering where the vendor branches for trac are. Am I
>> missing something?
>>
>> Cheers,
>> Gary
>>
> My experience is that the repository layout must be defined in the
> mirroring configuration, so the configuration is probably a generic trunk,
> branches, tags layout that hasn't accounted for "site" and "vendor". I
> imagine we could contact INFRA about this, or move vendor to
> branches/vendor.
>
> - Ryan
>
Interesting. I'd probably keep the vendor branches separate myself. The
vendor branches are one way to keep some clarity about a patched
external library. You can see
http://svnbook.red-bean.com/en/1.8/svn.advanced.vendorbr.html for more
details of that.
In the github forking world there may be other means that are preferred
for having a patched version of a library, possibly keeping a fork of
the project as part of the organisation. I don't know if that is normal
for the apache github organisation.
Cheers,
Gary
Re: Current status of project
Posted by Ryan J Ollos <rj...@apache.org>.
On Mon, Sep 12, 2016 at 4:09 PM Gary <ga...@physics.org> wrote:
> I am a bit confused over the github mirror for bloodhound as it appears
> to lack some of the organisation provided by the ASF hosted svn repo.
> Specifically I am wondering where the vendor branches for trac are. Am I
> missing something?
>
> Cheers,
> Gary
>
My experience is that the repository layout must be defined in the
mirroring configuration, so the configuration is probably a generic trunk,
branches, tags layout that hasn't accounted for "site" and "vendor". I
imagine we could contact INFRA about this, or move vendor to
branches/vendor.
- Ryan
Re: Current status of project
Posted by Gary <ga...@physics.org>.
On 12/09/16 21:02, Dammina Sahabandu wrote:
> Hi Ryan,
>
> I have updated the trac module and applied the bloodhound specific patches
> on it. Then after doing some minor modifications to the code I was able to
> get Bloodhound up and running without issues. However there are some test
> cases that are keep failing. So at the moment I'm working on getting them
> fixed. Anyhow it would be really great if you can review the change set and
> give me a feedback if you get any free time.
>
> [1] https://github.com/dammina/bloodhound
>
> Thanks,
> Dammina
>
> On Sun, Sep 4, 2016 at 1:10 PM, Ryan J Ollos <rj...@apache.org> wrote:
>
>> On Sat, Sep 3, 2016 at 9:45 PM Dammina Sahabandu <da...@apache.org>
>> wrote:
>>
>>> Hi Ryan,
>>>
>>> Thank you very much for the information and the guide. The last version
>>> merged into Bloodhound was Trac 1.0.1 in 2013. So I guess it will be easier
>>> for us to first move into Trac 1.0.12 and then to Trac 1.2. I have started
>>> applying the generated custom set of patches to the new sub-repo (Trac
>>> 1.0.12). After I have completed the process I will notify you and if time
>>> permits it would be really great if you can review the change set.
>>>
>> Feel free to share work in progress as well. Since you asked about a
>> branch in the repository, do you plan to work from SVN? You should use what
>> you are comfortable with, but for this use-case, I think the patch
>> management will be easier in Git, assuming you are comfortable with the
>> tool. I like SVN, but in cases like this I find the patch management to be
>> easier in DVCS that supports rebasing.
>>
>> Here is the Git mirror, in case you weren't aware of the location.
>> https://github.com/apache/bloodhound/tree/trunk
>>
>> - Ryan
>>
>>
I am a bit confused over the github mirror for bloodhound as it appears
to lack some of the organisation provided by the ASF hosted svn repo.
Specifically I am wondering where the vendor branches for trac are. Am I
missing something?
Cheers,
Gary
Re: Current status of project
Posted by Dammina Sahabandu <da...@apache.org>.
Hi Ryan,
I have updated the trac module and applied the bloodhound specific patches
on it. Then after doing some minor modifications to the code I was able to
get Bloodhound up and running without issues. However there are some test
cases that are keep failing. So at the moment I'm working on getting them
fixed. Anyhow it would be really great if you can review the change set and
give me a feedback if you get any free time.
[1] https://github.com/dammina/bloodhound
Thanks,
Dammina
On Sun, Sep 4, 2016 at 1:10 PM, Ryan J Ollos <rj...@apache.org> wrote:
> On Sat, Sep 3, 2016 at 9:45 PM Dammina Sahabandu <da...@apache.org>
> wrote:
>
>> Hi Ryan,
>>
>> Thank you very much for the information and the guide. The last version
>> merged into Bloodhound was Trac 1.0.1 in 2013. So I guess it will be easier
>> for us to first move into Trac 1.0.12 and then to Trac 1.2. I have started
>> applying the generated custom set of patches to the new sub-repo (Trac
>> 1.0.12). After I have completed the process I will notify you and if time
>> permits it would be really great if you can review the change set.
>>
>
> Feel free to share work in progress as well. Since you asked about a
> branch in the repository, do you plan to work from SVN? You should use what
> you are comfortable with, but for this use-case, I think the patch
> management will be easier in Git, assuming you are comfortable with the
> tool. I like SVN, but in cases like this I find the patch management to be
> easier in DVCS that supports rebasing.
>
> Here is the Git mirror, in case you weren't aware of the location.
> https://github.com/apache/bloodhound/tree/trunk
>
> - Ryan
>
>
Re: Current status of project
Posted by Ryan J Ollos <rj...@apache.org>.
On Sat, Sep 3, 2016 at 9:45 PM Dammina Sahabandu <da...@apache.org> wrote:
> Hi Ryan,
>
> Thank you very much for the information and the guide. The last version
> merged into Bloodhound was Trac 1.0.1 in 2013. So I guess it will be easier
> for us to first move into Trac 1.0.12 and then to Trac 1.2. I have started
> applying the generated custom set of patches to the new sub-repo (Trac
> 1.0.12). After I have completed the process I will notify you and if time
> permits it would be really great if you can review the change set.
>
Feel free to share work in progress as well. Since you asked about a branch
in the repository, do you plan to work from SVN? You should use what you
are comfortable with, but for this use-case, I think the patch management
will be easier in Git, assuming you are comfortable with the tool. I like
SVN, but in cases like this I find the patch management to be easier in
DVCS that supports rebasing.
Here is the Git mirror, in case you weren't aware of the location.
https://github.com/apache/bloodhound/tree/trunk
- Ryan
Re: Current status of project
Posted by Dammina Sahabandu <da...@apache.org>.
Hi Ryan,
Thank you very much for the information and the guide. The last version
merged into Bloodhound was Trac 1.0.1 in 2013. So I guess it will be easier
for us to first move into Trac 1.0.12 and then to Trac 1.2. I have started
applying the generated custom set of patches to the new sub-repo (Trac
1.0.12). After I have completed the process I will notify you and if time
permits it would be really great if you can review the change set.
Hi Gary,
Is it possible for you to create a branch in Bloodhound for me to work on
this Trac migration?
Thanks,
Dammina
On Sat, Sep 3, 2016 at 4:51 AM, Ryan Ollos <ry...@gmail.com> wrote:
> Hi Dammina,
>
> Bloodhound has a copy of Trac with several patches applied. I don't recall
> the last version of Trac that was merged into Bloodhound, but I think it
> was at least 1.0.2.
>
> You'll need to grab a new copy of Trac and merge that into the Bloodhound
> codebase. Alternatively, you could rebase it by adding the new version of
> Trac and applying all the patches on top of it.
>
> To make things easier in the future you can propose changes to Trac that
> would make some of the patches unnecessary. I did some work on that when I
> merged a version of Trac into Bloodhound.
>
> Trac 1.2 should be released soon, so I'd make that the next target for
> merging into Bloodhound, although you could merge in Trac 1.0.12 first if
> you'd prefer to try for incremental progress. Trac 1.3.x releases are the
> development snapshots leading to the next major release (1), Trac 1.4. Trac
> will replace the Genshi with Jinja2 templating engine, so Bloodhound would
> need to adapt all it's templates to work with Trac 1.4.
>
> I'd approach the problem like this:
> * Fork Bloodhound on GitHub
> * Review the change history of the copy of Trac in Bloodhound and create a
> logical set of patches
> * Replace the copy of Trac in Bloodhound with Trac 1.2
> * Apply each of the patches to the new copy
> * Review change history of the templates in Trac and apply the changes to
> the Bloodhound templates
>
> I could work with you to review the patches and see what might be
> backported to Trac. I don't anticipate doing any additional work directly
> in the Bloodhound codebase, but I'm happy to work with you guys to make
> your integration with Trac work as well as possible. I may also backport
> some of the Bloodhound plugins, such as ticket references, to Trac.
>
> - Ryan
>
> (1) https://trac.edgewall.org/wiki/RoadMap#MilestoneCategories
>
>
> On Fri, Sep 2, 2016 at 10:37 AM Dammina Sahabandu <dm...@gmail.com>
> wrote:
>
> > Hi Ryan,
> >
> > It seems like the latest Trac development release is Trac 1.3.1, and BH
> is
> > still using Trac 1.0.1. Even though you have suggested the migration even
> > before the release of Trac 1.2 I guess we are still not too late. So I
> > would be happy to do the migration if you can provide me some guidance.
> >
> > Thanks,
> > Dammina.
> >
> >
> > On Thu, Jan 21, 2016 at 6:43 AM, Ryan J Ollos <rj...@apache.org>
> wrote:
> >
> > > On Wed, Jan 20, 2016 at 1:08 PM, Gary <ga...@physics.org> wrote:
> > >
> > > > Hi everyone,
> > > >
> > > > For Kunaal's request to be viable we need to start getting some
> > momentum
> > > > back into development. In addition, although I expect to be able to
> > take
> > > > on all the responsibility for mentoring a student, I believe that we
> > > > would require a second mentor who is also on the PMC. As that
> suggests
> > > > such a person is required to ensure that a GSoC student is looked
> after
> > > > if the main mentor becomes unexpectedly unavailable. Of course, if
> the
> > > > second mentor wanted to be equally involved, that would be even
> better.
> > > >
> > > > So, if anyone is interested in helping out as a mentor, or has time
> to
> > > > make some progress with development, please let us know.
> > > >
> > > > Cheers,
> > > > Gary
> > >
> > >
> > > I don't foresee myself finding any time for Bloodhound given the
> > > commitments I have to other open source projects.
> > >
> > > For the Bloodhound project, an important step is to move to Trac 1.0.9,
> > and
> > > the soon-to-be-released Trac 1.2. If anyone can find time to work on
> > those
> > > migrations, I can lend advice since I'm very familiar with the changes
> > that
> > > have been made in Trac.
> > >
> > > - Ryan
> > >
> >
> >
> >
> > --
> > Dammina Sahabandu
> > SSE, AdroitLogic (pvt) Ltd.
> > Committer, Apache Software Foundation
> > AMIE (SL)
> > Bsc Eng Hons (Moratuwa)
> > +94716422775
> >
>
Re: Current status of project
Posted by Ryan Ollos <ry...@gmail.com>.
Hi Dammina,
Bloodhound has a copy of Trac with several patches applied. I don't recall
the last version of Trac that was merged into Bloodhound, but I think it
was at least 1.0.2.
You'll need to grab a new copy of Trac and merge that into the Bloodhound
codebase. Alternatively, you could rebase it by adding the new version of
Trac and applying all the patches on top of it.
To make things easier in the future you can propose changes to Trac that
would make some of the patches unnecessary. I did some work on that when I
merged a version of Trac into Bloodhound.
Trac 1.2 should be released soon, so I'd make that the next target for
merging into Bloodhound, although you could merge in Trac 1.0.12 first if
you'd prefer to try for incremental progress. Trac 1.3.x releases are the
development snapshots leading to the next major release (1), Trac 1.4. Trac
will replace the Genshi with Jinja2 templating engine, so Bloodhound would
need to adapt all it's templates to work with Trac 1.4.
I'd approach the problem like this:
* Fork Bloodhound on GitHub
* Review the change history of the copy of Trac in Bloodhound and create a
logical set of patches
* Replace the copy of Trac in Bloodhound with Trac 1.2
* Apply each of the patches to the new copy
* Review change history of the templates in Trac and apply the changes to
the Bloodhound templates
I could work with you to review the patches and see what might be
backported to Trac. I don't anticipate doing any additional work directly
in the Bloodhound codebase, but I'm happy to work with you guys to make
your integration with Trac work as well as possible. I may also backport
some of the Bloodhound plugins, such as ticket references, to Trac.
- Ryan
(1) https://trac.edgewall.org/wiki/RoadMap#MilestoneCategories
On Fri, Sep 2, 2016 at 10:37 AM Dammina Sahabandu <dm...@gmail.com>
wrote:
> Hi Ryan,
>
> It seems like the latest Trac development release is Trac 1.3.1, and BH is
> still using Trac 1.0.1. Even though you have suggested the migration even
> before the release of Trac 1.2 I guess we are still not too late. So I
> would be happy to do the migration if you can provide me some guidance.
>
> Thanks,
> Dammina.
>
>
> On Thu, Jan 21, 2016 at 6:43 AM, Ryan J Ollos <rj...@apache.org> wrote:
>
> > On Wed, Jan 20, 2016 at 1:08 PM, Gary <ga...@physics.org> wrote:
> >
> > > Hi everyone,
> > >
> > > For Kunaal's request to be viable we need to start getting some
> momentum
> > > back into development. In addition, although I expect to be able to
> take
> > > on all the responsibility for mentoring a student, I believe that we
> > > would require a second mentor who is also on the PMC. As that suggests
> > > such a person is required to ensure that a GSoC student is looked after
> > > if the main mentor becomes unexpectedly unavailable. Of course, if the
> > > second mentor wanted to be equally involved, that would be even better.
> > >
> > > So, if anyone is interested in helping out as a mentor, or has time to
> > > make some progress with development, please let us know.
> > >
> > > Cheers,
> > > Gary
> >
> >
> > I don't foresee myself finding any time for Bloodhound given the
> > commitments I have to other open source projects.
> >
> > For the Bloodhound project, an important step is to move to Trac 1.0.9,
> and
> > the soon-to-be-released Trac 1.2. If anyone can find time to work on
> those
> > migrations, I can lend advice since I'm very familiar with the changes
> that
> > have been made in Trac.
> >
> > - Ryan
> >
>
>
>
> --
> Dammina Sahabandu
> SSE, AdroitLogic (pvt) Ltd.
> Committer, Apache Software Foundation
> AMIE (SL)
> Bsc Eng Hons (Moratuwa)
> +94716422775
>