You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jordan Birdsell (Code Review)" <ge...@cloudera.org> on 2016/10/29 20:34:08 UTC
[kudu-CR] [python] - Expand KuduError capabilities
Jordan Birdsell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4885
Change subject: [python] - Expand KuduError capabilities
......................................................................
[python] - Expand KuduError capabilities
The Python client currently doesn't support the full error reporting
capabilities of the KuduError class. This patch exposes most of them
and includes tests.
Change-Id: I4947a663ae09ec2fc9580876521252670d081aa1
---
M python/kudu/client.pyx
M python/kudu/tests/test_client.py
2 files changed, 46 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/4885/1
--
To view, visit http://gerrit.cloudera.org:8080/4885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4947a663ae09ec2fc9580876521252670d081aa1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
[kudu-CR] [python] - Expand KuduError capabilities
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: [python] - Expand KuduError capabilities
......................................................................
[python] - Expand KuduError capabilities
The Python client currently doesn't support the full error reporting
capabilities of the KuduError class. This patch exposes most of them
and includes tests.
Change-Id: I4947a663ae09ec2fc9580876521252670d081aa1
Reviewed-on: http://gerrit.cloudera.org:8080/4885
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
Tested-by: Kudu Jenkins
---
M python/kudu/client.pyx
M python/kudu/tests/test_client.py
2 files changed, 48 insertions(+), 1 deletion(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4947a663ae09ec2fc9580876521252670d081aa1
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [python] - Expand KuduError capabilities
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: [python] - Expand KuduError capabilities
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4947a663ae09ec2fc9580876521252670d081aa1
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [python] - Expand KuduError capabilities
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.
Change subject: [python] - Expand KuduError capabilities
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4885/1/python/kudu/tests/test_client.py
File python/kudu/tests/test_client.py:
Line 212: # This test passes because we currently always return
> Maybe add a note that this is passing because we always return true at the
Done
--
To view, visit http://gerrit.cloudera.org:8080/4885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4947a663ae09ec2fc9580876521252670d081aa1
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] [python] - Expand KuduError capabilities
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4885
to look at the new patch set (#2).
Change subject: [python] - Expand KuduError capabilities
......................................................................
[python] - Expand KuduError capabilities
The Python client currently doesn't support the full error reporting
capabilities of the KuduError class. This patch exposes most of them
and includes tests.
Change-Id: I4947a663ae09ec2fc9580876521252670d081aa1
---
M python/kudu/client.pyx
M python/kudu/tests/test_client.py
2 files changed, 48 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/4885/2
--
To view, visit http://gerrit.cloudera.org:8080/4885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4947a663ae09ec2fc9580876521252670d081aa1
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [python] - Expand KuduError capabilities
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: [python] - Expand KuduError capabilities
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4885/1/python/kudu/tests/test_client.py
File python/kudu/tests/test_client.py:
Line 212: self.assertTrue(error.was_possibly_successful())
Maybe add a note that this is passing because we always return true at the moment?
--
To view, visit http://gerrit.cloudera.org:8080/4885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4947a663ae09ec2fc9580876521252670d081aa1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes