You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/11/08 20:44:54 UTC

[Impala-ASF-CR] IMPALA-9128: part 2: dump traces for slow RPCs

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14669


Change subject: IMPALA-9128: part 2: dump traces for slow RPCs
......................................................................

IMPALA-9128: part 2: dump traces for slow RPCs

This adds trace events for data stream RPCs and
dumps them when they take longer than
--impala_slow_rpc_threshold_ms.

I needed to modify the KRPC code to do this because it
currently only dumps traces for RPCs with deadlines.
I plan to add some version of this upstream in Kudu
so that we don't diverge our KRPC implementation.

Change-Id: Ia53da1ffe2d07906d44cef6c7d0a80ef130c7724
---
M be/src/kudu/rpc/rpcz_store.cc
M be/src/runtime/krpc-data-stream-mgr.cc
M be/src/runtime/krpc-data-stream-recvr.cc
M be/src/runtime/krpc-data-stream-sender.cc
4 files changed, 36 insertions(+), 12 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/14669/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia53da1ffe2d07906d44cef6c7d0a80ef130c7724
Gerrit-Change-Number: 14669
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9128: part 2: dump traces for slow RPCs

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/14669 )

Change subject: IMPALA-9128: part 2: dump traces for slow RPCs
......................................................................


Abandoned

Didn't mean to publish
-- 
To view, visit http://gerrit.cloudera.org:8080/14669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia53da1ffe2d07906d44cef6c7d0a80ef130c7724
Gerrit-Change-Number: 14669
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>