You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Anthony Baker <ab...@apache.org> on 2016/08/24 17:36:40 UTC
Review Request 51380: GEODE-1809: Refactor GemFireVersion
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51380/
-----------------------------------------------------------
Review request for geode, Dick Cavender and Jens Deppe.
Repository: geode
Description
-------
Clean up dead / broken / unused code and reduce the visible
API methods. Store the version info as a Map to allow it to be
extended more easily.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/StartupMessage.java 82f5c88c864fa7a03a7d33ee7cbcb1a08334667c
geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireVersion.java baf03b1d54bf0ac82024af63eb00d42331f6e8fb
geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java e52950f69a48d0cb83dedb4e9ad42c287a1c49a9
geode-core/src/test/java/com/gemstone/gemfire/internal/GemFireVersionJUnitTest.java fc4ab1b3c1c46bcb5c8f0e66f64c926fc37db789
geode-core/src/test/java/com/gemstone/gemfire/internal/VersionJUnitTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/51380/diff/
Testing
-------
Thanks,
Anthony Baker
Re: Review Request 51380: GEODE-1809: Refactor GemFireVersion
Posted by Dick Cavender <dc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51380/#review146728
-----------------------------------------------------------
Ship it!
Built this on open side fine and manually inspected the contents from Anthony's closed side build.
- Dick Cavender
On Aug. 24, 2016, 5:36 p.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51380/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2016, 5:36 p.m.)
>
>
> Review request for geode, Dick Cavender and Jens Deppe.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Clean up dead / broken / unused code and reduce the visible
> API methods. Store the version info as a Map to allow it to be
> extended more easily.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/StartupMessage.java 82f5c88c864fa7a03a7d33ee7cbcb1a08334667c
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireVersion.java baf03b1d54bf0ac82024af63eb00d42331f6e8fb
> geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java e52950f69a48d0cb83dedb4e9ad42c287a1c49a9
> geode-core/src/test/java/com/gemstone/gemfire/internal/GemFireVersionJUnitTest.java fc4ab1b3c1c46bcb5c8f0e66f64c926fc37db789
> geode-core/src/test/java/com/gemstone/gemfire/internal/VersionJUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/51380/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 51380: GEODE-1809: Refactor GemFireVersion
Posted by Dick Cavender <dc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51380/#review146842
-----------------------------------------------------------
Ship it!
Ship It!
- Dick Cavender
On Aug. 24, 2016, 5:36 p.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51380/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2016, 5:36 p.m.)
>
>
> Review request for geode, Dick Cavender and Jens Deppe.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Clean up dead / broken / unused code and reduce the visible
> API methods. Store the version info as a Map to allow it to be
> extended more easily.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/StartupMessage.java 82f5c88c864fa7a03a7d33ee7cbcb1a08334667c
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireVersion.java baf03b1d54bf0ac82024af63eb00d42331f6e8fb
> geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java e52950f69a48d0cb83dedb4e9ad42c287a1c49a9
> geode-core/src/test/java/com/gemstone/gemfire/internal/GemFireVersionJUnitTest.java fc4ab1b3c1c46bcb5c8f0e66f64c926fc37db789
> geode-core/src/test/java/com/gemstone/gemfire/internal/VersionJUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/51380/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 51380: GEODE-1809: Refactor GemFireVersion
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51380/#review146787
-----------------------------------------------------------
Ship it!
Ship It!
- Jens Deppe
On Aug. 24, 2016, 5:36 p.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51380/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2016, 5:36 p.m.)
>
>
> Review request for geode, Dick Cavender and Jens Deppe.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Clean up dead / broken / unused code and reduce the visible
> API methods. Store the version info as a Map to allow it to be
> extended more easily.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/StartupMessage.java 82f5c88c864fa7a03a7d33ee7cbcb1a08334667c
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireVersion.java baf03b1d54bf0ac82024af63eb00d42331f6e8fb
> geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java e52950f69a48d0cb83dedb4e9ad42c287a1c49a9
> geode-core/src/test/java/com/gemstone/gemfire/internal/GemFireVersionJUnitTest.java fc4ab1b3c1c46bcb5c8f0e66f64c926fc37db789
> geode-core/src/test/java/com/gemstone/gemfire/internal/VersionJUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/51380/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 51380: GEODE-1809: Refactor GemFireVersion
Posted by Anthony Baker <ab...@apache.org>.
> On Aug. 25, 2016, 4:52 p.m., Mark Bretl wrote:
> > geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireVersion.java, line 253
> > <https://reviews.apache.org/r/51380/diff/1/?file=1483995#file1483995line253>
> >
> > This looks to be getting the wrong property, a duplicate 'SOURCE_REPOSITORY. Should this be changed to 'SOURCE_REVISION'?
Spot on, thanks for the awesome catch!
- Anthony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51380/#review146802
-----------------------------------------------------------
On Aug. 24, 2016, 5:36 p.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51380/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2016, 5:36 p.m.)
>
>
> Review request for geode, Dick Cavender and Jens Deppe.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Clean up dead / broken / unused code and reduce the visible
> API methods. Store the version info as a Map to allow it to be
> extended more easily.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/StartupMessage.java 82f5c88c864fa7a03a7d33ee7cbcb1a08334667c
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireVersion.java baf03b1d54bf0ac82024af63eb00d42331f6e8fb
> geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java e52950f69a48d0cb83dedb4e9ad42c287a1c49a9
> geode-core/src/test/java/com/gemstone/gemfire/internal/GemFireVersionJUnitTest.java fc4ab1b3c1c46bcb5c8f0e66f64c926fc37db789
> geode-core/src/test/java/com/gemstone/gemfire/internal/VersionJUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/51380/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 51380: GEODE-1809: Refactor GemFireVersion
Posted by Mark Bretl <mb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51380/#review146802
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireVersion.java (line 77)
<https://reviews.apache.org/r/51380/#comment213486>
This looks to be getting the wrong property, a duplicate 'SOURCE_REPOSITORY. Should this be changed to 'SOURCE_REVISION'?
- Mark Bretl
On Aug. 24, 2016, 10:36 a.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51380/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2016, 10:36 a.m.)
>
>
> Review request for geode, Dick Cavender and Jens Deppe.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Clean up dead / broken / unused code and reduce the visible
> API methods. Store the version info as a Map to allow it to be
> extended more easily.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/StartupMessage.java 82f5c88c864fa7a03a7d33ee7cbcb1a08334667c
> geode-core/src/main/java/com/gemstone/gemfire/internal/GemFireVersion.java baf03b1d54bf0ac82024af63eb00d42331f6e8fb
> geode-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java e52950f69a48d0cb83dedb4e9ad42c287a1c49a9
> geode-core/src/test/java/com/gemstone/gemfire/internal/GemFireVersionJUnitTest.java fc4ab1b3c1c46bcb5c8f0e66f64c926fc37db789
> geode-core/src/test/java/com/gemstone/gemfire/internal/VersionJUnitTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/51380/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>