You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/02/27 13:08:08 UTC

[GitHub] [mynewt-core] vrahane edited a comment on pull request #2508: net/osdp: Use internal data structures and remove dynamic memory allocations

vrahane edited a comment on pull request #2508:
URL: https://github.com/apache/mynewt-core/pull/2508#issuecomment-787069838


   I have already reviewed this quite in detail, can others please take a look. With this we have tried to do the following:
   - Reduce duplication of code
   - Removed its inherent data structures 
   - Used the mynewt BSD data structures
   - Removed dynamic memory allocation here and used mempools instead
   - Remove the ringbuffer and use the internal one since there was too much overhead involved
   - Some protection was also added around access of the TAILQs and mempools


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org