Re: [I] eTag support with If-Match [directory-scimple]

["bdemers (via GitHub)" <gi...@apache.org>]

bdemers commented on issue #534:
URL: https://github.com/apache/directory-scimple/issues/534#issuecomment-1989049735

   Thanks for the report @symphony-enrico!
   
   ETag support for updates was pushed down to the repository level (the `ETag` header maps to the `version`) in the `Repository.update(...)` method.
   
   The intent was to allow Repository implementations to make more performant checks to see if the etag/version matches. Before #411, this was not the case. Which forced a (potentially expensive) call to `repository.get(id)` that was then used to calculate the version/etag.  Now implementations optimize this how they see fit, e.g. add an index row to a database containing a `version` field.
   
   As you mentioned, the current implementation may not be accurate (doesn't match for `If-Match` headers). If you have suggestions on how to improve this please let us know! (Either in this issue, or a PR!)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org