[jira] [Updated] (SLING-2604) Method getChildren from the SlingRemoteTestRunner is breaking the execution of the Surefire plugin when using JUnit categories

["Cristian Vazzolla (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SLING-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Cristian Vazzolla updated SLING-2604:
-------------------------------------

    Attachment: SlingRemoteTestRunner.patch
                log_bug_sling_remote_runner.txt

Added log file and possible patch. Not very sure about the patch as I'm not very familiar with the SlingRemoteTestRunner.
                
> Method getChildren from the SlingRemoteTestRunner is breaking the execution of the Surefire plugin when using JUnit categories
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SLING-2604
>                 URL: https://issues.apache.org/jira/browse/SLING-2604
>             Project: Sling
>          Issue Type: Bug
>          Components: Scripting, Testing
>    Affects Versions: JUnit Remote Tests Runners 1.0.6
>         Environment: Windows 7
> Maven Surefire 2.12.3
>            Reporter: Cristian Vazzolla
>         Attachments: log_bug_sling_remote_runner.txt, SlingRemoteTestRunner.patch
>
>
> Method getChildren from the SlingRemoteTestRunner is breaking the execution of the Surefire plugin when using JUnit categories and executing the ServerSideIT tests if these throw an error in the maybeExecuteTests method.
> The getChildren method from the SlingRemoteTestRunner which overrides the getChildren method of the ParentRunner is not supposed to throw an error or at least it does not take into account that possibility when using JUnit categories with the Maven Surefire plugin. Because in that method an error is thrown , the error will go up and break the execution of the Surefire plugin when using JUnit categories. The method is called from the getFilteredChildren filter method of the ParentRunner. I'm not quite familiar with the SlingRemoteTestRunner but I think that we should remove the maybeExecuteTests call from the getChildren method of the SlingRemoteTestRunner.
> Attached is the log file and a patch for this which contains the method which just returns the children.
> Tried this also with the last version from the repo and it is the same, the method is not modified.
> We are not able to run the integration tests with the JUnit categories if we want to also run the ServerSideIt tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira