You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2019/10/10 10:51:33 UTC

[GitHub] [cloudstack] DaanHoogland opened a new pull request #3632: add class cleanup method

DaanHoogland opened a new pull request #3632: add class cleanup method
URL: https://github.com/apache/cloudstack/pull/3632
 
 
   ## Description
   <!--- Describe your changes in detail -->
   added a classmethod to cleanup resources save in the class field list _cleanup.
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   N/A
   
   ## How Has This Been Tested?
   Test run that would first leave an account in place in the environment that was tested against, now leaves this environment without residue.
   
   more tests have this fault. I'll look at cleaning those and a more generic method (i.e. moving the class-method to the parent class (as well as the list)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services