You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Marton Greber (Code Review)" <ge...@cloudera.org> on 2022/12/02 16:31:13 UTC
[kudu-CR] Fix RocksDB build on Apple Silicon
Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19308
Change subject: Fix RocksDB build on Apple Silicon
......................................................................
Fix RocksDB build on Apple Silicon
RocksDB fails to build on Apple Silicon. The build exits with multiple
undefined symbol linker errors. Removing "-L$PREFIX/lib" from the build
definition solves the problem.
This change makes the build successful on macOS and Linux as well.
I verified that there aren't any 'not found' shared objects, see below.
macOS (Apple Silicon):
$ otool -L ./thirdparty/installed/uninstrumented/lib/librocksdb.dylib
./thirdparty/installed/uninstrumented/lib/librocksdb.dylib:
@rpath/librocksdb.7.dylib (compatibility version 7.0.0, current version 7.7.3)
/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 1300.23.0)
/usr/lib/libc++abi.dylib (compatibility version 1.0.0, current version 1300.23.0)
liblz4.1.dylib (compatibility version 1.0.0, current version 1.9.3)
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1311.100.3)
Ubuntu (amd64):
$ ldd ./thirdparty/installed/uninstrumented/lib/librocksdb.so
linux-vdso.so.1 (0x00007ffc94f25000)
liblz4.so.1 => /root/apache/dev/git/kudu/thirdparty/installed/uninstrumented/lib/liblz4.so.1 (0x00007fcfa5de1000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fcfa5bc2000)
libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007fcfa5839000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fcfa549b000)
libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fcfa5283000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fcfa4e92000)
/lib64/ld-linux-x86-64.so.2 (0x00007fcfa6bf4000)
Ubuntu (amd64):
$ ldd ./thirdparty/installed/tsan/lib/librocksdb.so
linux-vdso.so.1 (0x00007ffe0abfa000)
liblz4.so.1 => /root/apache/dev/git/kudu/thirdparty/installed/tsan/lib/liblz4.so.1 (0x00007f0c2428f000)
libc++.so.1 => /root/apache/dev/git/kudu/thirdparty/installed/tsan/lib/libc++.so.1 (0x00007f0c23f81000)
libc++abi.so.1 => /root/apache/dev/git/kudu/thirdparty/installed/tsan/lib/libc++abi.so.1 (0x00007f0c23d43000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f0c239a5000)
libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f0c2378d000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f0c2356e000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f0c2317d000)
/lib64/ld-linux-x86-64.so.2 (0x00007f0c2530b000)
librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007f0c22f75000)
libatomic.so.1 => /usr/lib/x86_64-linux-gnu/libatomic.so.1 (0x00007f0c22d6d000)
Change-Id: Iec61fff8c6fb3ddb68498c9782cf765638101262
---
M thirdparty/build-definitions.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/19308/1
--
To view, visit http://gerrit.cloudera.org:8080/19308
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec61fff8c6fb3ddb68498c9782cf765638101262
Gerrit-Change-Number: 19308
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
[kudu-CR] Fix RocksDB build on Apple Silicon
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: Fix RocksDB build on Apple Silicon
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19308
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Iec61fff8c6fb3ddb68498c9782cf765638101262
Gerrit-Change-Number: 19308
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
[kudu-CR] Fix RocksDB build on Apple Silicon
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19308 )
Change subject: Fix RocksDB build on Apple Silicon
......................................................................
Patch Set 1: Code-Review+2
Thank you for the fix!
--
To view, visit http://gerrit.cloudera.org:8080/19308
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec61fff8c6fb3ddb68498c9782cf765638101262
Gerrit-Change-Number: 19308
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 17:52:02 +0000
Gerrit-HasComments: No
[kudu-CR] Fix RocksDB build on Apple Silicon
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19308 )
Change subject: Fix RocksDB build on Apple Silicon
......................................................................
Fix RocksDB build on Apple Silicon
RocksDB fails to build on Apple Silicon. The build exits with multiple
undefined symbol linker errors. Removing "-L$PREFIX/lib" from the build
definition solves the problem.
This change makes the build successful on macOS and Linux as well.
I verified that there aren't any 'not found' shared objects, see below.
macOS (Apple Silicon):
$ otool -L ./thirdparty/installed/uninstrumented/lib/librocksdb.dylib
./thirdparty/installed/uninstrumented/lib/librocksdb.dylib:
@rpath/librocksdb.7.dylib (compatibility version 7.0.0, current version 7.7.3)
/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 1300.23.0)
/usr/lib/libc++abi.dylib (compatibility version 1.0.0, current version 1300.23.0)
liblz4.1.dylib (compatibility version 1.0.0, current version 1.9.3)
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1311.100.3)
Ubuntu (amd64):
$ ldd ./thirdparty/installed/uninstrumented/lib/librocksdb.so
linux-vdso.so.1 (0x00007ffc94f25000)
liblz4.so.1 => /root/apache/dev/git/kudu/thirdparty/installed/uninstrumented/lib/liblz4.so.1 (0x00007fcfa5de1000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fcfa5bc2000)
libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007fcfa5839000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fcfa549b000)
libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fcfa5283000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fcfa4e92000)
/lib64/ld-linux-x86-64.so.2 (0x00007fcfa6bf4000)
Ubuntu (amd64):
$ ldd ./thirdparty/installed/tsan/lib/librocksdb.so
linux-vdso.so.1 (0x00007ffe0abfa000)
liblz4.so.1 => /root/apache/dev/git/kudu/thirdparty/installed/tsan/lib/liblz4.so.1 (0x00007f0c2428f000)
libc++.so.1 => /root/apache/dev/git/kudu/thirdparty/installed/tsan/lib/libc++.so.1 (0x00007f0c23f81000)
libc++abi.so.1 => /root/apache/dev/git/kudu/thirdparty/installed/tsan/lib/libc++abi.so.1 (0x00007f0c23d43000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f0c239a5000)
libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f0c2378d000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f0c2356e000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f0c2317d000)
/lib64/ld-linux-x86-64.so.2 (0x00007f0c2530b000)
librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007f0c22f75000)
libatomic.so.1 => /usr/lib/x86_64-linux-gnu/libatomic.so.1 (0x00007f0c22d6d000)
Change-Id: Iec61fff8c6fb3ddb68498c9782cf765638101262
Reviewed-on: http://gerrit.cloudera.org:8080/19308
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M thirdparty/build-definitions.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19308
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec61fff8c6fb3ddb68498c9782cf765638101262
Gerrit-Change-Number: 19308
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
[kudu-CR] Fix RocksDB build on Apple Silicon
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19308 )
Change subject: Fix RocksDB build on Apple Silicon
......................................................................
Patch Set 1: Verified+1
unrelated Java test failures
--
To view, visit http://gerrit.cloudera.org:8080/19308
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec61fff8c6fb3ddb68498c9782cf765638101262
Gerrit-Change-Number: 19308
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Ádám Bakai <ab...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Dec 2022 17:51:52 +0000
Gerrit-HasComments: No