You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "empiredan (via GitHub)" <gi...@apache.org> on 2023/04/25 05:10:24 UTC
[GitHub] [incubator-pegasus] empiredan opened a new pull request, #1459: feat(new_metrics): migrate metrics for replica_stub (part 2)
empiredan opened a new pull request, #1459:
URL: https://github.com/apache/incubator-pegasus/pull/1459
https://github.com/apache/incubator-pegasus/issues/1454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 merged pull request #1459: feat(new_metrics): migrate metrics for replica_stub (part 2)
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 merged PR #1459:
URL: https://github.com/apache/incubator-pegasus/pull/1459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1459: feat(new_metrics): migrate metrics for replica_stub (part 2)
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 commented on code in PR #1459:
URL: https://github.com/apache/incubator-pegasus/pull/1459#discussion_r1176388921
##########
src/replica/replica_stub.cpp:
##########
@@ -1972,9 +1920,9 @@ void replica_stub::on_gc()
}
}
- _counter_replicas_learning_count->set(learning_count);
- _counter_replicas_learning_max_duration_time_ms->set(learning_max_duration_time_ms);
- _counter_replicas_learning_max_copy_file_size->set(learning_max_copy_file_size);
+ METRIC_VAR_SET(learning_replicas, learning_count);
+ METRIC_VAR_SET(learning_replicas_max_duration_ms, learning_max_duration_time_ms);
Review Comment:
How about use percentile type of metric for 'duration', then it's able to provide more distribution details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org