You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/27 12:26:34 UTC

[GitHub] [tvm] arangasa commented on a diff in pull request #11561: [Topi][Hexagon] Implement Cast F32ToF16 and F16ToF32 Slice Op

arangasa commented on code in PR #11561:
URL: https://github.com/apache/tvm/pull/11561#discussion_r907328003


##########
python/tvm/topi/hexagon/utils.py:
##########
@@ -49,4 +64,10 @@ def get_layout_transform_fn(layout):
         return n11c_1024c_2d
     if layout == "n11c-1024c-1d":
         return n11c_1024c_1d
+    if layout == "nhwc-4h2w32c2w-2d":

Review Comment:
   Hi Eric @Lunderberg , Thank you for your time and helpful inputs. I think for now we are sticking to pre-defined layouts. But we don't want the tests to be parameterized over each layout since the tests wouldn't support each one of them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org