You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2014/06/06 15:06:04 UTC
Re: Clean up org.apache.logging.log4j.Marker.getParent()
Hi Bruce: Is this still on your ti-do list?
Gary
On Sat, May 31, 2014 at 12:08 AM, Bruce Brouwer <br...@gmail.com>
wrote:
> Oh yeah. I've been having too much fun lately with the kids and the
> beautiful spring weather. I need to get back to this.
>
>
> On Sun, May 25, 2014 at 1:08 AM, Matt Sicker <bo...@gmail.com> wrote:
>
>> Looking forward to the new work! ;)
>>
>>
>> On 19 May 2014 22:40, Bruce Brouwer <br...@gmail.com> wrote:
>>
>>> Give me commit rights and I'll do it. (I believe that is in the works)
>>>
>>>
>>> On Sun, May 18, 2014 at 9:31 PM, Gary Gregory <ga...@gmail.com>
>>> wrote:
>>>
>>>> Any volunteers to remove org.apache.logging.log4j.Marker.getParent() ?
>>>> :-)
>>>> Gary
>>>>
>>>> --
>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>> Java Persistence with Hibernate, Second Edition
>>>> <http://www.manning.com/bauer3/>
>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>> Blog: http://garygregory.wordpress.com
>>>> Home: http://garygregory.com/
>>>> Tweet! http://twitter.com/GaryGregory
>>>>
>>>
>>>
>>>
>>> --
>>>
>>>
>>> Bruce Brouwer
>>> about.me/bruce.brouwer
>>> [image: Bruce Brouwer on about.me]
>>> <http://about.me/bruce.brouwer>
>>>
>>
>>
>>
>> --
>> Matt Sicker <bo...@gmail.com>
>>
>
>
>
> --
>
>
> Bruce Brouwer
> about.me/bruce.brouwer
> [image: Bruce Brouwer on about.me]
> <http://about.me/bruce.brouwer>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: Clean up org.apache.logging.log4j.Marker.getParent()
Posted by Ralph Goers <rg...@apache.org>.
Congrats!
If you can think of other tests by all means add them.
Sent from my iPad
> On Jun 6, 2014, at 6:52 PM, Bruce Brouwer <br...@gmail.com> wrote:
>
> Woo hoo! My first real commit.
>
> I have never dealt with the NoSQL stuff before, so somebody might want to double-check that.
>
> Also, it seems like the tests are pretty light in log4j-to-slf4j. Is that on purpose? Do we think that one test class is enough?
>
>
>> On Fri, Jun 6, 2014 at 10:22 AM, Bruce Brouwer <br...@gmail.com> wrote:
>> It is. I wanted to show my progress on LOG4J2-609 before I was distracted by this. I looked at it last night and it isn't quite as simple as deleting a few methods, but it also doesn't look too terribly hard.
>>
>>
>>> On Fri, Jun 6, 2014 at 9:06 AM, Gary Gregory <ga...@gmail.com> wrote:
>>> Hi Bruce: Is this still on your ti-do list?
>>>
>>> Gary
>>>
>>>
>>>> On Sat, May 31, 2014 at 12:08 AM, Bruce Brouwer <br...@gmail.com> wrote:
>>>
>>>> Oh yeah. I've been having too much fun lately with the kids and the beautiful spring weather. I need to get back to this.
>>>>
>>>>
>>>>> On Sun, May 25, 2014 at 1:08 AM, Matt Sicker <bo...@gmail.com> wrote:
>>>>> Looking forward to the new work! ;)
>>>>>
>>>>>
>>>>>> On 19 May 2014 22:40, Bruce Brouwer <br...@gmail.com> wrote:
>>>>>> Give me commit rights and I'll do it. (I believe that is in the works)
>>>>>>
>>>>>>
>>>>>>> On Sun, May 18, 2014 at 9:31 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>>>> Any volunteers to remove org.apache.logging.log4j.Marker.getParent() ?
>>>>>>> :-)
>>>>>>> Gary
>>>>>>>
>>>>>>> --
>>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>>> JUnit in Action, Second Edition
>>>>>>> Spring Batch in Action
>>>>>>> Blog: http://garygregory.wordpress.com
>>>>>>> Home: http://garygregory.com/
>>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>>
>>>>>>
>>>>>> Bruce Brouwer
>>>>>> about.me/bruce.brouwer
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Matt Sicker <bo...@gmail.com>
>>>>
>>>>
>>>>
>>>> --
>>>>
>>>>
>>>> Bruce Brouwer
>>>> about.me/bruce.brouwer
>>>>
>>>>
>>>
>>>
>>>
>>>
>>> --
>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>> Java Persistence with Hibernate, Second Edition
>>> JUnit in Action, Second Edition
>>> Spring Batch in Action
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>
>>
>>
>> --
>>
>>
>> Bruce Brouwer
>> about.me/bruce.brouwer
>>
>>
>
>
>
> --
>
>
> Bruce Brouwer
> about.me/bruce.brouwer
>
>
Re: Clean up org.apache.logging.log4j.Marker.getParent()
Posted by Matt Sicker <bo...@gmail.com>.
The things I could think of would be some sort of integration testing like
in Tomcat.
On 6 June 2014 21:59, Gary Gregory <ga...@gmail.com> wrote:
> Ka-Pow! Welcome to commit-land :-)
>
> Gary
>
>
> On Fri, Jun 6, 2014 at 9:52 PM, Bruce Brouwer <br...@gmail.com>
> wrote:
>
>> Woo hoo! My first real commit.
>>
>> I have never dealt with the NoSQL stuff before, so somebody might want to
>> double-check that.
>>
>> Also, it seems like the tests are pretty light in log4j-to-slf4j. Is that
>> on purpose? Do we think that one test class is enough?
>>
>>
>> On Fri, Jun 6, 2014 at 10:22 AM, Bruce Brouwer <br...@gmail.com>
>> wrote:
>>
>>> It is. I wanted to show my progress on LOG4J2-609 before I was
>>> distracted by this. I looked at it last night and it isn't quite as simple
>>> as deleting a few methods, but it also doesn't look too terribly hard.
>>>
>>>
>>> On Fri, Jun 6, 2014 at 9:06 AM, Gary Gregory <ga...@gmail.com>
>>> wrote:
>>>
>>>> Hi Bruce: Is this still on your ti-do list?
>>>>
>>>> Gary
>>>>
>>>>
>>>> On Sat, May 31, 2014 at 12:08 AM, Bruce Brouwer <
>>>> bruce.brouwer@gmail.com> wrote:
>>>>
>>>>> Oh yeah. I've been having too much fun lately with the kids and the
>>>>> beautiful spring weather. I need to get back to this.
>>>>>
>>>>>
>>>>> On Sun, May 25, 2014 at 1:08 AM, Matt Sicker <bo...@gmail.com> wrote:
>>>>>
>>>>>> Looking forward to the new work! ;)
>>>>>>
>>>>>>
>>>>>> On 19 May 2014 22:40, Bruce Brouwer <br...@gmail.com> wrote:
>>>>>>
>>>>>>> Give me commit rights and I'll do it. (I believe that is in the
>>>>>>> works)
>>>>>>>
>>>>>>>
>>>>>>> On Sun, May 18, 2014 at 9:31 PM, Gary Gregory <
>>>>>>> garydgregory@gmail.com> wrote:
>>>>>>>
>>>>>>>> Any volunteers to remove
>>>>>>>> org.apache.logging.log4j.Marker.getParent() ?
>>>>>>>> :-)
>>>>>>>> Gary
>>>>>>>>
>>>>>>>> --
>>>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>>>> <http://www.manning.com/bauer3/>
>>>>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>>>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>>>>>> Blog: http://garygregory.wordpress.com
>>>>>>>> Home: http://garygregory.com/
>>>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>>
>>>>>>>
>>>>>>> Bruce Brouwer
>>>>>>> about.me/bruce.brouwer
>>>>>>> [image: Bruce Brouwer on about.me]
>>>>>>> <http://about.me/bruce.brouwer>
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Matt Sicker <bo...@gmail.com>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>>
>>>>>
>>>>> Bruce Brouwer
>>>>> about.me/bruce.brouwer
>>>>> [image: Bruce Brouwer on about.me]
>>>>> <http://about.me/bruce.brouwer>
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>> Java Persistence with Hibernate, Second Edition
>>>> <http://www.manning.com/bauer3/>
>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>> Blog: http://garygregory.wordpress.com
>>>> Home: http://garygregory.com/
>>>> Tweet! http://twitter.com/GaryGregory
>>>>
>>>
>>>
>>>
>>> --
>>>
>>>
>>> Bruce Brouwer
>>> about.me/bruce.brouwer
>>> [image: Bruce Brouwer on about.me]
>>> <http://about.me/bruce.brouwer>
>>>
>>
>>
>>
>> --
>>
>>
>> Bruce Brouwer
>> about.me/bruce.brouwer
>> [image: Bruce Brouwer on about.me]
>> <http://about.me/bruce.brouwer>
>>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
--
Matt Sicker <bo...@gmail.com>
Re: Clean up org.apache.logging.log4j.Marker.getParent()
Posted by Gary Gregory <ga...@gmail.com>.
Ka-Pow! Welcome to commit-land :-)
Gary
On Fri, Jun 6, 2014 at 9:52 PM, Bruce Brouwer <br...@gmail.com>
wrote:
> Woo hoo! My first real commit.
>
> I have never dealt with the NoSQL stuff before, so somebody might want to
> double-check that.
>
> Also, it seems like the tests are pretty light in log4j-to-slf4j. Is that
> on purpose? Do we think that one test class is enough?
>
>
> On Fri, Jun 6, 2014 at 10:22 AM, Bruce Brouwer <br...@gmail.com>
> wrote:
>
>> It is. I wanted to show my progress on LOG4J2-609 before I was distracted
>> by this. I looked at it last night and it isn't quite as simple as deleting
>> a few methods, but it also doesn't look too terribly hard.
>>
>>
>> On Fri, Jun 6, 2014 at 9:06 AM, Gary Gregory <ga...@gmail.com>
>> wrote:
>>
>>> Hi Bruce: Is this still on your ti-do list?
>>>
>>> Gary
>>>
>>>
>>> On Sat, May 31, 2014 at 12:08 AM, Bruce Brouwer <bruce.brouwer@gmail.com
>>> > wrote:
>>>
>>>> Oh yeah. I've been having too much fun lately with the kids and the
>>>> beautiful spring weather. I need to get back to this.
>>>>
>>>>
>>>> On Sun, May 25, 2014 at 1:08 AM, Matt Sicker <bo...@gmail.com> wrote:
>>>>
>>>>> Looking forward to the new work! ;)
>>>>>
>>>>>
>>>>> On 19 May 2014 22:40, Bruce Brouwer <br...@gmail.com> wrote:
>>>>>
>>>>>> Give me commit rights and I'll do it. (I believe that is in the works)
>>>>>>
>>>>>>
>>>>>> On Sun, May 18, 2014 at 9:31 PM, Gary Gregory <garydgregory@gmail.com
>>>>>> > wrote:
>>>>>>
>>>>>>> Any volunteers to remove org.apache.logging.log4j.Marker.getParent()
>>>>>>> ?
>>>>>>> :-)
>>>>>>> Gary
>>>>>>>
>>>>>>> --
>>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>>> <http://www.manning.com/bauer3/>
>>>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>>>>> Blog: http://garygregory.wordpress.com
>>>>>>> Home: http://garygregory.com/
>>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>>
>>>>>>
>>>>>> Bruce Brouwer
>>>>>> about.me/bruce.brouwer
>>>>>> [image: Bruce Brouwer on about.me]
>>>>>> <http://about.me/bruce.brouwer>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Matt Sicker <bo...@gmail.com>
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>>
>>>>
>>>> Bruce Brouwer
>>>> about.me/bruce.brouwer
>>>> [image: Bruce Brouwer on about.me]
>>>> <http://about.me/bruce.brouwer>
>>>>
>>>
>>>
>>>
>>> --
>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>> Java Persistence with Hibernate, Second Edition
>>> <http://www.manning.com/bauer3/>
>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> Spring Batch in Action <http://www.manning.com/templier/>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
>>
>>
>>
>> --
>>
>>
>> Bruce Brouwer
>> about.me/bruce.brouwer
>> [image: Bruce Brouwer on about.me]
>> <http://about.me/bruce.brouwer>
>>
>
>
>
> --
>
>
> Bruce Brouwer
> about.me/bruce.brouwer
> [image: Bruce Brouwer on about.me]
> <http://about.me/bruce.brouwer>
>
--
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: Clean up org.apache.logging.log4j.Marker.getParent()
Posted by Bruce Brouwer <br...@gmail.com>.
Woo hoo! My first real commit.
I have never dealt with the NoSQL stuff before, so somebody might want to
double-check that.
Also, it seems like the tests are pretty light in log4j-to-slf4j. Is that
on purpose? Do we think that one test class is enough?
On Fri, Jun 6, 2014 at 10:22 AM, Bruce Brouwer <br...@gmail.com>
wrote:
> It is. I wanted to show my progress on LOG4J2-609 before I was distracted
> by this. I looked at it last night and it isn't quite as simple as deleting
> a few methods, but it also doesn't look too terribly hard.
>
>
> On Fri, Jun 6, 2014 at 9:06 AM, Gary Gregory <ga...@gmail.com>
> wrote:
>
>> Hi Bruce: Is this still on your ti-do list?
>>
>> Gary
>>
>>
>> On Sat, May 31, 2014 at 12:08 AM, Bruce Brouwer <br...@gmail.com>
>> wrote:
>>
>>> Oh yeah. I've been having too much fun lately with the kids and the
>>> beautiful spring weather. I need to get back to this.
>>>
>>>
>>> On Sun, May 25, 2014 at 1:08 AM, Matt Sicker <bo...@gmail.com> wrote:
>>>
>>>> Looking forward to the new work! ;)
>>>>
>>>>
>>>> On 19 May 2014 22:40, Bruce Brouwer <br...@gmail.com> wrote:
>>>>
>>>>> Give me commit rights and I'll do it. (I believe that is in the works)
>>>>>
>>>>>
>>>>> On Sun, May 18, 2014 at 9:31 PM, Gary Gregory <ga...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> Any volunteers to remove org.apache.logging.log4j.Marker.getParent() ?
>>>>>> :-)
>>>>>> Gary
>>>>>>
>>>>>> --
>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>> <http://www.manning.com/bauer3/>
>>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>>>> Blog: http://garygregory.wordpress.com
>>>>>> Home: http://garygregory.com/
>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>>
>>>>>
>>>>> Bruce Brouwer
>>>>> about.me/bruce.brouwer
>>>>> [image: Bruce Brouwer on about.me]
>>>>> <http://about.me/bruce.brouwer>
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Matt Sicker <bo...@gmail.com>
>>>>
>>>
>>>
>>>
>>> --
>>>
>>>
>>> Bruce Brouwer
>>> about.me/bruce.brouwer
>>> [image: Bruce Brouwer on about.me]
>>> <http://about.me/bruce.brouwer>
>>>
>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
>
>
> Bruce Brouwer
> about.me/bruce.brouwer
> [image: Bruce Brouwer on about.me]
> <http://about.me/bruce.brouwer>
>
--
Bruce Brouwer
about.me/bruce.brouwer
[image: Bruce Brouwer on about.me]
<http://about.me/bruce.brouwer>
Re: Clean up org.apache.logging.log4j.Marker.getParent()
Posted by Bruce Brouwer <br...@gmail.com>.
It is. I wanted to show my progress on LOG4J2-609 before I was distracted
by this. I looked at it last night and it isn't quite as simple as deleting
a few methods, but it also doesn't look too terribly hard.
On Fri, Jun 6, 2014 at 9:06 AM, Gary Gregory <ga...@gmail.com> wrote:
> Hi Bruce: Is this still on your ti-do list?
>
> Gary
>
>
> On Sat, May 31, 2014 at 12:08 AM, Bruce Brouwer <br...@gmail.com>
> wrote:
>
>> Oh yeah. I've been having too much fun lately with the kids and the
>> beautiful spring weather. I need to get back to this.
>>
>>
>> On Sun, May 25, 2014 at 1:08 AM, Matt Sicker <bo...@gmail.com> wrote:
>>
>>> Looking forward to the new work! ;)
>>>
>>>
>>> On 19 May 2014 22:40, Bruce Brouwer <br...@gmail.com> wrote:
>>>
>>>> Give me commit rights and I'll do it. (I believe that is in the works)
>>>>
>>>>
>>>> On Sun, May 18, 2014 at 9:31 PM, Gary Gregory <ga...@gmail.com>
>>>> wrote:
>>>>
>>>>> Any volunteers to remove org.apache.logging.log4j.Marker.getParent() ?
>>>>> :-)
>>>>> Gary
>>>>>
>>>>> --
>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>> Java Persistence with Hibernate, Second Edition
>>>>> <http://www.manning.com/bauer3/>
>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>>> Blog: http://garygregory.wordpress.com
>>>>> Home: http://garygregory.com/
>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>>
>>>>
>>>> Bruce Brouwer
>>>> about.me/bruce.brouwer
>>>> [image: Bruce Brouwer on about.me]
>>>> <http://about.me/bruce.brouwer>
>>>>
>>>
>>>
>>>
>>> --
>>> Matt Sicker <bo...@gmail.com>
>>>
>>
>>
>>
>> --
>>
>>
>> Bruce Brouwer
>> about.me/bruce.brouwer
>> [image: Bruce Brouwer on about.me]
>> <http://about.me/bruce.brouwer>
>>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
--
Bruce Brouwer
about.me/bruce.brouwer
[image: Bruce Brouwer on about.me]
<http://about.me/bruce.brouwer>