You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by mc...@apache.org on 2008/06/16 19:02:16 UTC

svn commit: r668245 - /myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/convert/ColorConverter.java

Author: mcooper
Date: Mon Jun 16 10:02:15 2008
New Revision: 668245

URL: http://svn.apache.org/viewvc?rev=668245&view=rev
Log:
Fixed undefined value JS errors that show up in Safari 3.1.1.
"window[key]" is not necessarily the same thing as "var key" in the context of an eval (at least in Safari).

Modified:
    myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/convert/ColorConverter.java

Modified: myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/convert/ColorConverter.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/convert/ColorConverter.java?rev=668245&r1=668244&r2=668245&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/convert/ColorConverter.java (original)
+++ myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/convert/ColorConverter.java Mon Jun 16 10:02:15 2008
@@ -88,7 +88,7 @@
         // only create the _cfs object if it doesn't exist, so we don't
         // wipe out _cfs[xxx] values if we ppr the first color field on a
         // page with multiple color fields.
-        buff.append("if(window['_cfs']==undefined){var _cfs=new Object();var _cfts=new Object();}");
+        buff.append("if(window['_cfs']==undefined){window['_cfs']=new Object();window['_cfts']=new Object();}");
       }
 
       String[] patterns = getPatterns();