You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/13 14:11:14 UTC
[GitHub] [shardingsphere] linghengqian opened a new pull request, #21552: Update library to serve unit testing inside GraalVM Native Image
linghengqian opened a new pull request, #21552:
URL: https://github.com/apache/shardingsphere/pull/21552
For #21347.
Changes proposed in this pull request:
- Introduce `junit-vintage-engine` to support unit testing inside GraalVM Native Image. Reference https://github.com/graalvm/native-build-tools/issues/53 .
- Update HikariCP to the highest possible version to better match the graalvm reachability metadata at https://github.com/oracle/graalvm-reachability-metadata/tree/master/metadata/com.zaxxer/HikariCP/5.0.1 .
- Update netty to 4.1.84 to automatically generate native-image `conditional` metadata for `ChannelHandler` implementations. See https://github.com/netty/netty/pull/12794 .
- Update logback to match graalvm reachability metadata at https://github.com/oracle/graalvm-reachability-metadata/tree/master/metadata/ch.qos.logback/logback-classic/1.2.11 .
- Update `maven-surefire-plugin` to milestone version to automatically handle use of `org.junit.platform:junit-platform-launcher`. Reference https://graalvm.github.io/native-build-tools/latest/maven-plugin.html#testing-support-version-compatibility .
- Update mockito to be in sync with the latest Junit Platform requirements as much as possible.
- Update most of the dependencies to get https://github.com/oracle/graalvm-reachability-metadata support faster in the future. The exception is jetcd, if we had to exclude Guava, that would break a bunch of weird behavior of `io.etcd:jetcd-grpc:0.7.3`. I have some ideas at https://github.com/etcd-io/jetcd/issues/1091 but haven't started working on that issue yet.
- Handle most deprecated methods.
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian closed pull request #21552: Update library to serve building GraalVM Native Image
Posted by GitBox <gi...@apache.org>.
linghengqian closed pull request #21552: Update library to serve building GraalVM Native Image
URL: https://github.com/apache/shardingsphere/pull/21552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21552: Update library to serve building GraalVM Native Image
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21552:
URL: https://github.com/apache/shardingsphere/pull/21552#issuecomment-1278031278
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21552](https://codecov.io/gh/apache/shardingsphere/pull/21552?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0275ffd) into [master](https://codecov.io/gh/apache/shardingsphere/commit/22313c9651c1d8fd44d2920676a47de15c462338?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (22313c9) will **decrease** coverage by `0.21%`.
> The diff coverage is `8.33%`.
> :exclamation: Current head 0275ffd differs from pull request most recent head d51be2b. Consider uploading reports for the commit d51be2b to get more accurate results
```diff
@@ Coverage Diff @@
## master #21552 +/- ##
============================================
- Coverage 61.21% 60.99% -0.22%
- Complexity 2509 2510 +1
============================================
Files 4109 4115 +6
Lines 57124 57346 +222
Branches 7560 7592 +32
============================================
+ Hits 34967 34981 +14
- Misses 19222 19430 +208
Partials 2935 2935
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21552?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...etadata/data/ShardingStatisticsTableCollector.java](https://codecov.io/gh/apache/shardingsphere/pull/21552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvbWV0YWRhdGEvZGF0YS9TaGFyZGluZ1N0YXRpc3RpY3NUYWJsZUNvbGxlY3Rvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...uilder/dialect/MySQLShardingSphereDataBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/21552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhL2J1aWxkZXIvZGlhbGVjdC9NeVNRTFNoYXJkaW5nU3BoZXJlRGF0YUJ1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...r/dialect/PostgreSQLShardingSphereDataBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/21552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhL2J1aWxkZXIvZGlhbGVjdC9Qb3N0Z3JlU1FMU2hhcmRpbmdTcGhlcmVEYXRhQnVpbGRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nfra/yaml/data/pojo/YamlShardingSphereRowData.java](https://codecov.io/gh/apache/shardingsphere/pull/21552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2RhdGEvcG9qby9ZYW1sU2hhcmRpbmdTcGhlcmVSb3dEYXRhLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ra/yaml/data/pojo/YamlShardingSphereTableData.java](https://codecov.io/gh/apache/shardingsphere/pull/21552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2RhdGEvcG9qby9ZYW1sU2hhcmRpbmdTcGhlcmVUYWJsZURhdGEuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ta/swapper/YamlShardingSphereTableDataSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/21552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2RhdGEvc3dhcHBlci9ZYW1sU2hhcmRpbmdTcGhlcmVUYWJsZURhdGFTd2FwcGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...line/core/api/impl/AbstractPipelineJobAPIImpl.java](https://codecov.io/gh/apache/shardingsphere/pull/21552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2FwaS9pbXBsL0Fic3RyYWN0UGlwZWxpbmVKb2JBUElJbXBsLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ine/core/api/impl/GovernanceRepositoryAPIImpl.java](https://codecov.io/gh/apache/shardingsphere/pull/21552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2FwaS9pbXBsL0dvdmVybmFuY2VSZXBvc2l0b3J5QVBJSW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/api/impl/InventoryIncrementalJobItemAPIImpl.java](https://codecov.io/gh/apache/shardingsphere/pull/21552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2FwaS9pbXBsL0ludmVudG9yeUluY3JlbWVudGFsSm9iSXRlbUFQSUltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ore/api/impl/PipelineDataSourcePersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/21552/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2FwaS9pbXBsL1BpcGVsaW5lRGF0YVNvdXJjZVBlcnNpc3RTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| ... and [24 more](https://codecov.io/gh/apache/shardingsphere/pull/21552/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on pull request #21552: Update library to serve building GraalVM Native Image
Posted by GitBox <gi...@apache.org>.
linghengqian commented on PR #21552:
URL: https://github.com/apache/shardingsphere/pull/21552#issuecomment-1278511125
- Some magical GHA issues happened in this PR. Atomikos has added a new keepaliveTime property from `5.0.8` to `5.0.9`. I switch `atomikos.version` in different commits of the PR. If GHA keeps the cache, I can easily see this problem... But the process of changing `atomikos.version` happens in the child `pom.xml` for the module, not sure what to do.
- I'll submit a new PR on the new branch shortly.
- 
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on pull request #21552: Update library to serve building GraalVM Native Image
Posted by GitBox <gi...@apache.org>.
linghengqian commented on PR #21552:
URL: https://github.com/apache/shardingsphere/pull/21552#issuecomment-1279017866
New PR at https://github.com/apache/shardingsphere/pull/21571 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org