You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2012/05/18 18:23:11 UTC

[jira] [Commented] (SHINDIG-1781) makeRequest does not forward User-Agent

    [ https://issues.apache.org/jira/browse/SHINDIG-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278921#comment-13278921 ] 

jiraposter@reviews.apache.org commented on SHINDIG-1781:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5162/
-----------------------------------------------------------

Review request for shindig.


Summary
-------

Passes the User-Agent header so intermediate (or even backend processing) can make browser-specific customizations. 


This addresses bug SHINDIG-1781.
    https://issues.apache.org/jira/browse/SHINDIG-1781


Diffs
-----

  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1340074 

Diff: https://reviews.apache.org/r/5162/diff


Testing
-------

All tests pass.


Thanks,

Adam


                
> makeRequest does not forward User-Agent
> ---------------------------------------
>
>                 Key: SHINDIG-1781
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1781
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 2.5.0-beta1, 2.5.0
>            Reporter: Adam Clarke
>            Priority: Minor
>         Attachments: 1781_20120518.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Currently makeRequest does not forward the User-Agent header from the browser.  This makes it impossible for intermediate processing or backend processing to customize responses for different browsers.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira