You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/22 13:48:02 UTC

[GitHub] [superset] geido commented on a change in pull request #13274: chore: Migrates RefreshChartOverlay into Chart

geido commented on a change in pull request #13274:
URL: https://github.com/apache/superset/pull/13274#discussion_r580261091



##########
File path: superset-frontend/src/chart/Chart.jsx
##########
@@ -175,7 +186,6 @@ class Chart extends React.PureComponent {
 
   render() {
     const {
-      width,

Review comment:
       It looks like the width was used in a few places and it is also defined in the PropTypes. Would you like to check where it is used and delete it if you deem it unnecessary?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org