You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/03 19:30:45 UTC
[jira] [Commented] (BEAM-1619) Streaming Side Inputs are Broken in
Dataflow
[ https://issues.apache.org/jira/browse/BEAM-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894902#comment-15894902 ]
ASF GitHub Bot commented on BEAM-1619:
--------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/2152
[BEAM-1619] Write to the existing View in Dataflow Streaming Side Inputs
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
This updates Streaming View Overrides to use the original view when they override a transform
by causing the override to only apply to the `View.CreatePCollectionView`, inserting a global combine
and view write prior to the primitive which creates the view.
There are also updates to how the Dataflow Runner signifies that a Map or Multimap view has a nondeterminstic key coder, as well as an additional test for CombineGloballyAsSingletonView.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam streaming_single_override
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2152.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2152
----
commit 87e4d403638fe4e037ba47937398908e25d529e3
Author: Thomas Groh <tg...@google.com>
Date: 2017-03-03T18:56:29Z
Only Override CreatePCollectionView in Streaming
This permits us to use the appropriate view token for the
StreamingPCollectionViewWriterFn.
commit 657a641a008217c592dded5b338b137e68b63457
Author: Thomas Groh <tg...@google.com>
Date: 2017-03-03T18:57:50Z
Remove SingletonCombine
It is unused with the update to Streaming View Overrides.
commit 31928af28bde6c5212c508372c18b05803962e22
Author: Thomas Groh <tg...@google.com>
Date: 2017-03-03T19:24:14Z
Add a Test for windowed CombineGloballyAsSingletonView
----
> Streaming Side Inputs are Broken in Dataflow
> --------------------------------------------
>
> Key: BEAM-1619
> URL: https://issues.apache.org/jira/browse/BEAM-1619
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Thomas Groh
> Assignee: Thomas Groh
> Priority: Blocker
> Fix For: 0.6.0
>
>
> Because of the use of StreamingPCollectionViewWriterFn and an embedded view, surgery has caused all Streaming Side Inputs to not be accessible, as the view tag written to and the view tag embedded in the DoFn for the same view do not align.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)