You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/01 23:37:04 UTC
[jira] [Commented] (BEAM-2051) Reduce scope of the PCollectionView
interface
[ https://issues.apache.org/jira/browse/BEAM-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991795#comment-15991795 ]
ASF GitHub Bot commented on BEAM-2051:
--------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/2811
[BEAM-2051] Cast to SimplePCollectionView instead of View.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
Wherever a View method is used, a concrete instance of
SimplePCollectionView is required.
PCollectionView is a marker interface. Runners can expect to
always recieve a subclass of SimplePCollectionView, and cast to it when
methods are required.
Once this is live in the DataflowRunner, #2680 can be merged. This is #2680, without the changes to PCollectionView
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam view_as_marker_prereq
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2811.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2811
----
commit c60d4a3ec4f07110a0a5d4c307bbbf9e5f4db416
Author: Thomas Groh <tg...@google.com>
Date: 2017-04-21T16:46:28Z
Cast to SimplePCollectionView instead of View.
Wherever a View method is used, a concrete instance of
SimplePCollectionView is required.
PCollectionView is a marker interface. Runners can expect to
always recieve a subclass of SimplePCollectionView, and cast to it when
methods are required.
----
> Reduce scope of the PCollectionView interface
> ---------------------------------------------
>
> Key: BEAM-2051
> URL: https://issues.apache.org/jira/browse/BEAM-2051
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Thomas Groh
> Assignee: Thomas Groh
> Fix For: First stable release
>
>
> Users should only ever use a PCollectionView class as a token to access a view. A Runner can cast down to a more expressive type if required.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)