[jira] [Comment Edited] (JENA-588) TDBLoader does not throw exception when disk full

["Andy Seaborne (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JENA-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823588#comment-13823588 ] 

Andy Seaborne edited comment on JENA-588 at 11/15/13 12:07 PM:
---------------------------------------------------------------

Thanks. 

Which OS and which Java (32 or 64 bit?) are you using?  I get different errors although I have found-and-fixed one related issue.

Looking at the code it comes down to this code in BufferChannelFile:

{noformat}
    public int write(ByteBuffer buffer)
    {
        try { return file.channel().write(buffer) ; } 
        catch (IOException e) { IO.exception(e) ; return -1 ; }
    }
{noformat}

and {{IO.exception(e)}} throws an exception, wrapping the IOException, and you don't get to the {{return -1}}.

I get different errors.  It immediately exits on 64 bit Java7 but due to the tmpfs specifically. Using 32 bit file mode, I found a place where the exception was being silent discarded. Fixed.

I tried on Ubuntu 13.04 with a tmpfs.


was (Author: andy.seaborne):
Thanks. 

Which OS and which Java (32 or 64 bit?) are you using?  I get different errors although I have found-and-fixed one related issue.

Looking at the code it comes down to this code in BufferChannelFile:

{noformat}
    public int write(ByteBuffer buffer)
    {
        try { return file.channel().write(buffer) ; } 
        catch (IOException e) { IO.exception(e) ; return -1 ; }
    }
{noformat}

and {{IO.exception(e)}} throws an exception, wrapping the IOException, and you don't get to the {{return -1}}.

I get a different errors  Immediate exit on 64 bit Java7. Using 32 bit file mode, 
I found a place where the exception was being silent discarded.

I tried on Ubuntu 13.04 with a tmpfs.

> TDBLoader does not throw exception when disk full
> -------------------------------------------------
>
>                 Key: JENA-588
>                 URL: https://issues.apache.org/jira/browse/JENA-588
>             Project: Apache Jena
>          Issue Type: Bug
>          Components: TDB
>    Affects Versions: Jena 2.10.0
>            Reporter: Brian Caruso
>         Attachments: jena.diskFull.patch
>
>
> When using tdbload a full disk does not cause the load to throw an exception and exit. The process displays logging messages about the disk and then continues to attempt to save the next triple. 
> To reproduce fill up a temporary file system, then load a large NT file.



--
This message was sent by Atlassian JIRA
(v6.1#6144)